[lxc-devel] [lxc/lxc] c52517: coverity: #438136

Sun Aug 12 10:57:06 UTC 2018

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: c5251729ae2ddede32b293e9f188d625159e18dc
      https://github.com/lxc/lxc/commit/c5251729ae2ddede32b293e9f188d625159e18dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_destroy.c

  Log Message:
  -----------
  coverity: #438136

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2f1f53b8f303596a2dc36b04095a303c4a0d9417
      https://github.com/lxc/lxc/commit/2f1f53b8f303596a2dc36b04095a303c4a0d9417
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: build with -O0 for coverity

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5cbbc536e4acb30362fe60fee0b1056c0f31f7f8
      https://github.com/lxc/lxc/commit/5cbbc536e4acb30362fe60fee0b1056c0f31f7f8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: export CFLAGS=-O0 for coverity

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: afceba0ca11e5246c9ee22fb5013ee1648b553cb
      https://github.com/lxc/lxc/commit/afceba0ca11e5246c9ee22fb5013ee1648b553cb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    A src/lxc/macro.h
    M src/lxc/utils.h

  Log Message:
  -----------
  macro: add new macro header

This allows us to use a bunch of macros in our static build for init.lxc.static
without having to link against all of utils.{c,h}.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2edec6f524ea319b2c75da6b09517dd4076d3cf6
      https://github.com/lxc/lxc/commit/2edec6f524ea319b2c75da6b09517dd4076d3cf6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/caps.c

  Log Message:
  -----------
  caps: bugfixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5b21269e77c6453bb356110d84951a9732840b12
      https://github.com/lxc/lxc/commit/5b21269e77c6453bb356110d84951a9732840b12
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: bugfixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f2b4616565ddb05173ca2cbf07611d0ad8766b92
      https://github.com/lxc/lxc/commit/f2b4616565ddb05173ca2cbf07611d0ad8766b92
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/caps.c
    M src/lxc/conf.c
    M src/lxc/initutils.c
    M src/lxc/macro.h
    M src/lxc/start.c
    M src/lxc/storage/nbd.c
    M src/lxc/utils.c

  Log Message:
  -----------
  tree-wide: pass unsigned long to prctl()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4d37bc03eb58b48bc57f8e140c88531d102a3206
      https://github.com/lxc/lxc/commit/4d37bc03eb58b48bc57f8e140c88531d102a3206
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/log.c
    M src/lxc/log.h

  Log Message:
  -----------
  log: function cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: d9a381b9551a83feb161f0851a922744eab0aff2
      https://github.com/lxc/lxc/commit/d9a381b9551a83feb161f0851a922744eab0aff2
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/log.c
    M src/lxc/tools/arguments.c

  Log Message:
  -----------
  log: add default log priority

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: dcaf4640043556f7ea4defd4a6c779d008822dca
      https://github.com/lxc/lxc/commit/dcaf4640043556f7ea4defd4a6c779d008822dca
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: lxc-unshare: apply default log priority

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: f0e0ab1f6bf9ac285e65efaf0f0c478d56dbf590
      https://github.com/lxc/lxc/commit/f0e0ab1f6bf9ac285e65efaf0f0c478d56dbf590
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438236

Resource leak

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 9e03b3e82c16ad27bb6948e3bf8fc94258e12144
      https://github.com/lxc/lxc/commit/9e03b3e82c16ad27bb6948e3bf8fc94258e12144
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438235

Resource leak

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 1c98a6e7c1616f3e9511941a02c804207c01edc6
      https://github.com/lxc/lxc/commit/1c98a6e7c1616f3e9511941a02c804207c01edc6
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438234

Resource leak

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: a0a2c1a174ec3de7ab789076e294408419003e81
      https://github.com/lxc/lxc/commit/a0a2c1a174ec3de7ab789076e294408419003e81
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438233

Resource leak

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 54a3b3dfe6934bcfd27d6aadd720319b166ab5bb
      https://github.com/lxc/lxc/commit/54a3b3dfe6934bcfd27d6aadd720319b166ab5bb
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438229

Resource leak

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: eae95dc7331d65d5571abb9b9e750b903734a1dd
      https://github.com/lxc/lxc/commit/eae95dc7331d65d5571abb9b9e750b903734a1dd
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438230

Logically dead code

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: e97dfb8c8cbc4072b5afece468815985ee6b0936
      https://github.com/lxc/lxc/commit/e97dfb8c8cbc4072b5afece468815985ee6b0936
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438231

Dereference after null check

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 8b88aa053337398bdcc7a214444dbac187ee0f66
      https://github.com/lxc/lxc/commit/8b88aa053337398bdcc7a214444dbac187ee0f66
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  pam_cgfs: cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: f5c8f252be95eec24ad040f14bcdf0d3e059f373
      https://github.com/lxc/lxc/commit/f5c8f252be95eec24ad040f14bcdf0d3e059f373
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  coverity: #1438232

Failure to restore non-local value

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 65f0fc23f3b74a208bdadfcc4c5cc4c97c8d415f
      https://github.com/lxc/lxc/commit/65f0fc23f3b74a208bdadfcc4c5cc4c97c8d415f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  templates: avoid endless loop

Closes #2512.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9d5053a6a127f85fa543e893c09457f11dbe3703
      https://github.com/lxc/lxc/commit/9d5053a6a127f85fa543e893c09457f11dbe3703
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  CVE 2018-6556: verify netns fd in lxc-user-nic

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 12c3adb446d6b2cca293bff894937b32aa8de7fb
      https://github.com/lxc/lxc/commit/12c3adb446d6b2cca293bff894937b32aa8de7fb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: add Wolfgang Bumiller

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f2e770a19cdd4c70a360740e698f6fdd027d89b1
      https://github.com/lxc/lxc/commit/f2e770a19cdd4c70a360740e698f6fdd027d89b1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/network.c
    M src/lxc/network.h
    M src/lxc/start.c

  Log Message:
  -----------
  netns: allocate network namespace id

Start to allocate a new network namespace id for each container.

Relates to https://github.com/lxc/lxd/issues/4831.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4f32911f210f6a405bb4dfe702cd0e871412a191
      https://github.com/lxc/lxc/commit/4f32911f210f6a405bb4dfe702cd0e871412a191
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/macro.h
    M src/lxc/network.c

  Log Message:
  -----------
  macro: move network macros from utils.h

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ac9bd62499f7f6565bebd54232f0ac6a749e3b77
      https://github.com/lxc/lxc/commit/ac9bd62499f7f6565bebd54232f0ac6a749e3b77
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: add linux-libc-dev

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6810e31d1c32ba5422baf18bf273ca804d3275df
      https://github.com/lxc/lxc/commit/6810e31d1c32ba5422baf18bf273ca804d3275df
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/macro.h
    M src/lxc/network.c

  Log Message:
  -----------
  netns: vendor NETNSA_*

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1c0bec10681ad1398c83edb1c066b404d5b76128
      https://github.com/lxc/lxc/commit/1c0bec10681ad1398c83edb1c066b404d5b76128
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: type fixes lxc_netns_set_nsid()

The kernel expects a __s32 for NETNSA_NSID and a __u32 for NETNSA_FD.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4e194cee0c6c91e97f28c9534cbdec79a62b6da3
      https://github.com/lxc/lxc/commit/4e194cee0c6c91e97f28c9534cbdec79a62b6da3
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/tests/containertests.c

  Log Message:
  -----------
  tests: containertests: fix dereference pointer c

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 14c1904b7b216a23d8c0525ff58ea120c097b438
      https://github.com/lxc/lxc/commit/14c1904b7b216a23d8c0525ff58ea120c097b438
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/caps.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  fix tainted int loop bound issue

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 92cce8eefb2b6200bbf0f6a74e3e1ab069974beb
      https://github.com/lxc/lxc/commit/92cce8eefb2b6200bbf0f6a74e3e1ab069974beb
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/criu.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/btrfs.h

  Log Message:
  -----------
  fix assignment of signed to bigger unsigned issue

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 0ec7171ff334369234c6b2430ed27b6b8af501d3
      https://github.com/lxc/lxc/commit/0ec7171ff334369234c6b2430ed27b6b8af501d3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/macro.h
    M src/lxc/nl.c

  Log Message:
  -----------
  macro: add NLMSG_ERROR

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 60ce299fd8bed3043b06ee808e67fd867c905899
      https://github.com/lxc/lxc/commit/60ce299fd8bed3043b06ee808e67fd867c905899
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  netns: improve netnsid allocation

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5018440bccb13e2f99102614020bdf4819c97334
      https://github.com/lxc/lxc/commit/5018440bccb13e2f99102614020bdf4819c97334
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: make netnsid allocation failures non-fatal

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fcfb1b3e4ee7df91d8be0c6aa783b34e44017be8
      https://github.com/lxc/lxc/commit/fcfb1b3e4ee7df91d8be0c6aa783b34e44017be8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/lxc/network.c
    M src/lxc/nl.c
    M src/lxc/nl.h

  Log Message:
  -----------
  netlink: add __netlink_{send,recv,transaction}

These allow to pass a struct nlmsghdr directly and are used in the higher level
netlink_{send,rcv,transaction}.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/c1cf54ebf251...fcfb1b3e4ee7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.