[lxc-devel] [lxc/lxc] 139394: coverity: #1435210

Mon Apr 30 09:29:43 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 13939498edf6936ebd4c5c39d016d7e25996fabc
      https://github.com/lxc/lxc/commit/13939498edf6936ebd4c5c39d016d7e25996fabc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/tools/tool_utils.c

  Log Message:
  -----------
  coverity: #1435210

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8186c5c7c3bca23f7cfcc4a3fb867ba88add1a8e
      https://github.com/lxc/lxc/commit/8186c5c7c3bca23f7cfcc4a3fb867ba88add1a8e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1435208

Unused value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 91ae555c994febcf60b8ae243fc28e0cdbd04bab
      https://github.com/lxc/lxc/commit/91ae555c994febcf60b8ae243fc28e0cdbd04bab
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/tests/aa.c

  Log Message:
  -----------
  coverity: #1435207

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 46768cced9127002c7ee0fef3c63131c53692a65
      https://github.com/lxc/lxc/commit/46768cced9127002c7ee0fef3c63131c53692a65
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  coverity: #1435206

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dbdf8cf4203c4c655c7fdf0f67cb358a6fa96a71
      https://github.com/lxc/lxc/commit/dbdf8cf4203c4c655c7fdf0f67cb358a6fa96a71
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/tests/attach.c

  Log Message:
  -----------
  coverity: #1435205

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c1768f3f2527463af508aed60b5171bc7e82025a
      https://github.com/lxc/lxc/commit/c1768f3f2527463af508aed60b5171bc7e82025a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/parse.c

  Log Message:
  -----------
  coverity: #1435203

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 205fc0103b0ef16e6acaae7175e63a8b01e59494
      https://github.com/lxc/lxc/commit/205fc0103b0ef16e6acaae7175e63a8b01e59494
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1435200

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ba1de6dbfe630d3ed49cede91846602c5f497f48
      https://github.com/lxc/lxc/commit/ba1de6dbfe630d3ed49cede91846602c5f497f48
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  coverity: #1435198

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d2b5aceceaf14b19895a64ec0d3ba1b422a4f92b
      https://github.com/lxc/lxc/commit/d2b5aceceaf14b19895a64ec0d3ba1b422a4f92b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  coverity: #1426734

Argument cannot be negative

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0e14584db8024539e9d7d0e1b4f5ab33bba09366
      https://github.com/lxc/lxc/commit/0e14584db8024539e9d7d0e1b4f5ab33bba09366
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5647455516eaa745e37a32db8e839b6857cc77fb
      https://github.com/lxc/lxc/commit/5647455516eaa745e37a32db8e839b6857cc77fb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxccontainer: use thread-safe *_OFD_* locks

If they aren't available fallback to BSD flock()s.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 44619b6cd26eca8bc414344af4ba834a075659a0
      https://github.com/lxc/lxc/commit/44619b6cd26eca8bc414344af4ba834a075659a0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9e6304187bc71541779c2692777c25bed8c80724
      https://github.com/lxc/lxc/commit/9e6304187bc71541779c2692777c25bed8c80724
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_is_running()

There's no need to do string comparisons.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5df46fad0cda33f0cb098943bcbe659ce3409266
      https://github.com/lxc/lxc/commit/5df46fad0cda33f0cb098943bcbe659ce3409266
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_freeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e898947399c2f44537e9b5b9d95b8f3abb989c86
      https://github.com/lxc/lxc/commit/e898947399c2f44537e9b5b9d95b8f3abb989c86
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_unfreeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d630991d8f25dd29bf6d17bc6992cf19b1faa2ec
      https://github.com/lxc/lxc/commit/d630991d8f25dd29bf6d17bc6992cf19b1faa2ec
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7cea5905852bf935fa486f05192a5cb13942ad51
      https://github.com/lxc/lxc/commit/7cea5905852bf935fa486f05192a5cb13942ad51
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.c
    M src/lxc/lxccontainer.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  lxccontainer: use thread-safe open() + write()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9640c6a76763a5dfa7b7fd268772b1b0d195d9a9
      https://github.com/lxc/lxc/commit/9640c6a76763a5dfa7b7fd268772b1b0d195d9a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 630ac7c61bf76868f97de77a63b3b5e9826a8e75
      https://github.com/lxc/lxc/commit/630ac7c61bf76868f97de77a63b3b5e9826a8e75
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e62fd16fff675f4ec2dac7dd57a61f082bdbc206
      https://github.com/lxc/lxc/commit/e62fd16fff675f4ec2dac7dd57a61f082bdbc206
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-29 (Sun, 29 Apr 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ff62067703a7ec289cf450794a5ae919b1316667
      https://github.com/lxc/lxc/commit/ff62067703a7ec289cf450794a5ae919b1316667
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-04-30 (Mon, 30 Apr 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.c
    M src/lxc/lxccontainer.c
    M src/lxc/lxclock.c
    M src/lxc/parse.c
    M src/lxc/terminal.c
    M src/lxc/tools/lxc_create.c
    M src/lxc/tools/lxc_monitor.c
    M src/lxc/tools/tool_utils.c
    M src/lxc/utils.c
    M src/lxc/utils.h
    M src/tests/aa.c
    M src/tests/attach.c

  Log Message:
  -----------
  Merge pull request #2297 from brauner/2018-04-29/bugfixes

coverity

Compare: https://github.com/lxc/lxc/compare/ad38dca19367...ff62067703a7