[lxc-devel] [lxc/lxc] 112930: conf: ret-try devpts mount without gid=5 on error

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 112930688bd306592a215180cf9b5801e5358eb8
      https://github.com/lxc/lxc/commit/112930688bd306592a215180cf9b5801e5358eb8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: ret-try devpts mount without gid=5 on error

We should always default to mounting devpts with gid=5 but we should fallback
to mounting without gid=5. This let's us cover use-cases such as container
started with only a single mapping e.g.:

lxc.idmap = u 1000 1000 1
lxc.idmap = g 1000 1000 1

Closes #2257.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 794248d09d3a60633c901becc9d985db697f2feb
      https://github.com/lxc/lxc/commit/794248d09d3a60633c901becc9d985db697f2feb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/execute.c
    M src/lxc/start.h

  Log Message:
  -----------
  execute: fix app containers without root mapping

When starting application containers without a mapping for container root are
started, a dummy bind-mount target for lxc-init needs to be created. This will
not always work directly under "/" when e.g. permissions are missing due to the
ownership and/or mode of "/". We can try to work around this by using the
P_tmpdir as defined in POSIX which should usually land us in /tmp where
basically everyone can create files.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 465c891a7bf31bde0752b06876c120f3402082c6
      https://github.com/lxc/lxc/commit/465c891a7bf31bde0752b06876c120f3402082c6
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/execute.c
    M src/lxc/start.h

  Log Message:
  -----------
  Merge pull request #2272 from brauner/2018-04-12/bugfixes

conf: ret-try devpts mount without gid=5 on error


Compare: https://github.com/lxc/lxc/compare/855452aede61...465c891a7bf3