[lxc-devel] [lxc/lxc] dfb8c3: conf: add userns_exec_full()

Sun Sep 24 04:27:14 UTC 2017

  Branch: refs/heads/stable-2.1
  Home:   https://github.com/lxc/lxc
  Commit: dfb8c30342f7fe04f6abfb201bab41d3c5af18e7
      https://github.com/lxc/lxc/commit/dfb8c30342f7fe04f6abfb201bab41d3c5af18e7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h

  Log Message:
  -----------
  conf: add userns_exec_full()

Closes #1800.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4f0ba8f68c33e0c030efd643232816c02a655ee8
      https://github.com/lxc/lxc/commit/4f0ba8f68c33e0c030efd643232816c02a655ee8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: use userns_exec_full()

Closes #1800.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 454d6a184d15f2d747d9f4969867a5cf7b22e14c
      https://github.com/lxc/lxc/commit/454d6a184d15f2d747d9f4969867a5cf7b22e14c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: userns_exec_full()

Closes #1800.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c24b8ba04e914b98e20ce69d510d2e8216abe40
      https://github.com/lxc/lxc/commit/2c24b8ba04e914b98e20ce69d510d2e8216abe40
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/aufs.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/overlay.c
    M src/lxc/storage/storage.c
    M src/lxc/storage/storage.h

  Log Message:
  -----------
  storage: use userns_exec_full()

Closes #1800.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7cb4a867942e8938fc896d769295f92cf02c76df
      https://github.com/lxc/lxc/commit/7cb4a867942e8938fc896d769295f92cf02c76df
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/console.c

  Log Message:
  -----------
  console: remove dead assignments

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 77e7b5e2509588fa95243f07f6cf4182e72bb4e1
      https://github.com/lxc/lxc/commit/77e7b5e2509588fa95243f07f6cf4182e72bb4e1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: remove dead assignment

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 27cd01771e0e55fe4482c169719882983728b5bc
      https://github.com/lxc/lxc/commit/27cd01771e0e55fe4482c169719882983728b5bc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: remove dead variable

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c0b3869fac0762023fdd23fe3555d8992d5fa6f2
      https://github.com/lxc/lxc/commit/c0b3869fac0762023fdd23fe3555d8992d5fa6f2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  criu: use correct check initialization check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3874902c63de007c5f9a8dcb0fcbddc5560266bf
      https://github.com/lxc/lxc/commit/3874902c63de007c5f9a8dcb0fcbddc5560266bf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/overlay.c

  Log Message:
  -----------
  storage/overlay: do not write to invalid memory

Closes #1802.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b02d1aee4e37d6d9c0be5a4831ceef9eb1b71d70
      https://github.com/lxc/lxc/commit/b02d1aee4e37d6d9c0be5a4831ceef9eb1b71d70
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: do not write to 0 sized buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d1059ba6e5448ecfa053d3acf608cafe54c2a005
      https://github.com/lxc/lxc/commit/d1059ba6e5448ecfa053d3acf608cafe54c2a005
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/overlay.c

  Log Message:
  -----------
  overlay: fix use after free()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 46006ae3560090d16e822237267ccb587bb46cf8
      https://github.com/lxc/lxc/commit/46006ae3560090d16e822237267ccb587bb46cf8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/confile_utils.c

  Log Message:
  -----------
  confile: parse_idmaps() remove dead assignments

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 49ae1eef4e21b6dbd236c979389d44fe7c61852c
      https://github.com/lxc/lxc/commit/49ae1eef4e21b6dbd236c979389d44fe7c61852c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  lxc-unshare: do not pass NULL pointer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f0475785ce2592113bd0636dba904aeb04fd1b53
      https://github.com/lxc/lxc/commit/f0475785ce2592113bd0636dba904aeb04fd1b53
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/tools/lxc_usernsexec.c

  Log Message:
  -----------
  lxc_usernsexec: remove dead assignments

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 32068a264b6f4b88c5d365269fa98d3f84511aca
      https://github.com/lxc/lxc/commit/32068a264b6f4b88c5d365269fa98d3f84511aca
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/tests/containertests.c
    M src/tests/destroytest.c
    M src/tests/saveconfig.c
    M src/tests/shortlived.c
    M src/tests/startone.c

  Log Message:
  -----------
  tests: remove dead assignments

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8c01f2c276758e6823566fe03832ae4711b29662
      https://github.com/lxc/lxc/commit/8c01f2c276758e6823566fe03832ae4711b29662
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/tests/concurrent.c

  Log Message:
  -----------
  tests: avoid NULL pointer dereference

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 57064bd4753267c2321f8b639852f866091b2226
      https://github.com/lxc/lxc/commit/57064bd4753267c2321f8b639852f866091b2226
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: lxc_popen() remove dead assignments

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 671f6f946264b9683f25004d2c44212bfdebf5d9
      https://github.com/lxc/lxc/commit/671f6f946264b9683f25004d2c44212bfdebf5d9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: remove double initialization

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f93a376b9be8f3848284944ab06effe90755f28c
      https://github.com/lxc/lxc/commit/f93a376b9be8f3848284944ab06effe90755f28c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: remove dead assignments

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e4f0f03dd5ec8e3d3457a281d8c3156520d3ea71
      https://github.com/lxc/lxc/commit/e4f0f03dd5ec8e3d3457a281d8c3156520d3ea71
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: preserve newlines

Users were confused when the config file created during cloning or copying a
container suddenly missed all newlines. Let's keep them.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c4bb8e39675fb9bd95959d95367dba54fbbedfd
      https://github.com/lxc/lxc/commit/2c4bb8e39675fb9bd95959d95367dba54fbbedfd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/console.c

  Log Message:
  -----------
  execute: enable console & standard /dev symlinks

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d745d937538081c456b850845680aa18b4a1da65
      https://github.com/lxc/lxc/commit/d745d937538081c456b850845680aa18b4a1da65
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: switch ids at last possible instance

This is technically not necessary but it is a privilege sensitive operation.
Meaning if anyone wants to do something that requires privilege it should be
done before the id switch. So let's move the id switch immediately before the
exec so that it's called at the last possible moment.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6445152b1cfa0a46716eb129ea0066c0375f05a0
      https://github.com/lxc/lxc/commit/6445152b1cfa0a46716eb129ea0066c0375f05a0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  storage: avoid segfault

When the "lxc.rootfs.path" property is not set and users request a container
copy we would segfault since strstr() would be called on a NULL pointer.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 878935fdd5b6913df8e5beda3d65203e450da429
      https://github.com/lxc/lxc/commit/878935fdd5b6913df8e5beda3d65203e450da429
  Author: KATOH Yasufumi <karma at jazz.email.ne.jp>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M templates/lxc-plamo.in

  Log Message:
  -----------
  plamo: Delete unnecessary process during container shutdown

Since some remounts/umounts is executed in the plamo shutdown script,
the filesystem on where a container exists might be mount as
read-only. This patch delete some mounts and umounts from the shutdown
script. It also delete hwclock setting process.

And delete an unncecessary output.

Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>

  Commit: 96912df80ee990ee083bc280303f0eeac034e4a8
      https://github.com/lxc/lxc/commit/96912df80ee990ee083bc280303f0eeac034e4a8
  Author: Christian von Roques <roques at mti.ag>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M doc/lxc-monitor.sgml.in

  Log Message:
  -----------
  fix regex-typo in lxc-monitor.sgml.in

To match names beginning with the letters "f" or "b" one can use
the regular expression "[fb].*" or "(f|b).*", but not "[f|b].*",
which would match strings beginning with "f", "|", or "b".

Signed-off-by: Christian von Roques <roques at z12.ch>

  Commit: 68348321fb7639b7c2207bf86561aa527b467d11
      https://github.com/lxc/lxc/commit/68348321fb7639b7c2207bf86561aa527b467d11
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: move env setup before container setup

The hooks (e.g. lxc.hook.mount) should have the environment variables the user
gave us available.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0223037cab6faf639236bd5957c4389ca5156906
      https://github.com/lxc/lxc/commit/0223037cab6faf639236bd5957c4389ca5156906
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: set environment variables correctly

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 91b7052311cd869cc3441e2f08f013434191dc40
      https://github.com/lxc/lxc/commit/91b7052311cd869cc3441e2f08f013434191dc40
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: pass LXC_LOG_LEVEL to hooks

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 19615db8e98e3b00ffdf88a855e5fe7fea29361f
      https://github.com/lxc/lxc/commit/19615db8e98e3b00ffdf88a855e5fe7fea29361f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M doc/lxc.container.conf.sgml.in

  Log Message:
  -----------
  doc: document missing env variables

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5846c3b46c1507945515674d5930d4582cc5a9ad
      https://github.com/lxc/lxc/commit/5846c3b46c1507945515674d5930d4582cc5a9ad
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: duplicate stderr as well in lxc_popen()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: be21683d846a010b3714b8450d978dd6fa9e0886
      https://github.com/lxc/lxc/commit/be21683d846a010b3714b8450d978dd6fa9e0886
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: fix lxc_popen()/lxc_pclose()

- rework and fix pipe fd leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7af6a121f2c7f841f5f9eb7a93816a5f80d7787e
      https://github.com/lxc/lxc/commit/7af6a121f2c7f841f5f9eb7a93816a5f80d7787e
  Author: Rune Juhl Jacobsen <runejuhl at petardo.dk>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M templates/lxc-alpine.in

  Log Message:
  -----------
  Change file check to also check file size (`-f` => `-s`)

Because the `fetch` wget wrapper outputs files to stdout we may end up in a
situation where wget fails but the files are still created. This can happen
e.g. when the host date is out of sync leading to a failed certificate
check, resulting in the creation of empty key files.

Once the empty files have been created the template will try to use them which
causes the certificate check to fail.

By using `-s` instead of `-f` the template will re-fetch the files unless they
exist AND have a size greater than zero.

Signed-off-by: Rune Juhl Jacobsen <runejuhl at petardo.dk>

  Commit: 6d49eb312f0c14aecea8833349a89770e870b99b
      https://github.com/lxc/lxc/commit/6d49eb312f0c14aecea8833349a89770e870b99b
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/tests/lxc-test-apparmor-mount
    M src/tests/lxc-test-unpriv
    M src/tests/lxc-test-usernic.in

  Log Message:
  -----------
  tests: Support systemd hybrid cgroups

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

  Commit: a5a27d88a648cc929ed6ba8891fe753ac5f36bd1
      https://github.com/lxc/lxc/commit/a5a27d88a648cc929ed6ba8891fe753ac5f36bd1
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  Fix typo

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

  Commit: 0e2e759fa481f7054a458b0b28723eb1b2321520
      https://github.com/lxc/lxc/commit/0e2e759fa481f7054a458b0b28723eb1b2321520
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M configure.ac
    M doc/Makefile.am
    A doc/lxc-update-config.sgml.in

  Log Message:
  -----------
  doc: add lxc-update-config manpage

Closes #1818.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 818196b509a522e5a27950e5a535f456cd6b5430
      https://github.com/lxc/lxc/commit/818196b509a522e5a27950e5a535f456cd6b5430
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: fail when limits fail to apply

So far, we silently skipped over limits that failed to be applied which is very
odd. Let's error on when cgroup limits fail to apply.

Closes #1815.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 311f4642ce3fbbbec4e1957269ea1e22a617c96a
      https://github.com/lxc/lxc/commit/311f4642ce3fbbbec4e1957269ea1e22a617c96a
  Author: KATOH Yasufumi <karma at jazz.email.ne.jp>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M doc/ja/lxc-monitor.sgml.in
    M doc/ko/lxc-monitor.sgml.in

  Log Message:
  -----------
  doc: fix regex-typo in Japanese and Korean lxc-monitor(1)

Update for commit e3dd06ef41b63d0ee362fea74a3f2d798dbfe929

Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>

  Commit: c37f111f2d9e18b2256c561fd460cd4aae954274
      https://github.com/lxc/lxc/commit/c37f111f2d9e18b2256c561fd460cd4aae954274
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-24 (Sun, 24 Sep 2017)

  Changed paths:
    M src/lxc/storage/zfs.c

  Log Message:
  -----------
  zfs: return error directly when zfs creation fails

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/1da539b04600...c37f111f2d9e