[lxc-devel] [lxc/lxc] 76bdf2: start: switch ids at last possible instance

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 76bdf2992c0c90f55b233dd5985d49d02c0c55a7
      https://github.com/lxc/lxc/commit/76bdf2992c0c90f55b233dd5985d49d02c0c55a7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: switch ids at last possible instance

This is technically not necessary but it is a privilege sensitive operation.
Meaning if anyone wants to do something that requires privilege it should be
done before the id switch. So let's move the id switch immediately before the
exec so that it's called at the last possible moment.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 45b4bb961820074ddee2cdebd3a5feec997e2906
      https://github.com/lxc/lxc/commit/45b4bb961820074ddee2cdebd3a5feec997e2906
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  storage: avoid segfault

When the "lxc.rootfs.path" property is not set and users request a container
copy we would segfault since strstr() would be called on a NULL pointer.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2569f6f6f537864494186006eddd57361a426232
      https://github.com/lxc/lxc/commit/2569f6f6f537864494186006eddd57361a426232
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/lxc/start.c
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  Merge pull request #1803 from brauner/2017-09-10/lxc_execute_switch_ids_last

start: switch ids at last possible instance


Compare: https://github.com/lxc/lxc/compare/42f055d0f6ae...2569f6f6f537