[lxc-devel] Still Failing: lxc/lxc#3850 (stable-2.0 - 44a43f5)

[Travis CI]

Build Update for lxc/lxc
-------------------------------------

Build: #3850
Status: Still Failing

Duration: 1 minute and 59 seconds
Commit: 44a43f5 (stable-2.0)
Author: LiFeng
Message: console: clean tty state + return 0 on peer exit

In the past, if the console client exited, lxc_console_cb_con return 1. And
the lxc_poll will exit, the process will wait at waitpid. At this moment, the
process could not handle any command (For example get the container state
LXC_CMD_GET_STATE or stop the container LXC_CMD_STOP.).

I think we should clean the tty_state and return 0 in this case. So, we can use
the lxc-console to connect the console of the container. And we will not exit
the function lxc_polland we can handle the commands by lxc_cmd_process

Reproducer prior to this commit:
- open a new terminal, get the tty device name by command tty /dev/pts/6
- set lxc.console.path = /dev/pts/6
- start the container and the ouptut will print to /dev/pts/6
- close /dev/pts/6
- try an operation e.g. getting state with lxc-ls and lxc-ls will hang

Closes #1787.

Signed-off-by: LiFeng <lifeng68 at huawei.com>
Acked-by: Christian Brauner <christian.brauner at ubuntu.com>

View the changeset: https://github.com/lxc/lxc/compare/f0ab9713f9d2...44a43f52b429

View the full build log and details: https://travis-ci.org/lxc/lxc/builds/273910658?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20170910/c2148abd/attachment-0001.html>