[lxc-devel] [lxc/lxc] 25af2a: confile: make update warning opt-in

GitHub noreply at github.com
Wed Oct 11 16:25:52 UTC 2017


  Branch: refs/heads/stable-2.1
  Home:   https://github.com/lxc/lxc
  Commit: 25af2ac7f3aa524092258c0da128a6223f98cfed
      https://github.com/lxc/lxc/commit/25af2ac7f3aa524092258c0da128a6223f98cfed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_autostart.c
    M src/lxc/tools/lxc_cgroup.c
    M src/lxc/tools/lxc_checkpoint.c
    M src/lxc/tools/lxc_clone.c
    M src/lxc/tools/lxc_config.c
    M src/lxc/tools/lxc_console.c
    M src/lxc/tools/lxc_copy.c
    M src/lxc/tools/lxc_create.c
    M src/lxc/tools/lxc_destroy.c
    M src/lxc/tools/lxc_device.c
    M src/lxc/tools/lxc_execute.c
    M src/lxc/tools/lxc_freeze.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_ls.c
    M src/lxc/tools/lxc_monitor.c
    M src/lxc/tools/lxc_snapshot.c
    M src/lxc/tools/lxc_start.c
    M src/lxc/tools/lxc_stop.c
    M src/lxc/tools/lxc_unfreeze.c
    M src/lxc/tools/lxc_wait.c

  Log Message:
  -----------
  confile: make update warning opt-in

With the release LXC 2.1 we started warning users who use LXC through the API
and users who use LXC through the tools equally about updating their config.
This quickly got confusing and annoying to API users who e.g. generate configs
on the fly (e.g. LXD). So instead of unconditionally warning users we make this
opt-in. If LXC detects that the env variable LXC_UPDATE_CONFIG_FORMAT is set
then it will warn the user if any legacy configuration keys are present. If it
is not set however, it will not warn the user. This is ok, since the log will
still log WARN()s for all legacy configuration keys.
The tools will all set LXC_UPDATE_CONFIG_FORMAT since it is very much required
that users update to the new configuration format pre-LXC 3.0.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>




More information about the lxc-devel mailing list