[lxc-devel] [lxc/lxc] fdf3ef: Don't force getty@ configuration

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: fdf3ef0a0d9e5570d0d2eed4a7427ec978d839b2
      https://github.com/lxc/lxc/commit/fdf3ef0a0d9e5570d0d2eed4a7427ec978d839b2
  Author: Alf Gaida <agaida at siduction.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  Don't force getty@ configuration

```
    # this only works if we have getty at .service to manipulate
    if [ -f "${rootfs}/lib/systemd/system/getty at .service" ]; then
       sed -e 's/^ConditionPathExists=/# ConditionPathExists=/' \
     -e 's/After=dev-%i.device/After=/' \
     < "${rootfs}/lib/systemd/system/getty at .service" \
     > "${rootfs}/etc/systemd/system/getty at .service"
    fi
```
we have only /dev/tty in a container - so this little cutie will spam the log all 10s with the following:

```
Jul 28 22:33:00 mariadb systemd[1]: getty at tty4.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty3.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty1.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty2.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:00 mariadb systemd[1]: Stopped Getty on tty2.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty2.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty2.service, ignoring: Operation not permitted
Jul 28 22:33:00 mariadb systemd[1]: Started Getty on tty2.
Jul 28 22:33:00 mariadb systemd[1]: Stopped Getty on tty1.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty1.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty1.service, ignoring: Operation not permitted
Jul 28 22:33:00 mariadb systemd[1]: Started Getty on tty1.
Jul 28 22:33:00 mariadb systemd[1]: Stopped Getty on tty3.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty3.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty3.service, ignoring: Operation not permitted
Jul 28 22:33:00 mariadb systemd[1]: Started Getty on tty3.
Jul 28 22:33:00 mariadb systemd[1]: Stopped Getty on tty4.
Jul 28 22:33:00 mariadb systemd[1]: getty at tty4.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty4.service, ignoring: Operation not permitted
Jul 28 22:33:00 mariadb systemd[1]: Started Getty on tty4.
Jul 28 22:33:00 mariadb agetty[242]: /dev/tty1: cannot open as standard input: No such file or directory
Jul 28 22:33:00 mariadb agetty[241]: /dev/tty2: cannot open as standard input: No such file or directory
Jul 28 22:33:00 mariadb agetty[244]: /dev/tty4: cannot open as standard input: No such file or directory
Jul 28 22:33:00 mariadb agetty[243]: /dev/tty3: cannot open as standard input: No such file or directory
Jul 28 22:33:10 mariadb systemd[1]: getty at tty4.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty2.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty1.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty3.service: Service has no hold-off time, scheduling restart.
Jul 28 22:33:10 mariadb systemd[1]: Stopped Getty on tty3.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty3.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty3.service, ignoring: Operation not permitted
Jul 28 22:33:10 mariadb systemd[1]: Started Getty on tty3.
Jul 28 22:33:10 mariadb systemd[1]: Stopped Getty on tty1.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty1.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty1.service, ignoring: Operation not permitted
Jul 28 22:33:10 mariadb systemd[1]: Started Getty on tty1.
Jul 28 22:33:10 mariadb systemd[1]: Stopped Getty on tty2.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty2.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty2.service, ignoring: Operation not permitted
Jul 28 22:33:10 mariadb systemd[1]: Started Getty on tty2.
Jul 28 22:33:10 mariadb systemd[1]: Stopped Getty on tty4.
Jul 28 22:33:10 mariadb systemd[1]: getty at tty4.service: Failed to set invocation ID on control group /system.slice/system-getty.slice/getty at tty4.service, ignoring: Operation not permitted
Jul 28 22:33:10 mariadb systemd[1]: Started Getty on tty4.
Jul 28 22:33:10 mariadb agetty[245]: /dev/tty3: cannot open as standard input: No such file or directory
Jul 28 22:33:10 mariadb agetty[247]: /dev/tty2: cannot open as standard input: No such file or directory
Jul 28 22:33:10 mariadb agetty[246]: /dev/tty1: cannot open as standard input: No such file or directory
Jul 28 22:33:10 mariadb agetty[248]: /dev/tty4: cannot open as standard input: No such file or directory
```
if more reasons are whished i could attach the logs from 10 containers after one month runtime. (approx 30G)

Signed-off-by: Alf Gaida <agaida at siduction.org>


  Commit: 7c8f5d1d0149e08c71738f4a040ce65f8abbfbca
      https://github.com/lxc/lxc/commit/7c8f5d1d0149e08c71738f4a040ce65f8abbfbca
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2017-10-06 (Fri, 06 Oct 2017)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  Merge pull request #1718 from agaida/patch-1

Don't force getty@ configuration


Compare: https://github.com/lxc/lxc/compare/a363e3264b43...7c8f5d1d0149