[lxc-devel] [lxc/lxc] 327500: confile: fix memory leak

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 327500d449845f2694d87143925296a4a5d619b6
      https://github.com/lxc/lxc/commit/327500d449845f2694d87143925296a4a5d619b6
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: fix memory leak

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 8bc6d5393c6698e9803156f9eb977a748a1b510f
      https://github.com/lxc/lxc/commit/8bc6d5393c6698e9803156f9eb977a748a1b510f
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  tests: add a function for negative netdev tests

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 26e92b0eabd5dbd99f958bd1e7f57d900d59a681
      https://github.com/lxc/lxc/commit/26e92b0eabd5dbd99f958bd1e7f57d900d59a681
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: fix infinite loop with multiple lxc.log.syslog keys

This caused the linked list of appenders to loop on itself, creating
an infinite logging loop in `__lxc_log_append`.

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 24fa7df6f16755f52add95ba52edeb67c6cb9324
      https://github.com/lxc/lxc/commit/24fa7df6f16755f52add95ba52edeb67c6cb9324
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_legacy.c
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  confile: error out if a network configuration key has no subkey

This prevent an infinite recursion in the case of "lxc.net.0. = a"

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 44047b2b200297c72187886b5f40d47dccc0b1b0
      https://github.com/lxc/lxc/commit/44047b2b200297c72187886b5f40d47dccc0b1b0
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/lxc/confile_utils.c
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  confile_utils: simplify lxc_config_net_hwaddr

In addition to the memory corruption fixed in ee3e84df78424d26fc6c90862fbe0fa92a686b0d,
this function was also performing invalid memory accesses for the following inputs:
- `lxc.net`
- `lxc.net.`
- `lxc.net.0.`
- `lxc.network`
- `lxc.network.0.`

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 6370793188a19187f6a7742fb0d288c0f3531af6
      https://github.com/lxc/lxc/commit/6370793188a19187f6a7742fb0d288c0f3531af6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_legacy.c
    M src/lxc/confile_utils.c
    M src/lxc/log.c
    M src/tests/lxc-test-utils.c
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  Merge pull request #1955 from flx42/confile-fix-misc-issues

Fix errors in configuration file parsing


Compare: https://github.com/lxc/lxc/compare/242146d9e424...6370793188a1