[lxc-devel] [lxc/lxc] a48998: conf: non-functional changes lxc_fill_autodev()

Wed May 10 21:03:30 UTC 2017

  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: a489983a31f04de783fe1a6c42434caa73b31d38
      https://github.com/lxc/lxc/commit/a489983a31f04de783fe1a6c42434caa73b31d38
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes lxc_fill_autodev()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b55e06bea33869940a50d72c9055eef992da68fe
      https://github.com/lxc/lxc/commit/b55e06bea33869940a50d72c9055eef992da68fe
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove /dev/console from lxc_fill_autodev()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bb826cfee7795018ee449136f6a824de4c0c7ff5
      https://github.com/lxc/lxc/commit/bb826cfee7795018ee449136f6a824de4c0c7ff5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes lxc_setup()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 78580ddbc13c0dd4e2c3af950f8dc96410502ced
      https://github.com/lxc/lxc/commit/78580ddbc13c0dd4e2c3af950f8dc96410502ced
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes to console functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3c9c967e10d8e86430dbfdd558e6b331c89d0e39
      https://github.com/lxc/lxc/commit/3c9c967e10d8e86430dbfdd558e6b331c89d0e39
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: improve lxc_setup_dev_console()

In case the user did request a console to be set up unmount any prior
bind-mount for it.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a3b2199bc8173d8df030be9f4d62d91f1da80797
      https://github.com/lxc/lxc/commit/a3b2199bc8173d8df030be9f4d62d91f1da80797
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: lxc_setup_ttydir_console()

In case the user specified

lxc.console = none
lxc.devttydir = bla
lxc.mount.entry = /dev/console dev/console none bind,create=file 0 0

move the mount under /dev/bla/console

If he requested a mknod()ed /dev/console rename it to /dev/bla/console.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e993a8dd493c3311039ac16068aec0975917b2f1
      https://github.com/lxc/lxc/commit/e993a8dd493c3311039ac16068aec0975917b2f1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M config/templates/userns.conf.in

  Log Message:
  -----------
  config: remove /dev/console bind mount

The code in conf will bind-mount a /dev/pts/<n> device over a dummy regular
/dev/console file. If users really want /dev/console bind-mount from the host
they can request it explicitly in the containers config file. This change will
have no effect on current LX{C,D} behavior since we (as said above) overmount
the /dev/console bind-mount anyway.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2e930f349d3b5250e772ce525e8183bc90e39d76
      https://github.com/lxc/lxc/commit/2e930f349d3b5250e772ce525e8183bc90e39d76
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M doc/lxc.container.conf.sgml.in

  Log Message:
  -----------
  doc: document console behavior

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b243e8e56d43df1240847d064b444141417b6b63
      https://github.com/lxc/lxc/commit/b243e8e56d43df1240847d064b444141417b6b63
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add lxc_unstack_mountpoint()

lxc_unstack_mountpoint() tries to clear all mountpoints from a given path.
It return the number of successful umounts on success and -errno on error.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4ad9000f47585edcc078be43da1c5b437eafdbf6
      https://github.com/lxc/lxc/commit/4ad9000f47585edcc078be43da1c5b437eafdbf6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: unstack all mounts atop /dev/console

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 70f89aa1940789cf4484cd1e2f1e48d90b10943e
      https://github.com/lxc/lxc/commit/70f89aa1940789cf4484cd1e2f1e48d90b10943e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/console.c

  Log Message:
  -----------
  console: fail when we cannot allocate peer tty

There's really no reason not to if it's requested.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2ff023b747fdbb7a509f5782a4f3d8fbe6cf4de9
      https://github.com/lxc/lxc/commit/2ff023b747fdbb7a509f5782a4f3d8fbe6cf4de9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: remove umount2()

I really fail to see the point of this and git {blame, log -S} don't really
enlighten me on the reason for this as well. But I might be dense. The way I
see it the only thing this line achieves is causing trouble when the container
is started as root because the umount2() call will umount e.g.
/usr/lib/x86_64-linux-gnu/lxc in case it is a mountpoint on the host. Note,
this is because lxc_spawn() is still called in the hosts namespaces.

Closes https://github.com/lxc/lxd/#3255.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 75022b5728011315fa0d25b9e61fa3943d68353d
      https://github.com/lxc/lxc/commit/75022b5728011315fa0d25b9e61fa3943d68353d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/2e6347d67201...75022b572801