[lxc-devel] [lxc/lxc] 58d5b5: start: remove umount2()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 58d5b5279539b2a8e6be1aaeb2e96295357ac002
      https://github.com/lxc/lxc/commit/58d5b5279539b2a8e6be1aaeb2e96295357ac002
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: remove umount2()

I really fail to see the point of this and git {blame, log -S} don't really
enlighten me on the reason for this as well. But I might be dense. The way I
see it the only thing this line achieves is causing trouble when the container
is started as root because the umount2() call will umount e.g.
/usr/lib/x86_64-linux-gnu/lxc in case it is a mountpoint on the host. Note,
this is because lxc_spawn() is still called in the hosts namespaces.

Closes https://github.com/lxc/lxd/#3255.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 39c7b795b113d72b1617709b5cf64fa0bd470ad5
      https://github.com/lxc/lxc/commit/39c7b795b113d72b1617709b5cf64fa0bd470ad5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 60883ba8e1671d70aedfee56cd9769d396f5cc51
      https://github.com/lxc/lxc/commit/60883ba8e1671d70aedfee56cd9769d396f5cc51
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/start.c

  Log Message:
  -----------
  Merge pull request #1547 from brauner/2017-05-10/prevent_umount_propagation

start: remove umount2()


Compare: https://github.com/lxc/lxc/compare/eb09dc4eb771...60883ba8e167