[lxc-devel] [lxc/master] don't set a default password for altlinux, gentoo, openmandriva and pld

[evgeni on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 361 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20170319/f6787d13/attachment.bin>
-------------- next part --------------
From 436ab4be72a2f1b362a7607b0aa1cbb6d4ac13c2 Mon Sep 17 00:00:00 2001
From: Evgeni Golov <evgeni at debian.org>
Date: Sun, 19 Mar 2017 18:47:17 +0100
Subject: [PATCH] don't set a default password for altlinux, gentoo,
 openmandriva and pld

Refs: #1158
Signed-off-by: Evgeni Golov <evgeni at debian.org>
---
 templates/lxc-altlinux.in     | 7 ++++---
 templates/lxc-gentoo.in       | 3 ---
 templates/lxc-openmandriva.in | 1 -
 templates/lxc-pld.in          | 7 ++++---
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/templates/lxc-altlinux.in b/templates/lxc-altlinux.in
index 69c18d4..7accf24 100644
--- a/templates/lxc-altlinux.in
+++ b/templates/lxc-altlinux.in
@@ -43,7 +43,6 @@ cache_base=@LOCALSTATEDIR@/cache/lxc/altlinux/$arch
 default_path=@LXCPATH@
 default_profile=default
 profile_dir=/etc/lxc/profiles
-root_password=rooter
 lxc_network_type=veth
 lxc_network_link=virbr0
 
@@ -156,8 +155,10 @@ EOF
     mkdir -m 755 ${dev_path}/net
     mknod -m 666 ${dev_path}/net/tun c 10 200
 
-    echo "setting root passwd to $root_password"
-    echo "root:$root_password" | chroot $rootfs_path chpasswd
+    if [ -n "${root_password}" ]; then
+        echo "setting root passwd to $root_password"
+        echo "root:$root_password" | chroot $rootfs_path chpasswd
+    fi
 
     return 0
 }
diff --git a/templates/lxc-gentoo.in b/templates/lxc-gentoo.in
index 2ad16e8..47f24d0 100644
--- a/templates/lxc-gentoo.in
+++ b/templates/lxc-gentoo.in
@@ -654,8 +654,6 @@ container_auth()
         printf "  => done. if you didn't specify , default is 'toor'\n"
         if [[ -n "${forced_password}" ]]; then
             store_user_message "${user} has the password you give for him"
-        else
-            store_user_message "${user} has the default password 'toor', please change it ASAP"
         fi
     fi
 
@@ -779,7 +777,6 @@ set_default_arch
 
 mirror="http://distfiles.gentoo.org"
 user="root"
-password="toor"
 tty=1
 settings="common"
 options=$(getopt -o hp:n:a:FcPv:t:S:u:w:s:m: -l help,rootfs:,path:,name:,arch:,flush-cache,cache-only,private-portage,variant:,portage-dir:,tarball:,auth-key:,user:,autologin,password:,settings:,mirror:,tty: -- "$@")
diff --git a/templates/lxc-openmandriva.in b/templates/lxc-openmandriva.in
index 12f9985..daba812 100644
--- a/templates/lxc-openmandriva.in
+++ b/templates/lxc-openmandriva.in
@@ -46,7 +46,6 @@ hostarch=$(uname -m)
 cache_base="${LXC_CACHE_PATH:- at LOCALSTATEDIR@/cache/lxc/openmandriva/$arch}"
 default_path=@LXCPATH@
 default_profile=default
-root_password=root
 lxc_network_type=veth
 lxc_network_link=br0
 
diff --git a/templates/lxc-pld.in b/templates/lxc-pld.in
index f233ae6..a8e5346 100644
--- a/templates/lxc-pld.in
+++ b/templates/lxc-pld.in
@@ -38,7 +38,6 @@ done
 arch=$(uname -m)
 cache_base=@LOCALSTATEDIR@/cache/lxc/pld/$arch
 default_path=@LXCPATH@
-root_password=root
 
 if [ -e /etc/os-release ]; then
 	# This is a shell friendly configuration file.  We can just source it.
@@ -105,8 +104,10 @@ EOF
 	mknod -m 600 ${dev_path}/initctl p
 	mknod -m 666 ${dev_path}/ptmx c 5 2
 
-	echo "setting root passwd to $root_password"
-	echo "root:$root_password" | chroot $rootfs_path chpasswd
+	if [ -n "${root_password}" ]; then
+		echo "setting root passwd to $root_password"
+		echo "root:$root_password" | chroot $rootfs_path chpasswd
+	fi
 
 	return 0
 }