[lxc-devel] [lxc/lxc] 663e99: network: mv config_value_empty() to confile_utils

GitHub noreply at github.com
Sun Jun 18 22:24:28 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 663e99165e10bc59e590f35b11c1ef3883c0b617
      https://github.com/lxc/lxc/commit/663e99165e10bc59e590f35b11c1ef3883c0b617
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: mv config_value_empty() to confile_utils

and rename it to lxc_config_value_empty()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c7e27aaf3b7995bf4f0dc9a11a6b2476e41ff4d6
      https://github.com/lxc/lxc/commit/c7e27aaf3b7995bf4f0dc9a11a6b2476e41ff4d6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  network: add data arg to set callback

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5c35a8f1d97b532d6ecc5530540e46d3225425c8
      https://github.com/lxc/lxc/commit/5c35a8f1d97b532d6ecc5530540e46d3225425c8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.h

  Log Message:
  -----------
  network: add network counter

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ce2f5ae83f729915c09abdceb94e358662574664
      https://github.com/lxc/lxc/commit/ce2f5ae83f729915c09abdceb94e358662574664
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: implement lxc_get_netdev_by_idx()

lxc_get_netdev_by_idx() takes care of checking whether a given netdev struct
for a given index is already allocated. If so it returns a pointer to it to the
caller.
If it doesn't find it it will allocate a new netdev struct and insert it into
the network list at the right position. For example, let's say you have the
following networks defined in your config file:

lxc.network.0.type=veth
lxc.network.0.link=lxcbr0
lxc.network.0.name=eth0
lxc.network.0.flags=up

lxc.network.3.type=veth
lxc.network.3.link=lxcbr0
lxc.network.3.name=eth1
lxc.network.3.flags=up
lxc.network.3.hwaddr = 00:16:3e:5d:7d:65

lxc.network.1.type=veth
lxc.network.1.link=lxcbr0
lxc.network.1.name=eth0
lxc.network.1.flags=up

lxc_get_netdev_by_idx() will take care that the internal network list appears
in the order:

0
1
3

The ordering of the keys themselves can also be random, meaning you could do:

lxc.network.3.type=veth
lxc.network.0.link=lxcbr0
lxc.network.0.name=eth0
lxc.network.3.hwaddr = 00:16:3e:5d:7d:65
lxc.network.0.flags=up
lxc.network.3.flags=up
lxc.network.0.type=veth
lxc.network.3.link=lxcbr0
lxc.network.3.name=eth1

and lxc_get_netdev_by_idx() would still figure out the correct ordering since
it keeps track of the index.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 56637458cae04d109b07da7d31aef23eb7ff646f
      https://github.com/lxc/lxc/commit/56637458cae04d109b07da7d31aef23eb7ff646f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  network: perform network validation at creation time

Some of the checks were previously performed when parsing the network config.
But since we allow for a little more flexibility now it doesn't work anymore.
Instead, let's validate the network at creation time.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bbc079cf87ed5c1f33e09119c40e972d779a845c
      https://github.com/lxc/lxc/commit/bbc079cf87ed5c1f33e09119c40e972d779a845c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: use new network configuration parser

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1ed6ba91b5f44f8cf14bb19e38a08598ccd846ac
      https://github.com/lxc/lxc/commit/1ed6ba91b5f44f8cf14bb19e38a08598ccd846ac
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: add lxc_log_configured_netdevs()

This logs the configured networks on the trace level to support debugging.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2647140368c523f59881feba090143ccbbc1442c
      https://github.com/lxc/lxc/commit/2647140368c523f59881feba090143ccbbc1442c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  network: add arg to config clear method

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 40db5d2f960351baa63f8cc8db84281b314a867a
      https://github.com/lxc/lxc/commit/40db5d2f960351baa63f8cc8db84281b314a867a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: abstract network handling

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ff6da29581a1dafb6581db1786e38e0d6b4c36c1
      https://github.com/lxc/lxc/commit/ff6da29581a1dafb6581db1786e38e0d6b4c36c1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: implement network clearing

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 519df1c1ac3a4fdd2fec94c91ec8c5c9cc6cd923
      https://github.com/lxc/lxc/commit/519df1c1ac3a4fdd2fec94c91ec8c5c9cc6cd923
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: clear whole networks

When users specify

lxc.network.<n>

we remove the whole network from the networks list.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cccd2219a47cd67d24fa683c16fa23d7f4fc45cc
      https://github.com/lxc/lxc/commit/cccd2219a47cd67d24fa683c16fa23d7f4fc45cc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  network: give getters a void pointer arg

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6bed0fb6008794fbee553dbbe54b9074beb1c755
      https://github.com/lxc/lxc/commit/6bed0fb6008794fbee553dbbe54b9074beb1c755
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: allow to unset by passing empty value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9d4bf22d501693dd4e73359f09c35f83a4c401c3
      https://github.com/lxc/lxc/commit/9d4bf22d501693dd4e73359f09c35f83a4c401c3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: implement network getters

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e5d2fd7c2a97e3ae38085e8ad90ec8deb92a1a0b
      https://github.com/lxc/lxc/commit/e5d2fd7c2a97e3ae38085e8ad90ec8deb92a1a0b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: final cleanup

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b45e32f9722b383b10ab42a08fb0b7f9fb6b88b1
      https://github.com/lxc/lxc/commit/b45e32f9722b383b10ab42a08fb0b7f9fb6b88b1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: remove obsolete logic

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ecbb37901e5f9e0911feade29fc21c08865b4374
      https://github.com/lxc/lxc/commit/ecbb37901e5f9e0911feade29fc21c08865b4374
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  network: print deprecaton warning for networks

Specifying networks without an index is deprecated.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0070b1c418211b9b81b72b1b0087d785ea1e6752
      https://github.com/lxc/lxc/commit/0070b1c418211b9b81b72b1b0087d785ea1e6752
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: switch to single find + allocation fun

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8c58265505fd432242a81b74c6616dddc7f30e61
      https://github.com/lxc/lxc/commit/8c58265505fd432242a81b74c6616dddc7f30e61
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  network: add test-suite for configuration items

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c302b476322ee7aadef41e0847e34220e5336ea0
      https://github.com/lxc/lxc/commit/c302b476322ee7aadef41e0847e34220e5336ea0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/tests/get_item.c

  Log Message:
  -----------
  network: preserve backwards compatibility

The new network parser will support specifying multiple networks in the old
format where each new non-indexed "lxc.network.type" line starts a new network
configuration. This way we don't break users. For now, we just print a
deprecation warning. We will KILL this in LXC 3.0.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9b0df30f9d5d232595a8dff8d15c35da42f13a7c
      https://github.com/lxc/lxc/commit/9b0df30f9d5d232595a8dff8d15c35da42f13a7c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  network: improve network logging

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e337179a0e6443cd39b8f90e2ca655ff4694c8be
      https://github.com/lxc/lxc/commit/e337179a0e6443cd39b8f90e2ca655ff4694c8be
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/start.c

  Log Message:
  -----------
  network: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d1826cf12dbfb75e16179c1a3e5ed33eccf94c9a
      https://github.com/lxc/lxc/commit/d1826cf12dbfb75e16179c1a3e5ed33eccf94c9a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  network: refuse to create unsupported net types

Containers setup by unprivileged users are only able to create veth network
types.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ce49441853e191d537ea275763241f2cdf603ea6
      https://github.com/lxc/lxc/commit/ce49441853e191d537ea275763241f2cdf603ea6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: adapt warning

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d21c360988528ad7cb63230481c0daa4e893fe2a
      https://github.com/lxc/lxc/commit/d21c360988528ad7cb63230481c0daa4e893fe2a
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-06-18 (Sun, 18 Jun 2017)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/tests/get_item.c
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  Merge pull request #1626 from brauner/2017-06-13/new_networks_parser

new network config parser


Compare: https://github.com/lxc/lxc/compare/192f5e7b251f...d21c36098852


More information about the lxc-devel mailing list