[lxc-devel] [lxc/master] lvm: fix check

[brauner on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 408 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20170728/36ae3f76/attachment.bin>
-------------- next part --------------
From 505dd98779ee48db6fbd25565ab41eefbf25b780 Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at ubuntu.com>
Date: Fri, 28 Jul 2017 15:33:50 +0200
Subject: [PATCH] lvm: fix check

Signed-off-by: Thomas Hipp <thipp at suse.de>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
---
 src/lxc/bdev/lxclvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lxc/bdev/lxclvm.c b/src/lxc/bdev/lxclvm.c
index 7b1cbd5d8..9c90627b3 100644
--- a/src/lxc/bdev/lxclvm.c
+++ b/src/lxc/bdev/lxclvm.c
@@ -314,7 +314,7 @@ int lvm_clonepaths(struct bdev *orig, struct bdev *new, const char *oldname,
 
 		len = strlen("/dev/") + strlen(vg) + strlen(cname) + 4 + 2;
 		new->src = malloc(len);
-		if (new->src)
+		if (!new->src)
 			return -1;
 
 		ret = snprintf(new->src, len, "lvm:/dev/%s/%s", vg, cname);