[lxc-devel] [lxc/master] lvm: check whether lxc.bdev.lvm.vg is empty

[brauner on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 364 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20170727/ea17e61e/attachment.bin>
-------------- next part --------------
From 9e71b3cbe7563373bda86f020ee589dd6f4b0a8b Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at ubuntu.com>
Date: Fri, 28 Jul 2017 00:54:52 +0200
Subject: [PATCH] lvm: check whether lxc.bdev.lvm.vg is empty

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
---
 src/lxc/bdev/lxclvm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/lxc/bdev/lxclvm.c b/src/lxc/bdev/lxclvm.c
index fdbd98707..7b1cbd5d8 100644
--- a/src/lxc/bdev/lxclvm.c
+++ b/src/lxc/bdev/lxclvm.c
@@ -307,6 +307,11 @@ int lvm_clonepaths(struct bdev *orig, struct bdev *new, const char *oldname,
 			return -1;
 		}
 		vg = lxc_global_config_value("lxc.bdev.lvm.vg");
+		if (!vg) {
+			ERROR("The \"lxc.bdev.lvm.vg\" key is not set");
+			return -1;
+		}
+
 		len = strlen("/dev/") + strlen(vg) + strlen(cname) + 4 + 2;
 		new->src = malloc(len);
 		if (new->src)