[lxc-devel] [lxc/master] Fix issue with the clonehostname hook not working for overlayfs snapshot clones

mkeeler on Github lxc-bot at linuxcontainers.org
Thu Feb 23 14:57:49 UTC 2017


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 617 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20170223/564038b5/attachment.bin>
-------------- next part --------------
From 874abba03d867fa3d43d60fb48a16756fb3879cf Mon Sep 17 00:00:00 2001
From: Matt Keeler <mkeeler at users.noreply.github.com>
Date: Wed, 22 Feb 2017 15:57:59 -0500
Subject: [PATCH] Use LXC_ROOTFS_MOUNT in clonehostname hook

Previously this hook did not work when cloning containers using an overlayfs snapshot as the LXC_ROOTFS_PATH didn't point to the actual filesystem that the container would see. LXC_ROOTFS_MOUNT should be used instead and in fact lxc.container.conf man page says that you usually would want to use the _MOUNT variant.
---
 hooks/clonehostname | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hooks/clonehostname b/hooks/clonehostname
index ed2765c..8eec7a6 100755
--- a/hooks/clonehostname
+++ b/hooks/clonehostname
@@ -19,9 +19,9 @@
 
 # Note that /etc/hostname is updated by lxc itself
 for file in \
-    $LXC_ROOTFS_PATH/etc/sysconfig/network \
-    $LXC_ROOTFS_PATH/etc/sysconfig/network-scripts/ifcfg-* \
-    $LXC_ROOTFS_PATH/etc/hosts ;
+    $LXC_ROOTFS_MOUNT/etc/sysconfig/network \
+    $LXC_ROOTFS_MOUNT/etc/sysconfig/network-scripts/ifcfg-* \
+    $LXC_ROOTFS_MOUNT/etc/hosts ;
 do
     if [ -f $file ]; then
         sed -i "s|$LXC_SRC_NAME|$LXC_NAME|" $file


More information about the lxc-devel mailing list