[lxc-devel] [lxc/lxc] a529bc: mainloop: add mainloop macros

GitHub noreply at github.com
Sat Dec 30 23:27:50 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a529bc25cd7d4f80510f01b200d182be4e4815e3
      https://github.com/lxc/lxc/commit/a529bc25cd7d4f80510f01b200d182be4e4815e3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-26 (Tue, 26 Dec 2017)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/console.h
    M src/lxc/mainloop.c
    M src/lxc/mainloop.h
    M src/lxc/start.h

  Log Message:
  -----------
  mainloop: add mainloop macros

This makes it clearer why handlers return what value.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3c319edbb0b139f16ce213041f438c76fa7061fa
      https://github.com/lxc/lxc/commit/3c319edbb0b139f16ce213041f438c76fa7061fa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-26 (Tue, 26 Dec 2017)

  Changed paths:
    M src/lxc/mainloop.c
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  mainloop: capture output of short-lived init procs

The handler for the signal fd will detect when the init process of a container
has exited and cause the mainloop to close. However, this can happen before the
console handlers - or any other events for that matter - are handled. So in the
case of init exiting we still need to allow for all buffered input to the
console to be handled before exiting. This allows us to capture output from
short-lived init processes.

This is conceptually equivalent to my implementation of ExecReaderToChannel()
https://github.com/lxc/lxd/blob/master/shared/util_linux.go#L527

Closes #1694.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1cc8bd4b61988dcd73dac35243a6ed1591cc1299
      https://github.com/lxc/lxc/commit/1cc8bd4b61988dcd73dac35243a6ed1591cc1299
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-30 (Sat, 30 Dec 2017)

  Changed paths:
    M src/lxc/mainloop.c
    M src/lxc/start.c

  Log Message:
  -----------
  start: properly cleanup mainloop

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a63fade55b1e091bc1933bff181a64c38a28e302
      https://github.com/lxc/lxc/commit/a63fade55b1e091bc1933bff181a64c38a28e302
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-30 (Sat, 30 Dec 2017)

  Changed paths:
    M src/lxc/console.c

  Log Message:
  -----------
  console: do not allow non-pty devices on open()

We don't allow non-pty devices anyway so don't let open() create unneeded
files.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 12c2798ed1143e45f7a42e56a57502ee5a6c0b68
      https://github.com/lxc/lxc/commit/12c2798ed1143e45f7a42e56a57502ee5a6c0b68
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-30 (Sat, 30 Dec 2017)

  Changed paths:
    M src/lxc/mainloop.c

  Log Message:
  -----------
  mainloop: use epoll_create1(EPOLL_CLOEXEC)

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2b33c8bf1269bdbd27193b5f2648fa2c926c3536
      https://github.com/lxc/lxc/commit/2b33c8bf1269bdbd27193b5f2648fa2c926c3536
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-12-30 (Sat, 30 Dec 2017)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/console.h
    M src/lxc/mainloop.c
    M src/lxc/mainloop.h
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  Merge pull request #2062 from brauner/2017-12-25/capture_output_of_short_lived_init_process

mainloop: capture output of short-lived init procs


Compare: https://github.com/lxc/lxc/compare/22840b791db8...2b33c8bf1269


More information about the lxc-devel mailing list