[lxc-devel] [lxc/lxc] 912314: start: fix death signal

GitHub noreply at github.com
Fri Dec 22 22:10:15 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 912314fc9b63e8cffaf3d5160f9171fc6a0805d4
      https://github.com/lxc/lxc/commit/912314fc9b63e8cffaf3d5160f9171fc6a0805d4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: fix death signal

On set{g,u}id() the kernel does:

 	/* dumpability changes */
	if (!uid_eq(old->euid, new->euid) ||
	    !gid_eq(old->egid, new->egid) ||
	    !uid_eq(old->fsuid, new->fsuid) ||
	    !gid_eq(old->fsgid, new->fsgid) ||
	    !cred_cap_issubset(old, new)) {
		if (task->mm)
			set_dumpable(task->mm, suid_dumpable);
		task->pdeath_signal = 0;
		smp_wmb();
	}

which means we need to re-enable the deat signal after the set{g,u}id().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 18225d1985247a8df08d25d07b0797525847d502
      https://github.com/lxc/lxc/commit/18225d1985247a8df08d25d07b0797525847d502
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: handle setting death signal smarter

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c326c1967fbdfc372cd3b7c7828d4a89f0eddc2e
      https://github.com/lxc/lxc/commit/c326c1967fbdfc372cd3b7c7828d4a89f0eddc2e
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  Merge pull request #2058 from brauner/2017-12-22/bugfixes

start: fix death signal


Compare: https://github.com/lxc/lxc/compare/715584350efc...c326c1967fbd


More information about the lxc-devel mailing list