[lxc-devel] [lxc/lxc] b01b36: tests: expand lxc_raw_clone() tests

GitHub noreply at github.com
Thu Dec 21 22:30:12 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b01b36e9ad01048a34de6d2b807a1e7041e657fa
      https://github.com/lxc/lxc/commit/b01b36e9ad01048a34de6d2b807a1e7041e657fa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/tests/lxc_raw_clone.c

  Log Message:
  -----------
  tests: expand lxc_raw_clone() tests

- test CLONE_VFORK
- test CLONE_FILES

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bb196a1aa09560c46b7cda62d53bed9d3781c958
      https://github.com/lxc/lxc/commit/bb196a1aa09560c46b7cda62d53bed9d3781c958
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/namespace.h

  Log Message:
  -----------
  namespace: add lxc_raw_getpid()

Because of older glibc's pid cache (up to 2.25) whenever clone() is called the
child must must retrieve it's own pid via lxc_raw_getpid().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0059379ff44bd52cf17d72300e60432686f2fba0
      https://github.com/lxc/lxc/commit/0059379ff44bd52cf17d72300e60432686f2fba0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/af_unix.c
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgmanager.c
    M src/lxc/console.c
    M src/lxc/lsm/apparmor.c
    M src/lxc/lxc_init.c
    M src/lxc/lxc_monitord.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/lxccontainer.c
    M src/lxc/network.c
    M src/lxc/start.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  tree-wide: s/getpid()/lxc_raw_getpid()/g

This is to avoid bad surprises caused by older glibc's pid cache (up to 2.25)
when using clone().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 718dbb8c2ac9ec30834d74cb660d60342f172a21
      https://github.com/lxc/lxc/commit/718dbb8c2ac9ec30834d74cb660d60342f172a21
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/namespace.h

  Log Message:
  -----------
  namespace: comment lxc_{raw_}clone()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0c2a98bdc8db5094f78f5e8e65c84dccc5243623
      https://github.com/lxc/lxc/commit/0c2a98bdc8db5094f78f5e8e65c84dccc5243623
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/namespace.c
    M src/lxc/namespace.h

  Log Message:
  -----------
  namespace: add lxc_raw_clone_cb()

This is a copy-on-write (no stack passed) variant of lxc_clone().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ac2ba69621f0529b163d3a86772ace9d6601c21a
      https://github.com/lxc/lxc/commit/ac2ba69621f0529b163d3a86772ace9d6601c21a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: use lxc_raw_clone_cb() where possible

This way we can rely on the kernel's copy-on-write support similar to fork().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c3184275ecd981cdaa6d53cb2e7f5ca1811f13a2
      https://github.com/lxc/lxc/commit/c3184275ecd981cdaa6d53cb2e7f5ca1811f13a2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: log closing cmd socket and STOPPED state

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 150901398d4b455956e6ad10ae49313f1e58a825
      https://github.com/lxc/lxc/commit/150901398d4b455956e6ad10ae49313f1e58a825
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-12-21 (Thu, 21 Dec 2017)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/af_unix.c
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgmanager.c
    M src/lxc/console.c
    M src/lxc/lsm/apparmor.c
    M src/lxc/lxc_init.c
    M src/lxc/lxc_monitord.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/lxccontainer.c
    M src/lxc/namespace.c
    M src/lxc/namespace.h
    M src/lxc/network.c
    M src/lxc/start.c
    M src/lxc/utils.c
    M src/lxc/utils.h
    M src/tests/lxc_raw_clone.c

  Log Message:
  -----------
  Merge pull request #2042 from brauner/2017-12-15/bugfixes

start: tweaks + bugfixes


Compare: https://github.com/lxc/lxc/compare/da5f5e3fbbb2...150901398d4b


More information about the lxc-devel mailing list