[lxc-devel] [lxc/lxc] 7754c3: lxc_init: set the control terminal in the child se...
GitHub
noreply at github.com
Sun Dec 17 15:58:05 UTC 2017
Branch: refs/heads/stable-2.0
Home: https://github.com/lxc/lxc
Commit: 7754c37383d7c05d106a6072dc37588c3ad1c2ee
https://github.com/lxc/lxc/commit/7754c37383d7c05d106a6072dc37588c3ad1c2ee
Author: Jonathan Calmels <jcalmels at nvidia.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_init.c
Log Message:
-----------
lxc_init: set the control terminal in the child session
Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>
Commit: c55bcc7cc95c1e1ad87e0bb9d8367de0c7526b4c
https://github.com/lxc/lxc/commit/c55bcc7cc95c1e1ad87e0bb9d8367de0c7526b4c
Author: Po-Hsu Lin <po-hsu.lin at canonical.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/tests/lxc-test-unpriv
Log Message:
-----------
lxc-test-unpriv: check user existence before removing it
Check the test user (lxcunpriv) before calling deluser command,
otherwise it will print unnecessary error message:
/usr/sbin/deluser: The user 'lxcunpriv' does not exist.
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
Commit: cc331c29dc45f953b859d4e0eda1d1d97004717c
https://github.com/lxc/lxc/commit/cc331c29dc45f953b859d4e0eda1d1d97004717c
Author: David Negreira <david.negreira at emesa.nl>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M lxc.spec.in
Log Message:
-----------
Fixed typo on lxc.spec.in
Signed-off-by: David Negreira David at otherreality.net
Commit: 427be16d94708cb28787de6afd2d8b1d5d98845a
https://github.com/lxc/lxc/commit/427be16d94708cb28787de6afd2d8b1d5d98845a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/utils.h
Log Message:
-----------
conf: move CAP_SYS_* definitions to utils.h
Closes #1946.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0036e5f13dbaf177b3df04178c89b3922e6c9c8a
https://github.com/lxc/lxc/commit/0036e5f13dbaf177b3df04178c89b3922e6c9c8a
Author: Yifeng Tan <tanyifeng1 at huawei.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start.c: always switch uid and gid
Signed-off-by: Yifeng Tan <tanyifeng1 at huawei.com>
Reviewed-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b82a757837aa84b7a38d5a00101d8c7ebbf62261
https://github.com/lxc/lxc/commit/b82a757837aa84b7a38d5a00101d8c7ebbf62261
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
A config/ax_pthread.m4
M configure.ac
Log Message:
-----------
Use AX_PTHREAD config script to detect pthread api
Closes: #84
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: 370f320c2593a8b76942b65035c7fb606740e7f0
https://github.com/lxc/lxc/commit/370f320c2593a8b76942b65035c7fb606740e7f0
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/tools/lxc_unshare.c
M src/lxc/utils.h
Log Message:
-----------
utils.h: Avoid duplicated sethostname implementation
Move duplicated implementatin of sethostname from conf.c and
lxc_unshare.c to utils.h
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: 7fb4cab0b833d0fcf0571e70f6a7b646e5ff2d26
https://github.com/lxc/lxc/commit/7fb4cab0b833d0fcf0571e70f6a7b646e5ff2d26
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_cgroup.c
Log Message:
-----------
tools/lxc_cgroup: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: d0197e3719cdbfe665b38bfe1913fb3dfb752694
https://github.com/lxc/lxc/commit/d0197e3719cdbfe665b38bfe1913fb3dfb752694
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_autostart.c
Log Message:
-----------
tools/lxc_autostart: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 5aa39f25c77e20873a47b212ab372ba7d4b847a0
https://github.com/lxc/lxc/commit/5aa39f25c77e20873a47b212ab372ba7d4b847a0
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_clone.c
Log Message:
-----------
tools/lxc_clone: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 97a465c1e75fc6261829cd63ecf92346e167d748
https://github.com/lxc/lxc/commit/97a465c1e75fc6261829cd63ecf92346e167d748
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_console.c
Log Message:
-----------
tools/lxc_console: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 95792a3bda65dd9720145df2721444b2c5deaf47
https://github.com/lxc/lxc/commit/95792a3bda65dd9720145df2721444b2c5deaf47
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_create.c
Log Message:
-----------
tools/lxc_create: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 0d34bf7ab0e3c3910417a3e19709b50dd704b472
https://github.com/lxc/lxc/commit/0d34bf7ab0e3c3910417a3e19709b50dd704b472
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_destroy.c
Log Message:
-----------
tools/lxc_destroy: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: b3200ba852fe2816503acd2a78ccb0b9c9efd7b3
https://github.com/lxc/lxc/commit/b3200ba852fe2816503acd2a78ccb0b9c9efd7b3
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_device.c
Log Message:
-----------
tools/lxc_device: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 8ab75ebeec09ff72339ee6bf85c92b04fa320c6a
https://github.com/lxc/lxc/commit/8ab75ebeec09ff72339ee6bf85c92b04fa320c6a
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools/lxc_execute: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 18322934768382fbedd62c250e7d74d15c9535b5
https://github.com/lxc/lxc/commit/18322934768382fbedd62c250e7d74d15c9535b5
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_freeze.c
Log Message:
-----------
tools/lxc_freeze: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: b1ba7b0fe6e5e9854153b1fc9a7b28a926095775
https://github.com/lxc/lxc/commit/b1ba7b0fe6e5e9854153b1fc9a7b28a926095775
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_info.c
Log Message:
-----------
tools/lxc_info: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 84c29b842621c6042e7ce4c8529ef0b57af313fc
https://github.com/lxc/lxc/commit/84c29b842621c6042e7ce4c8529ef0b57af313fc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: detect veth name
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 0e5eb43a1dcd72e338263dc59bfba228a8167406
https://github.com/lxc/lxc/commit/0e5eb43a1dcd72e338263dc59bfba228a8167406
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.c
Log Message:
-----------
lxccontainer: various container creation fixes
This is beneficial for LXD as well.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 6dc83f4e21e4fd225887baae6221e3e0a1273d84
https://github.com/lxc/lxc/commit/6dc83f4e21e4fd225887baae6221e3e0a1273d84
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.h
Log Message:
-----------
storage: remove unused declaration
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 2a82ac7c54b649365a93796d77ba699e35ce66ac
https://github.com/lxc/lxc/commit/2a82ac7c54b649365a93796d77ba699e35ce66ac
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_ls.c
Log Message:
-----------
tools/lxc_ls: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 62aebd99d1754824a3e6cbb64c12be4153453735
https://github.com/lxc/lxc/commit/62aebd99d1754824a3e6cbb64c12be4153453735
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_copy.c
Log Message:
-----------
tools/lxc_copy: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 3dba1ad7f214f8ffadcdca0243e299c8cd3f63ff
https://github.com/lxc/lxc/commit/3dba1ad7f214f8ffadcdca0243e299c8cd3f63ff
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_monitor.c
Log Message:
-----------
tools/lxc_monitor: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: a9da03a7e6cd1b26db71bfbe51570c21a13e13d6
https://github.com/lxc/lxc/commit/a9da03a7e6cd1b26db71bfbe51570c21a13e13d6
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_snapshot.c
Log Message:
-----------
tools/lxc_snapshot: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: e96df99ba748a89ff9447ffef0e3b1a70818f9d0
https://github.com/lxc/lxc/commit/e96df99ba748a89ff9447ffef0e3b1a70818f9d0
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_start.c
Log Message:
-----------
tools/lxc_start: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 0571062f12f0a8cd90c098d30e3a0a54bb18d1a1
https://github.com/lxc/lxc/commit/0571062f12f0a8cd90c098d30e3a0a54bb18d1a1
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_stop.c
Log Message:
-----------
tools/lxc_stop: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 534a6aaf9b75b6effb585757877d233bef43ee57
https://github.com/lxc/lxc/commit/534a6aaf9b75b6effb585757877d233bef43ee57
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_top.c
Log Message:
-----------
tools/lxc_top: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 50ea49c4891fae30e62d6738f492afc1742a4587
https://github.com/lxc/lxc/commit/50ea49c4891fae30e62d6738f492afc1742a4587
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_unfreeze.c
Log Message:
-----------
tools/lxc_unfreeze: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: b55e5e315369a67a46259aaffc51db45a28a696d
https://github.com/lxc/lxc/commit/b55e5e315369a67a46259aaffc51db45a28a696d
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_unshare.c
Log Message:
-----------
tools/lxc_unshare: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: fb697f2f19705b294ff57ce84a3d8975229b1d38
https://github.com/lxc/lxc/commit/fb697f2f19705b294ff57ce84a3d8975229b1d38
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_usernsexec.c
Log Message:
-----------
tools/lxc_usernsexec: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 405f0aec0abebbd80b942cc472c58a071b3c59d1
https://github.com/lxc/lxc/commit/405f0aec0abebbd80b942cc472c58a071b3c59d1
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_wait.c
Log Message:
-----------
tools/lxc_wait: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: c0979ab73e8feddd81a17dd938d86ee74e5169f7
https://github.com/lxc/lxc/commit/c0979ab73e8feddd81a17dd938d86ee74e5169f7
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: fix memory leak
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: 3fb37977eb8dffa15d7b7ac0c88719a271bb3369
https://github.com/lxc/lxc/commit/3fb37977eb8dffa15d7b7ac0c88719a271bb3369
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/utils.h
Log Message:
-----------
utils: declare sethostname() static inline
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0dd8fb29b9e171b81a5b83018835c0dc6542ce27
https://github.com/lxc/lxc/commit/0dd8fb29b9e171b81a5b83018835c0dc6542ce27
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/tools/lxc_unshare.c
Log Message:
-----------
lxc_unshare: Add uid_mapping when creating userns
Change conf.c to export function write_id_mapping, which will now be
called inside main function of lxc_unshare.c.
This is required because setuid syscalls only permits a new userns to
set a new uid if the uid of parameter is mapped inside the ns using
uid_map file[1]. So, just after the clone invocation, map the uid passed as
parameter into the newly created user namespace, and put the current uid
as the ID-outside-ns. After the mapping is done, setuid call succeeds.
Closes: #494
[1] https://elixir.free-electrons.com/linux/latest/source/kernel/user_namespace.c#L286
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: aad14f731319e9eaa73582c094d29d2bc98eebc5
https://github.com/lxc/lxc/commit/aad14f731319e9eaa73582c094d29d2bc98eebc5
Author: i.Dark_Templar <darktemplar at dark-templar-archives.net>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M config/templates/gentoo.moresecure.conf.in
Log Message:
-----------
Update gentoo.moresecure.conf.
Closes https://github.com/lxc/lxc/issues/1928
Signed-off-by: i.Dark_Templar <darktemplar at dark-templar-archives.net>
Commit: 71c0b35bf0efeda25b0a3752772609ef3c854c6e
https://github.com/lxc/lxc/commit/71c0b35bf0efeda25b0a3752772609ef3c854c6e
Author: CC-Hsu <a12321aabb at gmail.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M templates/lxc-slackware.in
Log Message:
-----------
Add new dependency to Slackware template
I followed the [changelog of Slackware-current]<http://www.slackware.com/changelog/>,
and found that Slackware-current split hostname utility from util-linux package in Nov 17 2017.
So I add the new package to the template.
Signed-off-by: Chia-Chun Hsu <a12321aabb at gmail.com>
Commit: 0f71d53c2b2b3a1a823b782d69309555cb2fd3e1
https://github.com/lxc/lxc/commit/0f71d53c2b2b3a1a823b782d69309555cb2fd3e1
Author: Abbas Ally <abbasally5 at yahoo.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M config/bash/lxc.in
Log Message:
-----------
Add bash completion to list backing store types for lxc-create -B
- Backing Store types are hard-coded (Not sure how to get programmatically)
- Closes #1236
Signed-off-by: Abbas Ally <abbasally5 at yahoo.com>
Commit: ba041b30a5fca7de4e5bd3a019a5eb7ecf470013
https://github.com/lxc/lxc/commit/ba041b30a5fca7de4e5bd3a019a5eb7ecf470013
Author: Pierre LALET <pierre.lalet at cea.fr>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc-checkconfig.in
Log Message:
-----------
Fix SETCOLOR_FAILURE evaluation
Signed-off-by: Pierre LALET <pierre.lalet at cea.fr>
Commit: e577ba6b5d16640ba0376e09c2c1376f7713cea9
https://github.com/lxc/lxc/commit/e577ba6b5d16640ba0376e09c2c1376f7713cea9
Author: Pierre LALET <pierre.lalet at cea.fr>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc-checkconfig.in
Log Message:
-----------
Insert missing "echo" after "is_enabled"
Signed-off-by: Pierre LALET <pierre.lalet at cea.fr>
Commit: a46188c674b7580c20f42ac79ccbd3fb704b3c3c
https://github.com/lxc/lxc/commit/a46188c674b7580c20f42ac79ccbd3fb704b3c3c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/utils.c
Log Message:
-----------
conf: prevent null pointer dereference
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 36074755951d7ea5608e6e7a0326d9dbadd2a83e
https://github.com/lxc/lxc/commit/36074755951d7ea5608e6e7a0326d9dbadd2a83e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: initialize status
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 239f3f78b8969afec6c3dc917b52752fb7e5c8ed
https://github.com/lxc/lxc/commit/239f3f78b8969afec6c3dc917b52752fb7e5c8ed
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: remove dead assignment
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fbced262d9d4baa355d9bdfbe7c7293ac74352f3
https://github.com/lxc/lxc/commit/fbced262d9d4baa355d9bdfbe7c7293ac74352f3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: silence static analysis
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4feff04ae3e3b885a334a737b62521a4fe8db113
https://github.com/lxc/lxc/commit/4feff04ae3e3b885a334a737b62521a4fe8db113
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/attach.c
M src/lxc/utils.c
Log Message:
-----------
attach: do not fail on non-existing namespaces
Closes #1993.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 32ee5a515bf3e7b72a422e187fb5291a74e6daed
https://github.com/lxc/lxc/commit/32ee5a515bf3e7b72a422e187fb5291a74e6daed
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
test: reenable Coverity integration
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ec4f7bc7228883623932430aeed46018a501473c
https://github.com/lxc/lxc/commit/ec4f7bc7228883623932430aeed46018a501473c
Author: Serge Hallyn <shallyn at cisco.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/execute.c
Log Message:
-----------
lxc_execute: properly figure out number of needed arguments
The lxc_log args have noghing to do with lxc.rootfs.path, and
we need room for a NULL at end of arguments.
How this bug was hidden for so long I don't know - I can only
trigger it on certain systems under certain conditions, but it's
definately wrong as is.
Signed-off-by: Serge Hallyn <shallyn at cisco.com>
Commit: 8bedc7ee864304571aec1c6a42e7aae28436358c
https://github.com/lxc/lxc/commit/8bedc7ee864304571aec1c6a42e7aae28436358c
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
R src/lxc/arguments.c
R src/lxc/arguments.h
A src/lxc/tools/arguments.c
A src/lxc/tools/arguments.h
Log Message:
-----------
arguments: move to tools/ subdirectory
The arguments.{c,h} file should not be a part of liblxc itself. It should only
be used for the lxc tools.
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 91e46cb162eccc3d7dcfa391d75a3cca34189014
https://github.com/lxc/lxc/commit/91e46cb162eccc3d7dcfa391d75a3cca34189014
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: set loglevel correctly
We want the loglevel that the user specified when starting the container
because it overrides the default one set in the config.
Closes #2003.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aa4401ae7ed5360b4e5d58b172772f945eb0d23e
https://github.com/lxc/lxc/commit/aa4401ae7ed5360b4e5d58b172772f945eb0d23e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: don't traverse whole list
When we remove a state client fd there's not reason to walk the whole list. We
can simply break once we found and removed the fd.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ce3a1c7b2747ead9b52421fa7032f4c964189797
https://github.com/lxc/lxc/commit/ce3a1c7b2747ead9b52421fa7032f4c964189797
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: don't lock atomic operations
We're dealing with an integer (lxc_state_t which is an enum). Any POSIX
implementation makes those operations atomic so there's not need in locking
this.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 805573c4c1f1b60cb368d5f0c47b78bbaefc038d
https://github.com/lxc/lxc/commit/805573c4c1f1b60cb368d5f0c47b78bbaefc038d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
Log Message:
-----------
commands: don't lock the whole command
There are multiple reasons why this is not required:
- every command is transactional
- we only care about the list being modified not the memory allocation and
other costly operations
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f984925d864e166563d2661790651ca49f0b554c
https://github.com/lxc/lxc/commit/f984925d864e166563d2661790651ca49f0b554c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: don't lock setting the state
- setting the handler->state value is atomic on any POSIX implementation since
we're dealing with an integer (enum/lxc_state_t)
- while the state clients are served it is not possible for lxc_set_state() to
transition to the next state anyway so there's no danger in moving to the
next state with clients missing it
- we only care about the list being modified
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fc11025a0ca88b1a1bb8fe7fb3928630a9302e4c
https://github.com/lxc/lxc/commit/fc11025a0ca88b1a1bb8fe7fb3928630a9302e4c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: allow waiting for all states
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 069e60e4d8c914ccb5461ef0e84bbf8563ee52fd
https://github.com/lxc/lxc/commit/069e60e4d8c914ccb5461ef0e84bbf8563ee52fd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/tests/Makefile.am
A src/tests/state_server.c
Log Message:
-----------
test: add state server tests
This checks whether multiple concurrent waiters all get notified by the state
server.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7ccbce50ac6b6e6c96057b86235c3ebb435c4bca
https://github.com/lxc/lxc/commit/7ccbce50ac6b6e6c96057b86235c3ebb435c4bca
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
M src/lxc/start.c
Log Message:
-----------
commands: tweak locking
Take the lock on the list after we've done all necessary work and check state.
If we are in requested state, do cleanup and return without adding the state
client to the state client list.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fb96e71e9e2038bedfd8acfecb4dfc066700e775
https://github.com/lxc/lxc/commit/fb96e71e9e2038bedfd8acfecb4dfc066700e775
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: restore non-blocking shutdown
If timeout is set to 0 don't block.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eed4b707161ca1edb692f3154f879c51fe2c6223
https://github.com/lxc/lxc/commit/eed4b707161ca1edb692f3154f879c51fe2c6223
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
Log Message:
-----------
commands: tell mainloop to reap client fd on error
This is the proper way to handle errors.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 27727123952aef84c28fb054ed9a7b26c01952c7
https://github.com/lxc/lxc/commit/27727123952aef84c28fb054ed9a7b26c01952c7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: return -ECONNRESET to caller
Callers can then make a decision whether they want to consider the peer closing
the connection an error or not. For example, a c->wait(c, "STOPPED", -1) call
can then consider a ECONNRESET not an error but rather see it - correctly - as
a container exiting before being able to register a state client.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c4989052594dfa2fe44eb84a52e286e45cadab7f
https://github.com/lxc/lxc/commit/c4989052594dfa2fe44eb84a52e286e45cadab7f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/execute.c
Log Message:
-----------
execute: pass logfile to lxc-init
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d1d3676c048e04ffc35a741385884d223bed8004
https://github.com/lxc/lxc/commit/d1d3676c048e04ffc35a741385884d223bed8004
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: handle execute containers correctly
It doesn't make sense to error out when an app container doesn't pass explicit
arguments through c->start{l}(). This is especially true since we implemented
lxc.execute.cmd. However, even before we could have always relied on
lxc.init.cmd and errored out after that.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 650f44682f9493f8d6d90f912e91bb2ada26486b
https://github.com/lxc/lxc/commit/650f44682f9493f8d6d90f912e91bb2ada26486b
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
A src/lxc/lxc_init.c
R src/lxc/tools/lxc_init.c
Log Message:
-----------
lxc_init: move up to src/lxc
lxc_init.c is actually not a tool, thus it doesn't belong to the tools/ subfolder
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Commit: 228aeaca212e9088dc6dc0405bec338aa779637a
https://github.com/lxc/lxc/commit/228aeaca212e9088dc6dc0405bec338aa779637a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/initutils.c
M src/lxc/initutils.h
M src/lxc/lxc_init.c
M src/lxc/lxccontainer.c
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
init: rework dumb init
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0e1a161f3852f5b615cef5fd0803c77203431281
https://github.com/lxc/lxc/commit/0e1a161f3852f5b615cef5fd0803c77203431281
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/lxc_init.c
Log Message:
-----------
lxc_init: add custom argument parser
lxc_init.c should not depend on tools/arguments.{c,h}, thus it needs its own custom argument parser
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Commit: e3557539ad8d58bdd0db4acd7854222ae4118caa
https://github.com/lxc/lxc/commit/e3557539ad8d58bdd0db4acd7854222ae4118caa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/tests/shortlived.c
Log Message:
-----------
tests: expand tests for shortlived init processes
This adds additional test for app containers.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b84bcc2da51d6841653ce28e282a5c0b983609a5
https://github.com/lxc/lxc/commit/b84bcc2da51d6841653ce28e282a5c0b983609a5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425734
free memory on error
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d378615779663099552f85fa631d2afd65715b0f
https://github.com/lxc/lxc/commit/d378615779663099552f85fa631d2afd65715b0f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425735
use correct inequality comparison
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 997abfc8803c2b98f9fd646dbd96a4d7efaf58f6
https://github.com/lxc/lxc/commit/997abfc8803c2b98f9fd646dbd96a4d7efaf58f6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/tests/snapshot.c
Log Message:
-----------
coverity: #1425739
check snprintf() return value
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cbbdb23f093afa8c5344b4e2570ceee954c03bcd
https://github.com/lxc/lxc/commit/cbbdb23f093afa8c5344b4e2570ceee954c03bcd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425929
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5f6c6482ef7bf6463fc6bcea6f916d0985c2b67d
https://github.com/lxc/lxc/commit/5f6c6482ef7bf6463fc6bcea6f916d0985c2b67d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfs.c
Log Message:
-----------
coverity: #1425923
avoid NULL-pointer dereference
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e89919e383f85edc6b5f3a62e4cd884cb3451645
https://github.com/lxc/lxc/commit/e89919e383f85edc6b5f3a62e4cd884cb3451645
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425922
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ec113ac4e070fc2d8e0dcf0f6fcc97792a574b77
https://github.com/lxc/lxc/commit/ec113ac4e070fc2d8e0dcf0f6fcc97792a574b77
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425921
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2bcca48c912d0eb6d06232f67f6e6d30ae92d697
https://github.com/lxc/lxc/commit/2bcca48c912d0eb6d06232f67f6e6d30ae92d697
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425895
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b2bfd4f8f637a0fe6f86a31eb55b4c3f4ba44ce9
https://github.com/lxc/lxc/commit/b2bfd4f8f637a0fe6f86a31eb55b4c3f4ba44ce9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_copy.c
Log Message:
-----------
coverity: #1425890
silence complaint about unchecked return value from library function
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fc87280134061fbfe5bb75dd7662ec82726c49cf
https://github.com/lxc/lxc/commit/fc87280134061fbfe5bb75dd7662ec82726c49cf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
coverity: #1425889
do not call close on bad file descriptor
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b8e44b0912099948dbd69bf7e9df8111903c3bc4
https://github.com/lxc/lxc/commit/b8e44b0912099948dbd69bf7e9df8111903c3bc4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
coverity: #1425888
check return value of getifaddrs()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6dd366633d9ff88cf8dabbd303ba80868c8c70e0
https://github.com/lxc/lxc/commit/6dd366633d9ff88cf8dabbd303ba80868c8c70e0
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgmanager.c
M src/lxc/lxclock.c
Log Message:
-----------
lxc: Distinguish pthread_mutex_unlock error messages
The same message exists in lxclock.c and cgmanager.c, so print the
filename along with the message.
Before this patch:
lxc-destroy -n u1
pthread_mutex_unlock returned:1 Operation not permitted
After this patch:
xc-destroy -n u1
lxclock.c: pthread_mutex_unlock returned:1 Operation not permitted
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: b79cc66a56971ddc4083f863bf2594becc9efac4
https://github.com/lxc/lxc/commit/b79cc66a56971ddc4083f863bf2594becc9efac4
Author: Stéphane Graber <stgraber at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
travis: Fix build failure
Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: 69e930b28b1fd6d338d42d3a8faa1dbb1f6378ae
https://github.com/lxc/lxc/commit/69e930b28b1fd6d338d42d3a8faa1dbb1f6378ae
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/af_unix.c
Log Message:
-----------
coverity: #1425893
used calculated string length when copying into buffer
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 00a1291ec35f0d3ae8c4ac8616913139c928fb4d
https://github.com/lxc/lxc/commit/00a1291ec35f0d3ae8c4ac8616913139c928fb4d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425886
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f716d5727cb64e348554837ddb78f6a35fddcd28
https://github.com/lxc/lxc/commit/f716d5727cb64e348554837ddb78f6a35fddcd28
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
coverity: #1428855
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7055337657517039fc8c806d3aef4c43207a46f6
https://github.com/lxc/lxc/commit/7055337657517039fc8c806d3aef4c43207a46f6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/storage/storage_utils.c
Log Message:
-----------
coverity: #1425884
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dac3dca95f76c3d03440f03b0ac3521aea17f9af
https://github.com/lxc/lxc/commit/dac3dca95f76c3d03440f03b0ac3521aea17f9af
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425883
ensure \0-termination
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c192dc0ce2dee4c71f276ddb5bf9bc3a59fcb8c5
https://github.com/lxc/lxc/commit/c192dc0ce2dee4c71f276ddb5bf9bc3a59fcb8c5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/console.c
M src/lxc/tools/lxc_attach.c
Log Message:
-----------
coverity: #1425879
do not double close file descriptor
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 40028d983aa59bbc0d3a68e0168ce8fd67a594de
https://github.com/lxc/lxc/commit/40028d983aa59bbc0d3a68e0168ce8fd67a594de
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools: block using lxc-execute without config file
Moving away from internal symbols we can't do hacks like we currently do in
lxc-start and call internal functions like lxc_conf_init(). This is unsafe
anyway. Instead, we should simply error out if the user didn't give us a
configuration file to use. lxc-start refuses to start in that case already.
Relates to discussion in https://github.com/lxc/go-lxc/pull/96#discussion_r155075560 .
Closes #2023.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 621d7d28becf2c4aaae0aa42afeb49fdd186c57d
https://github.com/lxc/lxc/commit/621d7d28becf2c4aaae0aa42afeb49fdd186c57d
Author: Jonathan Calmels <jcalmels at nvidia.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: avoid spawning unnecessary subshells
Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>
Commit: 6e41449a95c6b69f0116873bfc9b9acb91aa34b3
https://github.com/lxc/lxc/commit/6e41449a95c6b69f0116873bfc9b9acb91aa34b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425874 + cleanup
- check for memory allocation failure
- free allocated memory
- cleanup function
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2e30119da71ebb9c8fbcde6ecf4f9d5b042c9974
https://github.com/lxc/lxc/commit/2e30119da71ebb9c8fbcde6ecf4f9d5b042c9974
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: only attach netns on netdev detach
Detaching network namespaces as an unprivileged user is currently not possible
and attaching to the user namespace will mean we are not allowed to move the
network device into an ancestor network namespace.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6df0d738a1cc8d13e654347021fb96553423f323
https://github.com/lxc/lxc/commit/6df0d738a1cc8d13e654347021fb96553423f323
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: cleanup {attach,detach}_interface()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a93b81e242518f7198f86bb64ac54b3ba917aea9
https://github.com/lxc/lxc/commit/a93b81e242518f7198f86bb64ac54b3ba917aea9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_top.c
Log Message:
-----------
coverity: #1425870
check snprintf() return value
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 03f04e7d81092752d791f6335d27372053b78e42
https://github.com/lxc/lxc/commit/03f04e7d81092752d791f6335d27372053b78e42
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxc_user_nic.c
Log Message:
-----------
coverity: #1425869
do not unmap prematurely
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d96c566e4742b01b51553a0d029dd45d7340a694
https://github.com/lxc/lxc/commit/d96c566e4742b01b51553a0d029dd45d7340a694
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425867
do not pass NULL pointer to chdir()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4d902e1bb0858f94d8bb258fdc71751ee0c2fcbb
https://github.com/lxc/lxc/commit/4d902e1bb0858f94d8bb258fdc71751ee0c2fcbb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425866
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 68c9b0a1ebbe8ea9d4b57f233031b0134221a2e0
https://github.com/lxc/lxc/commit/68c9b0a1ebbe8ea9d4b57f233031b0134221a2e0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425863
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 63efabee53bebb8150fd4699a0a2c07e7b01388d
https://github.com/lxc/lxc/commit/63efabee53bebb8150fd4699a0a2c07e7b01388d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
M src/lxc/start.c
M src/lxc/start.h
Log Message:
-----------
coverity: #1425862
initialize handler
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 46fa2b43debce7f6fc24cc72e261146277754639
https://github.com/lxc/lxc/commit/46fa2b43debce7f6fc24cc72e261146277754639
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425860
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 656bb5fb8e1f2b9072e4491c50ccb5293b64c12d
https://github.com/lxc/lxc/commit/656bb5fb8e1f2b9072e4491c50ccb5293b64c12d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
coverity: #1425859
check return value of snprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0483c2193ae78a099dc4799fdb22f77e6a5366d0
https://github.com/lxc/lxc/commit/0483c2193ae78a099dc4799fdb22f77e6a5366d0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
coverity: #1425858
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 53ee63017e89f7ff62aff6dfdc9d85bfe4559d22
https://github.com/lxc/lxc/commit/53ee63017e89f7ff62aff6dfdc9d85bfe4559d22
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425857
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e16da8e85d882e6e739eab3668e8e1a2c98ae4fe
https://github.com/lxc/lxc/commit/e16da8e85d882e6e739eab3668e8e1a2c98ae4fe
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: do not unconditionally dup std{in,out,err}
Starting with commit
commit c5b93afba1d79c6861a6f45db2943b6f3cfbdab4
Author: Li Feng <lifeng68 at huawei.com>
Date: Mon Jul 10 17:19:52 2017 +0800
start: dup std{in,out,err} to pty slave
In the case the container has a console with a valid slave pty file descriptor
we duplicate std{in,out,err} to the slave file descriptor so console logging
works correctly. When the container does not have a valid slave pty file
descriptor for its console and is started daemonized we should dup to
/dev/null.
Closes #1646.
Signed-off-by: Li Feng <lifeng68 at huawei.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
we made std{err,in,out} a duplicate of the slave file descriptor of the console
if it existed. This meant we also duplicated all of them when we executed
application containers in the foreground even if some std{err,in,out} file
descriptor did not refer to a {p,t}ty. This blocked use cases such as:
echo foo | lxc-execute -n -- cat
which are very valid and common with application containers but less common
with system containers where we don't have to care about this. So my suggestion
is to unconditionally duplicate std{err,in,out} to the console file descriptor
if we are either running daemonized - this ensures that daemonized application
containers with a single bash shell keep on working - or when we are not
running an application container. In other cases we only duplicate those file
descriptors that actually refer to a {p,t}ty. This logic is similar to what we
do for lxc-attach already.
Refers to #1690.
Closes #2028.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8ba2c9bdfa841e1c7a1bf19d4c5319a4c07ae192
https://github.com/lxc/lxc/commit/8ba2c9bdfa841e1c7a1bf19d4c5319a4c07ae192
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools: exit success when lxc-execute is daemonized
The error_num value doesn't tell us anything since the container hasn't exited.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 662a98320301d2eb7acea39ebadcb7b5fa7d2f21
https://github.com/lxc/lxc/commit/662a98320301d2eb7acea39ebadcb7b5fa7d2f21
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/criu.c
M src/lxc/start.c
M src/lxc/start.h
M src/tests/shortlived.c
Log Message:
-----------
start: fix cgroup namespace preservation
Prior to this patch we raced with a very short-lived init process. Essentially,
the init process could exit before we had time to record the cgroup namespace
causing the container to abort and report ABORTING to the caller when it
actually started just fine. Let's not do this.
(This uses syscall(SYS_getpid) in the the child to retrieve the pid just in case
we're on an older glibc version and we end up in the namespace sharing branch
of the actual lxc_clone() call.)
Additionally this fixes the shortlived tests. They were faulty so far and
should have actually failed because of the cgroup namespace recording race but
the ret variable used to return from the function was not correctly
initialized. This fixes it.
Furthermore, the shortlived tests used the c->error_num variable to determine
success or failure but this is actually not correct when the container is
started daemonized.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 76c3176350d610ecce9bb9f38bd0ffcca1a24720
https://github.com/lxc/lxc/commit/76c3176350d610ecce9bb9f38bd0ffcca1a24720
Author: Tycho Andersen <tycho at tycho.ws>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/lxc_init.c
Log Message:
-----------
init: don't kill(-1) if we aren't in a pid ns
...otherwise we'll kill everyone on the machine. Instead, let's explicitly
try to kill our children. Let's do a best effort against fork bombs by
disabling forking via the pids cgroup if it exists. This is best effort for
a number of reasons:
* the pids cgroup may not be available
* the container may have bind mounted /dev/null over pids.max, so the write
doesn't do anything
Signed-off-by: Tycho Andersen <tycho at tycho.ws>
Commit: 763656317b1a7089d5dda7e4ca9539e206fb7ee1
https://github.com/lxc/lxc/commit/763656317b1a7089d5dda7e4ca9539e206fb7ee1
Author: Tycho Andersen <tycho at tycho.ws>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/tools/arguments.h
M src/lxc/tools/lxc_start.c
Log Message:
-----------
SHARE_NS options should be before OPT_USAGE
Signed-off-by: Tycho Andersen <tycho at tycho.ws>
Commit: 59beaa6f7b729d89f626e277334e8872fc455837
https://github.com/lxc/lxc/commit/59beaa6f7b729d89f626e277334e8872fc455837
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
commands: fix race when open()/close() cmd socket
When we report STOPPED to a caller and then close the command socket it is
technically possible - and I've seen this happen on the test builders - that a
container start() right after a wait() will receive ECONNREFUSED because it
called open() before we close(). So for all new state clients simply close the
command socket. This will inform all state clients that the container is
STOPPED and also prevents a race between a open()/close() on the command socket
causing a new process to get ECONNREFUSED because we haven't yet closed the
command socket.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7ef31511aed8667cdef443f9acf274169838e03
https://github.com/lxc/lxc/commit/a7ef31511aed8667cdef443f9acf274169838e03
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/namespace.c
M src/lxc/namespace.h
M src/tests/Makefile.am
A src/tests/lxc_raw_clone.c
Log Message:
-----------
namespace: add lxc_raw_clone()
This is based on raw_clone in systemd but adapted to our needs. The main reason
is that we need an implementation of fork()/clone() that does guarantee us that
no pthread_atfork() handlers are run. While clone() in glibc currently doesn't
run pthread_atfork() handlers we should be fine but there's no guarantee that
this won't be the case in the future. So let's do the syscall directly - or as
direct as we can. An additional nice feature is that we get fork() behavior,
i.e. lxc_raw_clone() returns 0 in the child and the child pid in the parent.
Our implementation tries to make sure that we cover all cases according to
kernel sources. Note that we are not interested in any arguments that could be
passed after the stack.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 80d90c34ef0d61895fab34c97832d4a9bcf47869
https://github.com/lxc/lxc/commit/80d90c34ef0d61895fab34c97832d4a9bcf47869
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: use lxc_raw_clone() in run_command()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3fe57496e17bd4ae01046e225b88255ccf97c7cf
https://github.com/lxc/lxc/commit/3fe57496e17bd4ae01046e225b88255ccf97c7cf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-17 (Sun, 17 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/lxc_init.c
Log Message:
-----------
lxc_init: fix cgroup parsing
coverity: #1426132
coverity: #1426133
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Compare: https://github.com/lxc/lxc/compare/06485e3772c3...3fe57496e17b
More information about the lxc-devel
mailing list