[lxc-devel] [lxc/lxc] 46047d: lxc_init: set the control terminal in the child se...
GitHub
noreply at github.com
Fri Dec 15 12:56:47 UTC 2017
Branch: refs/heads/stable-2.1
Home: https://github.com/lxc/lxc
Commit: 46047d1f29a8fb2e433676c78f6eedae5b38df30
https://github.com/lxc/lxc/commit/46047d1f29a8fb2e433676c78f6eedae5b38df30
Author: Jonathan Calmels <jcalmels at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_init.c
Log Message:
-----------
lxc_init: set the control terminal in the child session
Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>
Commit: 4437dbe7b72e326330331d0547a6a18e8607dbb6
https://github.com/lxc/lxc/commit/4437dbe7b72e326330331d0547a6a18e8607dbb6
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: fix overlapping strncpy
In the case of "lxc.net.0.type", the pointers passed to strncpy were
only 2 elements apart, resulting in undefined behavior.
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: a4556ff1283f21fe6cdb83955d516477d6a54661
https://github.com/lxc/lxc/commit/a4556ff1283f21fe6cdb83955d516477d6a54661
Author: Po-Hsu Lin <po-hsu.lin at canonical.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/tests/lxc-test-unpriv
Log Message:
-----------
lxc-test-unpriv: check user existence before removing it
Check the test user (lxcunpriv) before calling deluser command,
otherwise it will print unnecessary error message:
/usr/sbin/deluser: The user 'lxcunpriv' does not exist.
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
Commit: 5e2dfb71df9c483b1a2a4ed6c65d0aedbb2878cb
https://github.com/lxc/lxc/commit/5e2dfb71df9c483b1a2a4ed6c65d0aedbb2878cb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: improve legacy update message
Closes #1938.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f5bb843ed2643e67a5d348bf5a3389e4412443ef
https://github.com/lxc/lxc/commit/f5bb843ed2643e67a5d348bf5a3389e4412443ef
Author: David Negreira <david.negreira at emesa.nl>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M lxc.spec.in
Log Message:
-----------
Fixed typo on lxc.spec.in
Signed-off-by: David Negreira David at otherreality.net
Commit: ca83bebe0cf7db188da4b9373d6423405abe40b3
https://github.com/lxc/lxc/commit/ca83bebe0cf7db188da4b9373d6423405abe40b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/utils.h
Log Message:
-----------
conf: move CAP_SYS_* definitions to utils.h
Closes #1946.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b77578a488eb735b3f33017d675b8ab03cb8c40f
https://github.com/lxc/lxc/commit/b77578a488eb735b3f33017d675b8ab03cb8c40f
Author: Yifeng Tan <tanyifeng1 at huawei.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start.c: always switch uid and gid
Signed-off-by: Yifeng Tan <tanyifeng1 at huawei.com>
Reviewed-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a1fb5ea824862a38b80805db392bec366fb4f46c
https://github.com/lxc/lxc/commit/a1fb5ea824862a38b80805db392bec366fb4f46c
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
A config/ax_pthread.m4
M configure.ac
Log Message:
-----------
Use AX_PTHREAD config script to detect pthread api
Closes: #84
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: b0481764d4c9774ef135ad4b3cb27f165b1c1dbf
https://github.com/lxc/lxc/commit/b0481764d4c9774ef135ad4b3cb27f165b1c1dbf
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/tools/lxc_unshare.c
M src/lxc/utils.h
Log Message:
-----------
utils.h: Avoid duplicated sethostname implementation
Move duplicated implementatin of sethostname from conf.c and
lxc_unshare.c to utils.h
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: a9af9073cd12f0dab92a0c97b7839f2cd3a33255
https://github.com/lxc/lxc/commit/a9af9073cd12f0dab92a0c97b7839f2cd3a33255
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_cgroup.c
Log Message:
-----------
tools/lxc_cgroup: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: ad55e9ea488f93f65957f46d5dc79d061724c327
https://github.com/lxc/lxc/commit/ad55e9ea488f93f65957f46d5dc79d061724c327
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_autostart.c
Log Message:
-----------
tools/lxc_autostart: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: f5212c906407fe9bd86f4c9f873462ba94dd6ec2
https://github.com/lxc/lxc/commit/f5212c906407fe9bd86f4c9f873462ba94dd6ec2
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_clone.c
Log Message:
-----------
tools/lxc_clone: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 5d823d1a526ed6ad609a7163f39bbe84369270b8
https://github.com/lxc/lxc/commit/5d823d1a526ed6ad609a7163f39bbe84369270b8
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_console.c
Log Message:
-----------
tools/lxc_console: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 394e598a0fbcec89c1c67f0018ad574fdee854c6
https://github.com/lxc/lxc/commit/394e598a0fbcec89c1c67f0018ad574fdee854c6
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_create.c
Log Message:
-----------
tools/lxc_create: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 1dd72025061b8a12011caa8a76a6130b3563cb7e
https://github.com/lxc/lxc/commit/1dd72025061b8a12011caa8a76a6130b3563cb7e
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_destroy.c
Log Message:
-----------
tools/lxc_destroy: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: d9c126f35081a5105f0260202548d81fc5c66682
https://github.com/lxc/lxc/commit/d9c126f35081a5105f0260202548d81fc5c66682
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_device.c
Log Message:
-----------
tools/lxc_device: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: e174e6dc5c564b0fc7309f92ff08f4a47487ac73
https://github.com/lxc/lxc/commit/e174e6dc5c564b0fc7309f92ff08f4a47487ac73
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools/lxc_execute: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: b69bea43314b3bce47d620a17fb26ac6d4f3295e
https://github.com/lxc/lxc/commit/b69bea43314b3bce47d620a17fb26ac6d4f3295e
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_freeze.c
Log Message:
-----------
tools/lxc_freeze: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: f20963a1265ae09801ca8dafeb53dbb28f0a04a2
https://github.com/lxc/lxc/commit/f20963a1265ae09801ca8dafeb53dbb28f0a04a2
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_info.c
Log Message:
-----------
tools/lxc_info: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 367df444e18a068096eb03f3ee632eedafd65ba0
https://github.com/lxc/lxc/commit/367df444e18a068096eb03f3ee632eedafd65ba0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: detect veth name
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 41f9a60fab9a2e38130040d4fabb54b3774b33e9
https://github.com/lxc/lxc/commit/41f9a60fab9a2e38130040d4fabb54b3774b33e9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: parse storage type
Split lxc.rootfs.path = <storage type>:<container path> into <storage-type> and
<container path> to set the storage type and rootfs path value correctly.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 577ec5e5f8361478bf5b1540567fad38a8ac367c
https://github.com/lxc/lxc/commit/577ec5e5f8361478bf5b1540567fad38a8ac367c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/storage.c
Log Message:
-----------
storage: pass down storage type
The configuration file parser now already detects the storage type so spare the
work and pass it down to the storage drivers.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 332dc2fe0488ca7f9049f1218ea331e22602ee50
https://github.com/lxc/lxc/commit/332dc2fe0488ca7f9049f1218ea331e22602ee50
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/overlay.c
M src/lxc/storage/storage.c
Log Message:
-----------
overlay: adapt to new config rootfs parser
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: a022e86a61be08b3ba6ebc7ad097c6eab84021b1
https://github.com/lxc/lxc/commit/a022e86a61be08b3ba6ebc7ad097c6eab84021b1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/loop.c
Log Message:
-----------
loop: adapt to new config rootfs parser
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 146094d6b63b47a50a2cb3c2f85a0f9957a23cc9
https://github.com/lxc/lxc/commit/146094d6b63b47a50a2cb3c2f85a0f9957a23cc9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.c
M src/lxc/storage/storage.h
Log Message:
-----------
storage: make storage_dir() smart
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 996d16c30ba8a113c6f3b1d5f3b56c4e75fa3654
https://github.com/lxc/lxc/commit/996d16c30ba8a113c6f3b1d5f3b56c4e75fa3654
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.c
M src/lxc/storage/storage.h
Log Message:
-----------
storage: make storage_init() smart and simplify
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: b18a1c924aafbc573cf6d6513299cb75d76d41db
https://github.com/lxc/lxc/commit/b18a1c924aafbc573cf6d6513299cb75d76d41db
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.c
Log Message:
-----------
lxccontainer: various container creation fixes
This is beneficial for LXD as well.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 552e2dd189538b8c254d79a780607071f5c0e636
https://github.com/lxc/lxc/commit/552e2dd189538b8c254d79a780607071f5c0e636
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/storage.c
M src/lxc/storage/storage.h
Log Message:
-----------
storage: make storage_copy() cleaner
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 33c84116793d10183386648518ef38860d07a8a8
https://github.com/lxc/lxc/commit/33c84116793d10183386648518ef38860d07a8a8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
M src/lxc/storage/storage.h
Log Message:
-----------
storage: remove unused declaration
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: ebe5c8c54f645ef590e2efc333795dd8ac01e241
https://github.com/lxc/lxc/commit/ebe5c8c54f645ef590e2efc333795dd8ac01e241
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/lxccontainer.c
M src/lxc/storage/btrfs.c
M src/lxc/storage/dir.c
M src/lxc/storage/loop.c
M src/lxc/storage/lvm.c
M src/lxc/storage/nbd.c
M src/lxc/storage/overlay.c
M src/lxc/storage/overlay.h
M src/lxc/storage/rbd.c
M src/lxc/storage/rsync.c
M src/lxc/storage/storage.c
M src/lxc/storage/storage.h
M src/lxc/storage/storage_utils.c
M src/lxc/storage/storage_utils.h
M src/lxc/storage/zfs.c
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
storage: constify where possible
This was made necessary by changes to the overlay driver.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 1ec1b962659435dd1b78c4e1700c5dc4dcc18b0e
https://github.com/lxc/lxc/commit/1ec1b962659435dd1b78c4e1700c5dc4dcc18b0e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/btrfs.c
Log Message:
-----------
btrfs: fix btrfs_snapshot()
Closes #1956.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>
Commit: 43172d1cd22e4eb8ec7dab74bcef19e17d94983d
https://github.com/lxc/lxc/commit/43172d1cd22e4eb8ec7dab74bcef19e17d94983d
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_ls.c
Log Message:
-----------
tools/lxc_ls: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 8ec03fc6ca199227a13f84982deae556fb51b715
https://github.com/lxc/lxc/commit/8ec03fc6ca199227a13f84982deae556fb51b715
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_copy.c
Log Message:
-----------
tools/lxc_copy: remove internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 0c7fd1c5387a181122afa640732a5f00aafe86ef
https://github.com/lxc/lxc/commit/0c7fd1c5387a181122afa640732a5f00aafe86ef
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_monitor.c
Log Message:
-----------
tools/lxc_monitor: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 59858f43ee1928a45d9028ae8699a9d116c1742d
https://github.com/lxc/lxc/commit/59858f43ee1928a45d9028ae8699a9d116c1742d
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_snapshot.c
Log Message:
-----------
tools/lxc_snapshot: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 271aeb5626f4796d9cf0c531b1be346bf2a01cff
https://github.com/lxc/lxc/commit/271aeb5626f4796d9cf0c531b1be346bf2a01cff
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_start.c
Log Message:
-----------
tools/lxc_start: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cbcc46948ec7ff2a9b3d512d45b5f815b7a87574
https://github.com/lxc/lxc/commit/cbcc46948ec7ff2a9b3d512d45b5f815b7a87574
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_stop.c
Log Message:
-----------
tools/lxc_stop: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: c56e92430ea8ba460a012f89120b3aa662fd451f
https://github.com/lxc/lxc/commit/c56e92430ea8ba460a012f89120b3aa662fd451f
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_top.c
Log Message:
-----------
tools/lxc_top: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: ef55121390521b76e73e0376adb6481c96ae310a
https://github.com/lxc/lxc/commit/ef55121390521b76e73e0376adb6481c96ae310a
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_unfreeze.c
Log Message:
-----------
tools/lxc_unfreeze: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 39636ab96efe32d89edc75caaba503452284b2c2
https://github.com/lxc/lxc/commit/39636ab96efe32d89edc75caaba503452284b2c2
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_unshare.c
Log Message:
-----------
tools/lxc_unshare: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: c110f1a51c2cbc32f769877b66f69b7c9cb87e81
https://github.com/lxc/lxc/commit/c110f1a51c2cbc32f769877b66f69b7c9cb87e81
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_usernsexec.c
Log Message:
-----------
tools/lxc_usernsexec: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: e59b36b15b809af40397bca9665ffb6a3d227ac0
https://github.com/lxc/lxc/commit/e59b36b15b809af40397bca9665ffb6a3d227ac0
Author: AustinReichert <austinskyreichert at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_wait.c
Log Message:
-----------
tools/lxc_wait: removed internal logging
Signed-off-by: AustinReichert <austinskyreichert at utexas.edu>
Commit: 192ab19d34e8035a0b5295cad17e5782e0649eb4
https://github.com/lxc/lxc/commit/192ab19d34e8035a0b5295cad17e5782e0649eb4
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: fix memory leak
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: cd70a8ed1a19a56af99c29243ba063fa9347c292
https://github.com/lxc/lxc/commit/cd70a8ed1a19a56af99c29243ba063fa9347c292
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/tests/parse_config_file.c
Log Message:
-----------
tests: add a function for negative netdev tests
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: 46efc0880c27a18465b986fd74d34115da69ad32
https://github.com/lxc/lxc/commit/46efc0880c27a18465b986fd74d34115da69ad32
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: fix infinite loop with multiple lxc.log.syslog keys
This caused the linked list of appenders to loop on itself, creating
an infinite logging loop in `__lxc_log_append`.
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: 0a7f6089fc494d6a811e83b7ed9d8a5cf1a59cda
https://github.com/lxc/lxc/commit/0a7f6089fc494d6a811e83b7ed9d8a5cf1a59cda
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
M src/lxc/confile_legacy.c
M src/tests/parse_config_file.c
Log Message:
-----------
confile: error out if a network configuration key has no subkey
This prevent an infinite recursion in the case of "lxc.net.0. = a"
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: 0a210f864b002ffce9042f7ef934a56f4e2839f3
https://github.com/lxc/lxc/commit/0a210f864b002ffce9042f7ef934a56f4e2839f3
Author: Felix Abecassis <fabecassis at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_utils.c
M src/tests/lxc-test-utils.c
Log Message:
-----------
confile_utils: simplify lxc_config_net_hwaddr
In addition to the memory corruption fixed in ee3e84df78424d26fc6c90862fbe0fa92a686b0d,
this function was also performing invalid memory accesses for the following inputs:
- `lxc.net`
- `lxc.net.`
- `lxc.net.0.`
- `lxc.network`
- `lxc.network.0.`
Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>
Commit: eb59c469a4b5d0b2748b89514743350d03f70c19
https://github.com/lxc/lxc/commit/eb59c469a4b5d0b2748b89514743350d03f70c19
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/utils.h
Log Message:
-----------
utils: declare sethostname() static inline
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 28f7670c1919c236bafc2893706afe13fbf23008
https://github.com/lxc/lxc/commit/28f7670c1919c236bafc2893706afe13fbf23008
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/tools/lxc_unshare.c
Log Message:
-----------
lxc_unshare: Add uid_mapping when creating userns
Change conf.c to export function write_id_mapping, which will now be
called inside main function of lxc_unshare.c.
This is required because setuid syscalls only permits a new userns to
set a new uid if the uid of parameter is mapped inside the ns using
uid_map file[1]. So, just after the clone invocation, map the uid passed as
parameter into the newly created user namespace, and put the current uid
as the ID-outside-ns. After the mapping is done, setuid call succeeds.
Closes: #494
[1] https://elixir.free-electrons.com/linux/latest/source/kernel/user_namespace.c#L286
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: 19f90d5316918366f27f8b063e17f9cd889455c6
https://github.com/lxc/lxc/commit/19f90d5316918366f27f8b063e17f9cd889455c6
Author: i.Dark_Templar <darktemplar at dark-templar-archives.net>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M config/templates/gentoo.moresecure.conf.in
Log Message:
-----------
Update gentoo.moresecure.conf.
Closes https://github.com/lxc/lxc/issues/1928
Signed-off-by: i.Dark_Templar <darktemplar at dark-templar-archives.net>
Commit: 314697b8bb0ee6d0d472e2740f9625da1d95ca23
https://github.com/lxc/lxc/commit/314697b8bb0ee6d0d472e2740f9625da1d95ca23
Author: CC-Hsu <a12321aabb at gmail.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M templates/lxc-slackware.in
Log Message:
-----------
Add new dependency to Slackware template
I followed the [changelog of Slackware-current]<http://www.slackware.com/changelog/>,
and found that Slackware-current split hostname utility from util-linux package in Nov 17 2017.
So I add the new package to the template.
Signed-off-by: Chia-Chun Hsu <a12321aabb at gmail.com>
Commit: 68251bd62acb3d2b34d2cd700131e8ddd7ae98e1
https://github.com/lxc/lxc/commit/68251bd62acb3d2b34d2cd700131e8ddd7ae98e1
Author: Abbas Ally <abbasally5 at yahoo.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M config/bash/lxc.in
Log Message:
-----------
Add bash completion to list backing store types for lxc-create -B
- Backing Store types are hard-coded (Not sure how to get programmatically)
- Closes #1236
Signed-off-by: Abbas Ally <abbasally5 at yahoo.com>
Commit: 348f192d24b90b2ee3473d212bcde6433d9fc3fa
https://github.com/lxc/lxc/commit/348f192d24b90b2ee3473d212bcde6433d9fc3fa
Author: Pierre LALET <pierre.lalet at cea.fr>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc-checkconfig.in
Log Message:
-----------
Fix SETCOLOR_FAILURE evaluation
Signed-off-by: Pierre LALET <pierre.lalet at cea.fr>
Commit: cbe312678b931903fe783e39b2a6ad900f3bc9d8
https://github.com/lxc/lxc/commit/cbe312678b931903fe783e39b2a6ad900f3bc9d8
Author: Pierre LALET <pierre.lalet at cea.fr>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc-checkconfig.in
Log Message:
-----------
Insert missing "echo" after "is_enabled"
Signed-off-by: Pierre LALET <pierre.lalet at cea.fr>
Commit: 053ec2681855075b575c2252e9d1729fed495a9b
https://github.com/lxc/lxc/commit/053ec2681855075b575c2252e9d1729fed495a9b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
M src/lxc/utils.c
Log Message:
-----------
conf: prevent null pointer dereference
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 57d668dfad31eec966499c3e58ab68fdd43d35dd
https://github.com/lxc/lxc/commit/57d668dfad31eec966499c3e58ab68fdd43d35dd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_legacy.c
Log Message:
-----------
confile_legacy: prevent null pointer deref
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 449af9a0b2294813548fcd389e5c0fa822560d9b
https://github.com/lxc/lxc/commit/449af9a0b2294813548fcd389e5c0fa822560d9b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: initialize status
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fb1f9a9d398488c0e873395d25a410c82482ffd1
https://github.com/lxc/lxc/commit/fb1f9a9d398488c0e873395d25a410c82482ffd1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: remove dead assignment
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5760a5a03937fcc6dc19ce0ce61e3a2b5f129b45
https://github.com/lxc/lxc/commit/5760a5a03937fcc6dc19ce0ce61e3a2b5f129b45
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: silence static analysis
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 77d82ac6082cd5ad3cae1ea8f28b40680040de2d
https://github.com/lxc/lxc/commit/77d82ac6082cd5ad3cae1ea8f28b40680040de2d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/attach.c
M src/lxc/utils.c
Log Message:
-----------
attach: do not fail on non-existing namespaces
Closes #1993.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 88c42f50a6bba1f0e223be05f2074f053ce8b418
https://github.com/lxc/lxc/commit/88c42f50a6bba1f0e223be05f2074f053ce8b418
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
test: reenable Coverity integration
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bab5c748c85e4eeeadd20a4ac93e9c0b2a642456
https://github.com/lxc/lxc/commit/bab5c748c85e4eeeadd20a4ac93e9c0b2a642456
Author: Serge Hallyn <shallyn at cisco.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/execute.c
Log Message:
-----------
lxc_execute: properly figure out number of needed arguments
The lxc_log args have noghing to do with lxc.rootfs.path, and
we need room for a NULL at end of arguments.
How this bug was hidden for so long I don't know - I can only
trigger it on certain systems under certain conditions, but it's
definately wrong as is.
Signed-off-by: Serge Hallyn <shallyn at cisco.com>
Commit: 07b6e2e6dc728657d4290523cd39c0b0ee2d6e73
https://github.com/lxc/lxc/commit/07b6e2e6dc728657d4290523cd39c0b0ee2d6e73
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
R src/lxc/arguments.c
R src/lxc/arguments.h
A src/lxc/tools/arguments.c
A src/lxc/tools/arguments.h
Log Message:
-----------
arguments: move to tools/ subdirectory
The arguments.{c,h} file should not be a part of liblxc itself. It should only
be used for the lxc tools.
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b6ebd1f247573764c7e9e222c4cb4c1331c19ffa
https://github.com/lxc/lxc/commit/b6ebd1f247573764c7e9e222c4cb4c1331c19ffa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: set loglevel correctly
We want the loglevel that the user specified when starting the container
because it overrides the default one set in the config.
Closes #2003.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e1ff30a9a8ca20e43fcddbb3e217c472f97d91aa
https://github.com/lxc/lxc/commit/e1ff30a9a8ca20e43fcddbb3e217c472f97d91aa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: don't traverse whole list
When we remove a state client fd there's not reason to walk the whole list. We
can simply break once we found and removed the fd.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0ec9b0cc1b1b11f500665642ca352e2ee112a629
https://github.com/lxc/lxc/commit/0ec9b0cc1b1b11f500665642ca352e2ee112a629
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: don't lock atomic operations
We're dealing with an integer (lxc_state_t which is an enum). Any POSIX
implementation makes those operations atomic so there's not need in locking
this.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9a8e2b6ef0b6730594e643f8f68b167d094454b5
https://github.com/lxc/lxc/commit/9a8e2b6ef0b6730594e643f8f68b167d094454b5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
Log Message:
-----------
commands: don't lock the whole command
There are multiple reasons why this is not required:
- every command is transactional
- we only care about the list being modified not the memory allocation and
other costly operations
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 00088acbbaa268305e76e9871b093558eedeb706
https://github.com/lxc/lxc/commit/00088acbbaa268305e76e9871b093558eedeb706
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: don't lock setting the state
- setting the handler->state value is atomic on any POSIX implementation since
we're dealing with an integer (enum/lxc_state_t)
- while the state clients are served it is not possible for lxc_set_state() to
transition to the next state anyway so there's no danger in moving to the
next state with clients missing it
- we only care about the list being modified
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 859bea7fb3c2ca0d136a935b438f5f721f6281bd
https://github.com/lxc/lxc/commit/859bea7fb3c2ca0d136a935b438f5f721f6281bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: allow waiting for all states
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0d927edb54a7638b52e0f75c25bc2e08092ad2a7
https://github.com/lxc/lxc/commit/0d927edb54a7638b52e0f75c25bc2e08092ad2a7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/tests/Makefile.am
A src/tests/state_server.c
Log Message:
-----------
test: add state server tests
This checks whether multiple concurrent waiters all get notified by the state
server.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 70935a87aaceed9a6574c887bd8a3f4893d37c34
https://github.com/lxc/lxc/commit/70935a87aaceed9a6574c887bd8a3f4893d37c34
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
M src/lxc/start.c
Log Message:
-----------
commands: tweak locking
Take the lock on the list after we've done all necessary work and check state.
If we are in requested state, do cleanup and return without adding the state
client to the state client list.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6e43822b21016806630f37c837957994d291dd12
https://github.com/lxc/lxc/commit/6e43822b21016806630f37c837957994d291dd12
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: restore non-blocking shutdown
If timeout is set to 0 don't block.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 38e48fed943d96bc17b85e2da79f1558e8bffa26
https://github.com/lxc/lxc/commit/38e48fed943d96bc17b85e2da79f1558e8bffa26
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
Log Message:
-----------
commands: tell mainloop to reap client fd on error
This is the proper way to handle errors.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f44c23639bdcb2a7676ca08f505fae9847a01e90
https://github.com/lxc/lxc/commit/f44c23639bdcb2a7676ca08f505fae9847a01e90
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: return -ECONNRESET to caller
Callers can then make a decision whether they want to consider the peer closing
the connection an error or not. For example, a c->wait(c, "STOPPED", -1) call
can then consider a ECONNRESET not an error but rather see it - correctly - as
a container exiting before being able to register a state client.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 68bd7123ff44365b0c94ebadc87e4eaab29e6221
https://github.com/lxc/lxc/commit/68bd7123ff44365b0c94ebadc87e4eaab29e6221
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/execute.c
Log Message:
-----------
execute: pass logfile to lxc-init
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 606d3d4544fc92697766e69edc25de90575b90c7
https://github.com/lxc/lxc/commit/606d3d4544fc92697766e69edc25de90575b90c7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: handle execute containers correctly
It doesn't make sense to error out when an app container doesn't pass explicit
arguments through c->start{l}().
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 09d14a78d5a43c384aecd7fba6f591a9219bc7bb
https://github.com/lxc/lxc/commit/09d14a78d5a43c384aecd7fba6f591a9219bc7bb
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
A src/lxc/lxc_init.c
R src/lxc/tools/lxc_init.c
Log Message:
-----------
lxc_init: move up to src/lxc
lxc_init.c is actually not a tool, thus it doesn't belong to the tools/ subfolder
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Commit: 5fb5c04dab67b41cc4c280eb4f6a700e5571453d
https://github.com/lxc/lxc/commit/5fb5c04dab67b41cc4c280eb4f6a700e5571453d
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/initutils.c
M src/lxc/initutils.h
M src/lxc/lxc_init.c
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
lxc_init: add custom argument parser
lxc_init.c should not depend on tools/arguments.{c,h}, thus it needs its own custom argument parser
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bc2d890e4e1d472fcd860bc269a98adeb0ee2840
https://github.com/lxc/lxc/commit/bc2d890e4e1d472fcd860bc269a98adeb0ee2840
Author: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxc_init.c
Log Message:
-----------
lxc_init: changed minor details
Signed-off-by: RicardoSanchezA <ricardo.sanchez at utexas.edu>
Commit: d125f48cda83f80c6bf01fde7e8feebbcff8b59d
https://github.com/lxc/lxc/commit/d125f48cda83f80c6bf01fde7e8feebbcff8b59d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/tests/shortlived.c
Log Message:
-----------
tests: expand tests for shortlived init processes
This adds additional test for app containers.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 747e15d392f2a632a98ef4ad190839d02288dc62
https://github.com/lxc/lxc/commit/747e15d392f2a632a98ef4ad190839d02288dc62
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425734
free memory on error
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1de4ec1e5f0aa42883429572ba2bb776badee5fb
https://github.com/lxc/lxc/commit/1de4ec1e5f0aa42883429572ba2bb776badee5fb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425735
use correct inequality comparison
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 29d506089a1f39871b8c52c22a199edb3a763381
https://github.com/lxc/lxc/commit/29d506089a1f39871b8c52c22a199edb3a763381
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/rsync.c
Log Message:
-----------
coverity: #1425737
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 70a2599da8bce5f2a9f1c0c6cfef752a04886a96
https://github.com/lxc/lxc/commit/70a2599da8bce5f2a9f1c0c6cfef752a04886a96
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/tests/snapshot.c
Log Message:
-----------
coverity: #1425739
check snprintf() return value
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2d288f7a94322309df29907615a2e196c13ec761
https://github.com/lxc/lxc/commit/2d288f7a94322309df29907615a2e196c13ec761
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_legacy.c
Log Message:
-----------
coverity: #1425740
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 11ac4731fe936cfbd9e3d59b16932399a3841ff2
https://github.com/lxc/lxc/commit/11ac4731fe936cfbd9e3d59b16932399a3841ff2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/overlay.c
Log Message:
-----------
coverity: #1425742
fix error condition check
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d2f82ed6e62cdd55923266477eeaf40d96ca6a49
https://github.com/lxc/lxc/commit/d2f82ed6e62cdd55923266477eeaf40d96ca6a49
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
coverity: #1425743
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 441d7e4b7ed9a19cf26b3c142d89474abe451b1a
https://github.com/lxc/lxc/commit/441d7e4b7ed9a19cf26b3c142d89474abe451b1a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425929
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dbbb8cf1162bf31361ae8f4a9d785fce7d121196
https://github.com/lxc/lxc/commit/dbbb8cf1162bf31361ae8f4a9d785fce7d121196
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_legacy.c
Log Message:
-----------
coverity: #1425924
remove logically dead condition
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3deed1c78ce6c5bbe1f2f617a0241afbc1655ef2
https://github.com/lxc/lxc/commit/3deed1c78ce6c5bbe1f2f617a0241afbc1655ef2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfs.c
Log Message:
-----------
coverity: #1425923
avoid NULL-pointer dereference
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cb66857ddaf761c6d943cb6500f90ec0db8983e4
https://github.com/lxc/lxc/commit/cb66857ddaf761c6d943cb6500f90ec0db8983e4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425922
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8b7482a5efc7ea3af1408eb63aadbf0d02daab4b
https://github.com/lxc/lxc/commit/8b7482a5efc7ea3af1408eb63aadbf0d02daab4b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425921
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bc302cfe4b516d6566dce26343a361837745412c
https://github.com/lxc/lxc/commit/bc302cfe4b516d6566dce26343a361837745412c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425895
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2bba6e49974913a20cf8ef9101807650890a4851
https://github.com/lxc/lxc/commit/2bba6e49974913a20cf8ef9101807650890a4851
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_copy.c
Log Message:
-----------
coverity: #1425890
silence complaint about unchecked return value from library function
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7641e5d73a3434d489f8b7f51554d71ae0a63281
https://github.com/lxc/lxc/commit/7641e5d73a3434d489f8b7f51554d71ae0a63281
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
coverity: #1425889
do not call close on bad file descriptor
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ca4bad795e78ec5a00a94a5ced31e068590b329c
https://github.com/lxc/lxc/commit/ca4bad795e78ec5a00a94a5ced31e068590b329c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
coverity: #1425888
check return value of getifaddrs()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bd18ea05627ed66b3c304233d4cd2fc83d8fa6fd
https://github.com/lxc/lxc/commit/bd18ea05627ed66b3c304233d4cd2fc83d8fa6fd
Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgmanager.c
M src/lxc/lxclock.c
Log Message:
-----------
lxc: Distinguish pthread_mutex_unlock error messages
The same message exists in lxclock.c and cgmanager.c, so print the
filename along with the message.
Before this patch:
lxc-destroy -n u1
pthread_mutex_unlock returned:1 Operation not permitted
After this patch:
xc-destroy -n u1
lxclock.c: pthread_mutex_unlock returned:1 Operation not permitted
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
Commit: 9ae1b710de29f2dd26db84b80e465f639a2aae11
https://github.com/lxc/lxc/commit/9ae1b710de29f2dd26db84b80e465f639a2aae11
Author: Stéphane Graber <stgraber at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
travis: Fix build failure
Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: a636767659e1e6586c696d22f7bc15a724d18e41
https://github.com/lxc/lxc/commit/a636767659e1e6586c696d22f7bc15a724d18e41
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile_legacy.c
Log Message:
-----------
legacy confile: fix legacy network parser
This fixes a bug introduced by:
commit 94f0035bf636ba853451d59c129e26d94850c04d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: Thu Dec 7 15:07:26 2017 +0100
coverity: #1425924
remove logically dead condition
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Coverity's bug analysis is correct but my fix wasn't.
This commit fixes a bunch of other bugs I just spotted as well.
This unblocks #2009.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bda407d0e1e24d8c5b0b04d123c3845f82ef88ec
https://github.com/lxc/lxc/commit/bda407d0e1e24d8c5b0b04d123c3845f82ef88ec
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fix lxc.prlimit clearing
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 64dfa23661e12a0d01501306d8f1d0153ddad86b
https://github.com/lxc/lxc/commit/64dfa23661e12a0d01501306d8f1d0153ddad86b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/overlay.c
Log Message:
-----------
coverity: #1426029
fix use after free
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ca7013f5ecdf766b9b93f051ed66d6ebaa668ea4
https://github.com/lxc/lxc/commit/ca7013f5ecdf766b9b93f051ed66d6ebaa668ea4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/af_unix.c
Log Message:
-----------
coverity: #1425893
used calculated string length when copying into buffer
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 727e7e8da09ebfc8ea8f7ef6c856e0a85a91baa1
https://github.com/lxc/lxc/commit/727e7e8da09ebfc8ea8f7ef6c856e0a85a91baa1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425886
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0add718c32569fbba7c9142b27f988cca540c3d1
https://github.com/lxc/lxc/commit/0add718c32569fbba7c9142b27f988cca540c3d1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
coverity: #1428855
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 95bffc22cbaaa71ba92b2b486cf7708e836b1631
https://github.com/lxc/lxc/commit/95bffc22cbaaa71ba92b2b486cf7708e836b1631
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/storage_utils.c
Log Message:
-----------
coverity: #1425884
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6d33801a5f2789dfa6d1a3ea60dd2bba7f6e62ee
https://github.com/lxc/lxc/commit/6d33801a5f2789dfa6d1a3ea60dd2bba7f6e62ee
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425883
ensure \0-termination
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6fd10c6249ee76d009cabe4a11a25a012dc792d7
https://github.com/lxc/lxc/commit/6fd10c6249ee76d009cabe4a11a25a012dc792d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/console.c
M src/lxc/tools/lxc_attach.c
Log Message:
-----------
coverity: #1425879
do not double close file descriptor
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e0d498f1da8e51e99745bd8fd70fc0c53d7ea3db
https://github.com/lxc/lxc/commit/e0d498f1da8e51e99745bd8fd70fc0c53d7ea3db
Author: Jonathan Calmels <jcalmels at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/overlay.c
Log Message:
-----------
overlay: fix out-of-bounds copy
Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>
Commit: fe937918a5949456b7a93c7114eb879aba12608d
https://github.com/lxc/lxc/commit/fe937918a5949456b7a93c7114eb879aba12608d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools: block using lxc-execute without config file
Moving away from internal symbols we can't do hacks like we currently do in
lxc-start and call internal functions like lxc_conf_init(). This is unsafe
anyway. Instead, we should simply error out if the user didn't give us a
configuration file to use. lxc-start refuses to start in that case already.
Relates to discussion in https://github.com/lxc/go-lxc/pull/96#discussion_r155075560 .
Closes #2023.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 72a98b30ce4a711efbbacd29e6e219fab1e851bd
https://github.com/lxc/lxc/commit/72a98b30ce4a711efbbacd29e6e219fab1e851bd
Author: Jonathan Calmels <jcalmels at nvidia.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: avoid spawning unnecessary subshells
Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>
Commit: a477a3686cf265d68f556ccf053a838a7da83cab
https://github.com/lxc/lxc/commit/a477a3686cf265d68f556ccf053a838a7da83cab
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425874 + cleanup
- check for memory allocation failure
- free allocated memory
- cleanup function
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d9ef2141a9a99a9c5cb2f6915541cfa942f8492d
https://github.com/lxc/lxc/commit/d9ef2141a9a99a9c5cb2f6915541cfa942f8492d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: only attach netns on netdev detach
Detaching network namespaces as an unprivileged user is currently not possible
and attaching to the user namespace will mean we are not allowed to move the
network device into an ancestor network namespace.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 357d2b3b7b5d41c946323057f5122327ef53f08c
https://github.com/lxc/lxc/commit/357d2b3b7b5d41c946323057f5122327ef53f08c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: cleanup {attach,detach}_interface()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 49f6cf17bfc7330bd88b66f597d3af7f460ec81c
https://github.com/lxc/lxc/commit/49f6cf17bfc7330bd88b66f597d3af7f460ec81c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_top.c
Log Message:
-----------
coverity: #1425870
check snprintf() return value
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ae65a0f7f29935b957f0480da1e2263335fb72eb
https://github.com/lxc/lxc/commit/ae65a0f7f29935b957f0480da1e2263335fb72eb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxc_user_nic.c
Log Message:
-----------
coverity: #1425869
do not unmap prematurely
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0b01bd4de860762e7a6e669beda0ea5429c00bb2
https://github.com/lxc/lxc/commit/0b01bd4de860762e7a6e669beda0ea5429c00bb2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425867
do not pass NULL pointer to chdir()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0d219ea18372b368acf645e503b97e3ffb58e782
https://github.com/lxc/lxc/commit/0d219ea18372b368acf645e503b97e3ffb58e782
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
coverity: #1425866
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d9f8e1b799f64a8bd2901e81439eab501afc6b6e
https://github.com/lxc/lxc/commit/d9f8e1b799f64a8bd2901e81439eab501afc6b6e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425863
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c6f6b380853d49b5bd1da4d701f21ecffff5598e
https://github.com/lxc/lxc/commit/c6f6b380853d49b5bd1da4d701f21ecffff5598e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
M src/lxc/start.c
M src/lxc/start.h
Log Message:
-----------
coverity: #1425862
initialize handler
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e398e96cea725945765083db537063e891d183e5
https://github.com/lxc/lxc/commit/e398e96cea725945765083db537063e891d183e5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
coverity: #1425861
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 558996bd53cfe1fe1f4d0f3f2e46759b6f7ec40d
https://github.com/lxc/lxc/commit/558996bd53cfe1fe1f4d0f3f2e46759b6f7ec40d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
coverity: #1425860
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 46e40f8273fc9fecf709abadba6f956576bbae62
https://github.com/lxc/lxc/commit/46e40f8273fc9fecf709abadba6f956576bbae62
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
coverity: #1425859
check return value of snprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a8b7a90511072e46f3e4c2234746bea68558f51f
https://github.com/lxc/lxc/commit/a8b7a90511072e46f3e4c2234746bea68558f51f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
coverity: #1425858
free allocated memory
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7ed560ca5bbb2888a1db5ded4dd5d6cd497bdeaf
https://github.com/lxc/lxc/commit/7ed560ca5bbb2888a1db5ded4dd5d6cd497bdeaf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
coverity: #1425857
remove logically dead code
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aa4e165dc43bab172b941e504434a1c12bb62e7b
https://github.com/lxc/lxc/commit/aa4e165dc43bab172b941e504434a1c12bb62e7b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/overlay.c
Log Message:
-----------
coverity: #1426028
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1c60b12f93004648ec6308f8a28094ceee6668cb
https://github.com/lxc/lxc/commit/1c60b12f93004648ec6308f8a28094ceee6668cb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: do not unconditionally dup std{in,out,err}
Starting with commit
commit c5b93afba1d79c6861a6f45db2943b6f3cfbdab4
Author: Li Feng <lifeng68 at huawei.com>
Date: Mon Jul 10 17:19:52 2017 +0800
start: dup std{in,out,err} to pty slave
In the case the container has a console with a valid slave pty file descriptor
we duplicate std{in,out,err} to the slave file descriptor so console logging
works correctly. When the container does not have a valid slave pty file
descriptor for its console and is started daemonized we should dup to
/dev/null.
Closes #1646.
Signed-off-by: Li Feng <lifeng68 at huawei.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
we made std{err,in,out} a duplicate of the slave file descriptor of the console
if it existed. This meant we also duplicated all of them when we executed
application containers in the foreground even if some std{err,in,out} file
descriptor did not refer to a {p,t}ty. This blocked use cases such as:
echo foo | lxc-execute -n -- cat
which are very valid and common with application containers but less common
with system containers where we don't have to care about this. So my suggestion
is to unconditionally duplicate std{err,in,out} to the console file descriptor
if we are either running daemonized - this ensures that daemonized application
containers with a single bash shell keep on working - or when we are not
running an application container. In other cases we only duplicate those file
descriptors that actually refer to a {p,t}ty. This logic is similar to what we
do for lxc-attach already.
Refers to #1690.
Closes #2028.
Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f73fa4b06a6b9598942fa7a1dcd1d6e14222a15c
https://github.com/lxc/lxc/commit/f73fa4b06a6b9598942fa7a1dcd1d6e14222a15c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/tools/lxc_execute.c
Log Message:
-----------
tools: exit success when lxc-execute is daemonized
The error_num value doesn't tell us anything since the container hasn't exited.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 93b20b93311a8c141334ca07178bb2498428ee3d
https://github.com/lxc/lxc/commit/93b20b93311a8c141334ca07178bb2498428ee3d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/criu.c
M src/lxc/start.c
M src/lxc/start.h
M src/tests/shortlived.c
Log Message:
-----------
start: fix cgroup namespace preservation
Prior to this patch we raced with a very short-lived init process. Essentially,
the init process could exit before we had time to record the cgroup namespace
causing the container to abort and report ABORTING to the caller when it
actually started just fine. Let's not do this.
(This uses syscall(SYS_getpid) in the the child to retrieve the pid just in case
we're on an older glibc version and we end up in the namespace sharing branch
of the actual lxc_clone() call.)
Additionally this fixes the shortlived tests. They were faulty so far and
should have actually failed because of the cgroup namespace recording race but
the ret variable used to return from the function was not correctly
initialized. This fixes it.
Furthermore, the shortlived tests used the c->error_num variable to determine
success or failure but this is actually not correct when the container is
started daemonized.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f14bc2497df7e7cc4603299f5d470e894f76504d
https://github.com/lxc/lxc/commit/f14bc2497df7e7cc4603299f5d470e894f76504d
Author: Serge Hallyn <shallyn at cisco.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/storage/dir.c
Log Message:
-----------
dir_detect: warn on eperm
if user has lxc.rootfs.path = /some/path/foo, but can't access
some piece of that path, then we'll get an unhelpful "failed to
mount" without any indication of the problem.
At least show that there is a permission problem.
Signed-off-by: Serge Hallyn <shallyn at cisco.com>
Commit: 32ee3fc3a369089ed1d0c4b943cdecf8c69c85c7
https://github.com/lxc/lxc/commit/32ee3fc3a369089ed1d0c4b943cdecf8c69c85c7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
commands: fix race when open()/close() cmd socket
When we report STOPPED to a caller and then close the command socket it is
technically possible - and I've seen this happen on the test builders - that a
container start() right after a wait() will receive ECONNREFUSED because it
called open() before we close(). So for all new state clients simply close the
command socket. This will inform all state clients that the container is
STOPPED and also prevents a race between a open()/close() on the command socket
causing a new process to get ECONNREFUSED because we haven't yet closed the
command socket.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ad135e3727a0a63421728a4583a91a38cd169e9f
https://github.com/lxc/lxc/commit/ad135e3727a0a63421728a4583a91a38cd169e9f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/namespace.c
M src/lxc/namespace.h
M src/tests/Makefile.am
A src/tests/lxc_raw_clone.c
Log Message:
-----------
namespace: add lxc_raw_clone()
This is based on raw_clone in systemd but adapted to our needs. The main reason
is that we need an implementation of fork()/clone() that does guarantee us that
no pthread_atfork() handlers are run. While clone() in glibc currently doesn't
run pthread_atfork() handlers we should be fine but there's no guarantee that
this won't be the case in the future. So let's do the syscall directly - or as
direct as we can. An additional nice feature is that we get fork() behavior,
i.e. lxc_raw_clone() returns 0 in the child and the child pid in the parent.
Our implementation tries to make sure that we cover all cases according to
kernel sources. Note that we are not interested in any arguments that could be
passed after the stack.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: df9b5e599bfda19b95694abe54c5043a62081287
https://github.com/lxc/lxc/commit/df9b5e599bfda19b95694abe54c5043a62081287
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: use lxc_raw_clone() in run_command()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Compare: https://github.com/lxc/lxc/compare/e2bce0ecb4bd...df9b5e599bfd
More information about the lxc-devel
mailing list