[lxc-devel] [lxc/lxc] e1e764: coverity: #1425929

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e1e7642342dc296626b3c9f4906c0a60924f8477
      https://github.com/lxc/lxc/commit/e1e7642342dc296626b3c9f4906c0a60924f8477
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425929

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3ee9e4fb38745f29a4f69528429f5f3be63dfd79
      https://github.com/lxc/lxc/commit/3ee9e4fb38745f29a4f69528429f5f3be63dfd79
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  coverity: #1425928

Avoid NULL-pointer dereference. Apparently monitor.{c,h} calls
lxc_check_inherited() with NULL passed for the config. This isn't really a big
issue since monitor.{c,h} is effectively dead for all liblxc versions that have
the state client patch. Also, the patch that introduces the relevant lines into
lxc_check_inherited() is only in master and yet unreleased.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 94f0035bf636ba853451d59c129e26d94850c04d
      https://github.com/lxc/lxc/commit/94f0035bf636ba853451d59c129e26d94850c04d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/confile_legacy.c

  Log Message:
  -----------
  coverity: #1425924

remove logically dead condition

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9d6514f22230e3416f5e4b61359e962c8abdc4d0
      https://github.com/lxc/lxc/commit/9d6514f22230e3416f5e4b61359e962c8abdc4d0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/cgroups/cgfs.c

  Log Message:
  -----------
  coverity: #1425923

avoid NULL-pointer dereference

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8e0c6620515a9938d36590c5e839e9644281ecde
      https://github.com/lxc/lxc/commit/8e0c6620515a9938d36590c5e839e9644281ecde
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1425922

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f4e1fa60b27cea4ec558d0a9b8cffebc99dd8d5d
      https://github.com/lxc/lxc/commit/f4e1fa60b27cea4ec558d0a9b8cffebc99dd8d5d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425921

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dcbc861eda080f2729c7b25aa0b3aeaf78a909c6
      https://github.com/lxc/lxc/commit/dcbc861eda080f2729c7b25aa0b3aeaf78a909c6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1425895

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fd41e9b7bfaba80f55c8e01dced0cd434d99eb36
      https://github.com/lxc/lxc/commit/fd41e9b7bfaba80f55c8e01dced0cd434d99eb36
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/tools/lxc_copy.c

  Log Message:
  -----------
  coverity: #1425890

silence complaint about unchecked return value from library function

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2a7de7ea852ee64d6300d12f3c6595b3fd647902
      https://github.com/lxc/lxc/commit/2a7de7ea852ee64d6300d12f3c6595b3fd647902
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  coverity: #1425889

do not call close on bad file descriptor

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2d7bf7442c1f492f56417bf1d294ca162a2ad2ea
      https://github.com/lxc/lxc/commit/2d7bf7442c1f492f56417bf1d294ca162a2ad2ea
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1425888

check return value of getifaddrs()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f6812e7f2ed7e97ecce3e864dc4d737788883c65
      https://github.com/lxc/lxc/commit/f6812e7f2ed7e97ecce3e864dc4d737788883c65
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-12-07 (Thu, 07 Dec 2017)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/commands.c
    M src/lxc/confile_legacy.c
    M src/lxc/lxccontainer.c
    M src/lxc/network.c
    M src/lxc/start.c
    M src/lxc/tools/lxc_copy.c

  Log Message:
  -----------
  Merge pull request #2011 from brauner/generic/coverity

coverity: bugfixes


Compare: https://github.com/lxc/lxc/compare/fb398f07869a...f6812e7f2ed7