[lxc-devel] [lxc/lxc] 89d097: conf: non-functional changes

GitHub noreply at github.com
Tue Aug 29 19:57:20 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 89d09707b023ced7d3b54b880c312efa9cb6e63c
      https://github.com/lxc/lxc/commit/89d09707b023ced7d3b54b880c312efa9cb6e63c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 01b2d1f1740f6f0b94dbdb1add54cb1ebde85ff2
      https://github.com/lxc/lxc/commit/01b2d1f1740f6f0b94dbdb1add54cb1ebde85ff2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: do not deref null pointer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a17f8b3f4658a1022d83575173cd846158f5d0f9
      https://github.com/lxc/lxc/commit/a17f8b3f4658a1022d83575173cd846158f5d0f9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7d531e9ba482947eaf9be3b19949f24b5e78bb44
      https://github.com/lxc/lxc/commit/7d531e9ba482947eaf9be3b19949f24b5e78bb44
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: add container name to lxc.cgroup.dir value

Say we have

    lxc.uts.name = c1
    lxc.cgroup.dir = lxd

the actual path should be

    lxd/c1

Right now it would just be

    lxd

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 92c590ae1ea40bc094603ab49c20b785cc88bb1d
      https://github.com/lxc/lxc/commit/92c590ae1ea40bc094603ab49c20b785cc88bb1d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/confile.c

  Log Message:
  -----------
  cgfsng: try to delete parent cgroups

Say we have

    lxc.uts.name = c1
    lxc.cgroup.dir = lxd/a/b/c

the path for the container's cgroup would be

    lxd/a/b/c/c1

When the container is shutdown we should not just try to delete "c1" we should
also try to delete "c", "b", "a", and "lxd". This is to ensure that we don't
leave empty cgroups around thereby increasing the chance that we run into
trouble with cgroup limits. The algorithm for this isn't too costly since we
can simply stop walking upwards at the first rmdir() failure.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d04e77c34a445dd9caee2a50a5c948e7af706d55
      https://github.com/lxc/lxc/commit/d04e77c34a445dd9caee2a50a5c948e7af706d55
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8285dcfb504e02520c9b4cac395dd5a45b1b08d5
      https://github.com/lxc/lxc/commit/8285dcfb504e02520c9b4cac395dd5a45b1b08d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: fix memleak

get_new_nicname() calls lxc_mkifname() which allocates memory and returns it to
the caller. The way get_new_nicname() and get_nic_if_avail() were implemented
they hid that fact by returning a boolean. That doesn't make sense. Let's
rather have them return a pointer to the allocated nic name which the caller
needs to free.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 900e5f94afa9c835eecc509d8b09db7898195aa3
      https://github.com/lxc/lxc/commit/900e5f94afa9c835eecc509d8b09db7898195aa3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: add new {create,delete} subcommands

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f703d9904a799e9b4993be835d376879b757a830
      https://github.com/lxc/lxc/commit/f703d9904a799e9b4993be835d376879b757a830
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/tests/lxc-test-usernic.in

  Log Message:
  -----------
  tests: adapt lxc-user-nic tests to new syntax

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 25aead3fdd4e296585e275b69357f642ba594420
      https://github.com/lxc/lxc/commit/25aead3fdd4e296585e275b69357f642ba594420
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  conf: adapt to lxc-user-nic usage

- lxc-user-nic gains the subcommands {create,delete}
- dup2() STDERR_FILENO as well so that we can show helpful messages in our logs
  on failure
- initialize output buffer so that we don't print garbage

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c92dfebd9eb246e1b0e159e41e903f66aeac5274
      https://github.com/lxc/lxc/commit/c92dfebd9eb246e1b0e159e41e903f66aeac5274
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: rework renaming net devices

This should make things a little less convoluted.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0cffb6769da95b9c5980d7e2e01e9a75238461d3
      https://github.com/lxc/lxc/commit/0cffb6769da95b9c5980d7e2e01e9a75238461d3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  network: send ifindex for unpriv networks

We use the ifindex as an indicator that liblxc created the network so let's
record it for the unprivileged case as well.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7a582518b38d6e712f82e0c2bb9b4ef84f29997a
      https://github.com/lxc/lxc/commit/7a582518b38d6e712f82e0c2bb9b4ef84f29997a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-27 (Sun, 27 Aug 2017)

  Changed paths:
    M src/lxc/confile_utils.c

  Log Message:
  -----------
  network: log ifindex

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a055595ca6ebc0d7b64b3b0fcd454a9443a044b9
      https://github.com/lxc/lxc/commit/a055595ca6ebc0d7b64b3b0fcd454a9443a044b9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  network: delete ovs for unprivileged networks

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: af256970563c3e95e6cd6d396f2e27da8bd2756f
      https://github.com/lxc/lxc/commit/af256970563c3e95e6cd6d396f2e27da8bd2756f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8b8e00a24d3eafa57bfd5db3f364c6570f0c8f10
      https://github.com/lxc/lxc/commit/8b8e00a24d3eafa57bfd5db3f364c6570f0c8f10
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: check db before trying to delete

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 890928153e36299f7f1fc7a1147a63ae748acd61
      https://github.com/lxc/lxc/commit/890928153e36299f7f1fc7a1147a63ae748acd61
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: increase lxc-user-nic buffer

This will allow us log more detailed failures.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 811ef482114116b82376b6edad2df801ade0da36
      https://github.com/lxc/lxc/commit/811ef482114116b82376b6edad2df801ade0da36
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile_utils.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/network.c
    M src/lxc/network.h
    M src/lxc/start.c

  Log Message:
  -----------
  network: non-functional changes

This moves all of the network handling code into network.{c,h}. This makes what
is going on much clearer. Also it's easier to find relevant code if it is all
in one place.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2e02bbdb03c2544a40d211a85fe5024e7edcb053
      https://github.com/lxc/lxc/commit/2e02bbdb03c2544a40d211a85fe5024e7edcb053
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/network.c
    M src/lxc/network.h
    M src/lxc/start.c
    M src/tests/lxc-test-usernic.in

  Log Message:
  -----------
  Merge pull request #1761 from brauner/2017-08-10/further_lxc_2.1_preparations

further lxc 2.1 preparations


Compare: https://github.com/lxc/lxc/compare/5965257b6e94...2e02bbdb03c2


More information about the lxc-devel mailing list