[lxc-devel] [lxc/lxc] 125acb: conf: less error prone pointer access

GitHub noreply at github.com
Mon Apr 17 01:47:03 UTC 2017


  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 125acbf7832ec055b5355c07ce202e06696f344b
      https://github.com/lxc/lxc/commit/125acbf7832ec055b5355c07ce202e06696f344b
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: less error prone pointer access

These functions define pointer to their key shifted by a
number and guard access to it later via another variable.
Let's make this more explicit (and additionally have the
pointer be NULL in the case where it is not supposed to be
used).

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: e8f082263de4f5ab3191c144ddb6acbf824646a9
      https://github.com/lxc/lxc/commit/e8f082263de4f5ab3191c144ddb6acbf824646a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/utils.h

  Log Message:
  -----------
  conf: lxc_map_ids() non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: abeded90ddf5619637ad3af901537f50f8a867fb
      https://github.com/lxc/lxc/commit/abeded90ddf5619637ad3af901537f50f8a867fb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/caps.c
    M src/lxc/caps.h
    M src/lxc/start.c

  Log Message:
  -----------
  caps: add lxc_{proc,file}_cap_is_set()

Add two new helpers that allow to determine whether a given proc or file has a
capability in the given set and move lxc_cap_is_set() to static function that
both call internally.

Closes #296.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 25743d0db6ddfd89cddb817b91b6975ffa30ea75
      https://github.com/lxc/lxc/commit/25743d0db6ddfd89cddb817b91b6975ffa30ea75
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  conf: check for {filecaps,setuid} on new{g,u}idmap

The new{g,u}idmap binaries where a source of trouble for users when they lacked
sufficient privileges. This commit adds code to check for sufficient privilege.
It checks whether new{g,u}idmap is root owned and has the setuid bit set and if
it doesn't it checks whether new{g,u}idmap is root owned and has CAP_SETUID in
its CAP_PERMITTED and CAP_EFFECTIVE set.

Closes #296.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 016c592478d7f68b5e59366005a2ed08bc13e8f1
      https://github.com/lxc/lxc/commit/016c592478d7f68b5e59366005a2ed08bc13e8f1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: improve log when mounting rootfs

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 34b87922fbb164c62d47116282758c019ce9a8e7
      https://github.com/lxc/lxc/commit/34b87922fbb164c62d47116282758c019ce9a8e7
  Author: 0x0916 <w at laoqinren.net>
  Date:   2017-04-16 (Sun, 16 Apr 2017)

  Changed paths:
    M src/lxc/tools/lxc_ls.c

  Log Message:
  -----------
  ls: simplify the judgment condition when list active containers

Signed-off-by: 0x0916 <w at laoqinren.net>


Compare: https://github.com/lxc/lxc/compare/0f6e4b4b4a66...34b87922fbb1


More information about the lxc-devel mailing list