[lxc-devel] [lxc/lxc] 5f178b: c/r: fix typo in comment

GitHub noreply at github.com
Sat Sep 17 03:20:11 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f178bc983a7050205b0ba374163646e9e378cf6
      https://github.com/lxc/lxc/commit/5f178bc983a7050205b0ba374163646e9e378cf6
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  c/r: fix typo in comment

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: 36662416441b051bf9d3bb0e1b5d08a61b3a6420
      https://github.com/lxc/lxc/commit/36662416441b051bf9d3bb0e1b5d08a61b3a6420
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgmanager.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroup: add new functions for interacting with hierachies

N.B. that these are only implemented in cgfsng, but,

15:28:28    tych0 | do we still use cgfs anywhere? or the cgm backend?
15:29:19 stgraber | not anywhere we care about

...I think that's okay.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: aeb3682ff631e6afaa9c0b5d8a32654e8ebd2771
      https://github.com/lxc/lxc/commit/aeb3682ff631e6afaa9c0b5d8a32654e8ebd2771
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add lxc_deslashify

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: 0ab5703fcff8aafc3512c8b3cb446780b1c6974c
      https://github.com/lxc/lxc/commit/0ab5703fcff8aafc3512c8b3cb446780b1c6974c
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  c/r: pass --cgroup-roots on checkpoint

CRIU has added support for passing --cgroup-root on dump, which we should
use (see the criu commit 07d259f365f224b32914de26ea0fd59fc6db0001 for
details). Note that we don't have to do any version checking or anything,
because CRIU just ignored --cgroup-root on checkpoint before, so passing it
is safe, and will result in correct behavior when a sufficient version of
CRIU is present.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: 6df334d1588dfcf99a405fb700971ac27cac438c
      https://github.com/lxc/lxc/commit/6df334d1588dfcf99a405fb700971ac27cac438c
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroup: get rid of weird hack in cgfsng_escape

We initialized cgfsng in a strange way inside of its implementation of
escape so we could use it during checkpoint. Instead, the previous patch
does a hacky initialization in criu.c, and we can get rid of the hacks
elsewhere :)

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: a0c91fccd9a1ae9c68a10880d4660d63a3b411e8
      https://github.com/lxc/lxc/commit/a0c91fccd9a1ae9c68a10880d4660d63a3b411e8
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgmanager.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroup: drop cgroup_canonical_path

This is almost never the right thing to use, and we don't use it any more
anyway.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: 09e80d0cc4c7d39c43ec0e6e910346d8e1b6461c
      https://github.com/lxc/lxc/commit/09e80d0cc4c7d39c43ec0e6e910346d8e1b6461c
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  c/r: check that cgroup_num_hierarchies > 0

Otherwise in the error case, we end up subtracting two from the
static_args, which would lead to a segfault :)

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: 651ef4efbbf97d9ca661771ac8d79eb15fa1905d
      https://github.com/lxc/lxc/commit/651ef4efbbf97d9ca661771ac8d79eb15fa1905d
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/lxc/cgroups/cgfs.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgmanager.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/criu.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  Merge pull request #1194 from tych0/cgroup-root-on-dump

Cgroup root on dump


Compare: https://github.com/lxc/lxc/compare/127a74d7aaad...651ef4efbbf9


More information about the lxc-devel mailing list