[lxc-devel] [lxc/lxc] b4c424: log: use thread-safe localtime_r()

GitHub noreply at github.com
Fri Nov 25 02:22:05 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b4c424743aec447437a169837cfe3180a39f2331
      https://github.com/lxc/lxc/commit/b4c424743aec447437a169837cfe3180a39f2331
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2016-11-25 (Fri, 25 Nov 2016)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: use thread-safe localtime_r()

This fixes a race in liblxc logging which can lead to deadlocks. The reproducer
for this issue before this is to simply compile with --enable-tests and then
run:

    lxc-test-concurrent -j 20 -m create,start,stop,destroy -D

which should deadlock.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b5e3950161c6249c906e7c04faade20bde351f58
      https://github.com/lxc/lxc/commit/b5e3950161c6249c906e7c04faade20bde351f58
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-11-24 (Thu, 24 Nov 2016)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  Merge pull request #1318 from brauner/2016-11-25/fix_logging_race

log: use thread-safe localtime_r()


Compare: https://github.com/lxc/lxc/compare/81f466d05f2a...b5e3950161c6


More information about the lxc-devel mailing list