[lxc-devel] [lxc/lxc] 0d7574: tools: replace non-standard namespace identifiers

[GitHub]

  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 0d7574d59aebee39d9e79482e8fcf17535396088
      https://github.com/lxc/lxc/commit/0d7574d59aebee39d9e79482e8fcf17535396088
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: replace non-standard namespace identifiers

The identifiers for namespaces used with lxc-unshare and lxc-attach as given on
the manpage do not align with the standard identifiers. This affects network,
mount, and uts namespaces. The standard identifiers are: "mnt", "uts", and
"net" whereas lxc-unshare and lxc-attach use "MOUNT", "UTSNAME", and "NETWORK".
I'm weary to hack this into namespace.{c.h} by e.g. adding additional members
to the ns_info struct or to special case this in lxc_fill_namespace_flags().
Internally, we should only accept standard identifiers to ensure that we are
always correctly aligned with the kernel. So let's use some cheap memmove()s to
replace them by their standard identifiers in lxc-unshare and lxc-attach.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6d14aa2b8a3d924fde5673073ae1c6bb4917f604
      https://github.com/lxc/lxc/commit/6d14aa2b8a3d924fde5673073ae1c6bb4917f604
  Author: Cam Cope <cam at dropbox.com>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M config/init/common/lxc-net.in
    M lxc.spec.in

  Log Message:
  -----------
  Configure a static MAC address on the LXC bridge

Signed-off-by: Cam Cope <cam at dropbox.com>


  Commit: 6c27d1a68a88a448c3389405e67736b70f3fd3ee
      https://github.com/lxc/lxc/commit/6c27d1a68a88a448c3389405e67736b70f3fd3ee
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  tests: remove overflow tests

They do not behave correctly on some architectures, so let's remove them for
now and come up with better ones later.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/89154b891069...6c27d1a68a88