[lxc-devel] [lxc/lxc] 9420e0: tools: replace non-standard namespace identifiers

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9420e0c2786d7807c259d794544f16370e3213e3
      https://github.com/lxc/lxc/commit/9420e0c2786d7807c259d794544f16370e3213e3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: replace non-standard namespace identifiers

The identifiers for namespaces used with lxc-unshare and lxc-attach as given on
the manpage do not align with the standard identifiers. This affects network,
mount, and uts namespaces. The standard identifiers are: "mnt", "uts", and
"net" whereas lxc-unshare and lxc-attach use "MOUNT", "UTSNAME", and "NETWORK".
I'm weary to hack this into namespace.{c.h} by e.g. adding additional members
to the ns_info struct or to special case this in lxc_fill_namespace_flags().
Internally, we should only accept standard identifiers to ensure that we are
always correctly aligned with the kernel. So let's use some cheap memmove()s to
replace them by their standard identifiers in lxc-unshare and lxc-attach.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dea1cfbd1673b2289073bee6ef6ba28b68b9d964
      https://github.com/lxc/lxc/commit/dea1cfbd1673b2289073bee6ef6ba28b68b9d964
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  Merge pull request #1312 from brauner/2016-11-22/fix_lxc_unshare_parsing

tools: replace non-standard namespace identifiers


Compare: https://github.com/lxc/lxc/compare/70c9390ea641...dea1cfbd1673