[lxc-devel] [lxc/master] log: remove duplicate definitons and bump buffer size

tych0 on Github lxc-bot at linuxcontainers.org
Tue May 10 22:25:12 UTC 2016


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 607 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160510/e48c0cac/attachment.bin>
-------------- next part --------------
From 88593cead8b926710853c72d9590d4b05ca228d7 Mon Sep 17 00:00:00 2001
From: Tycho Andersen <tycho.andersen at canonical.com>
Date: Mon, 9 May 2016 21:37:26 +0000
Subject: [PATCH] log: remove duplicate definitons and bump buffer size

When writing out the CRIU exec command, we're bumping up against the buffer
size limit. Let's increase it so we can avoid:

lxc 20160509213229.921 WARN     lxc_log - log.c:log_append_logfile:111 - truncated next event from 523 to 512 bytes

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
---
 src/lxc/log.c | 2 --
 src/lxc/log.h | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/lxc/log.c b/src/lxc/log.c
index 55fa7f5..11d4bbf 100644
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -40,8 +40,6 @@
 #include "caps.h"
 #include "utils.h"
 
-#define LXC_LOG_PREFIX_SIZE	32
-#define LXC_LOG_BUFFER_SIZE	512
 #define LXC_LOG_DATEFOMAT_SIZE  15
 
 int lxc_log_fd = -1;
diff --git a/src/lxc/log.h b/src/lxc/log.h
index 76bd4df..eb330d0 100644
--- a/src/lxc/log.h
+++ b/src/lxc/log.h
@@ -44,7 +44,7 @@
 #endif
 
 #define LXC_LOG_PREFIX_SIZE	32
-#define LXC_LOG_BUFFER_SIZE	512
+#define LXC_LOG_BUFFER_SIZE	1024
 
 /* This attribute is required to silence clang warnings */
 #if defined(__GNUC__)


More information about the lxc-devel mailing list