[lxc-devel] [PATCH] lxc-busybox: Remove warning for dynamically linked Busybox

[Stéphane Graber]

On Thu, Mar 24, 2016 at 11:54:27AM +0000, Bogdan Purcareata wrote:
> The warning has been present since commit 32b37181ea (with no purpose stated).
> Support for dynamically linked Busybox has been added since commit bf6cc73696.
> Haven't encountered any issues with dynamically linked Busybox in my last
> 2 years' testing.
> 
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata at nxp.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  templates/lxc-busybox.in | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/templates/lxc-busybox.in b/templates/lxc-busybox.in
> index f547f9e..336fa12 100644
> --- a/templates/lxc-busybox.in
> +++ b/templates/lxc-busybox.in
> @@ -304,13 +304,6 @@ configure_busybox()
>          return 1
>      fi
>  
> -    file -L $(which busybox) | grep -q "statically linked"
> -    if [ $? -ne 0 ]; then
> -        echo "warning : busybox is not statically linked."
> -        echo "warning : The template script may not correctly"
> -        echo "warning : setup the container environment."
> -    fi
> -
>      # copy busybox in the rootfs
>      cp $(which busybox) $rootfs/bin
>      if [ $? -ne 0 ]; then
> -- 
> 1.9.1
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160324/fba17fa2/attachment.sig>