[lxc-devel] [lxd/master] lxd-bridge: Make shellcheck happy

stgraber on Github lxc-bot at linuxcontainers.org
Wed Mar 23 17:23:06 UTC 2016


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 354 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160323/0275cd39/attachment.bin>
-------------- next part --------------
From 70f96bc41d0ee852aa699ec524dc70b955ca8222 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Graber?= <stgraber at ubuntu.com>
Date: Wed, 23 Mar 2016 13:22:46 -0400
Subject: [PATCH] lxd-bridge: Make shellcheck happy
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
---
 lxd-bridge/lxd-bridge | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lxd-bridge/lxd-bridge b/lxd-bridge/lxd-bridge
index 86529f6..5343ae8 100755
--- a/lxd-bridge/lxd-bridge
+++ b/lxd-bridge/lxd-bridge
@@ -116,11 +116,11 @@ start() {
     if [ -n "${LXD_IPV6_ADDR}" ] && [ -n "${LXD_IPV6_MASK}" ] && [ -n "${LXD_IPV6_NETWORK}" ]; then
         # IPv6 sysctls don't respect the "all" path...
         for interface in /proc/sys/net/ipv6/conf/*; do
-            echo 2 > ${interface}/accept_ra
+            echo 2 > "${interface}/accept_ra"
         done
 
         for interface in /proc/sys/net/ipv6/conf/*; do
-            echo 1 > ${interface}/forwarding
+            echo 1 > "${interface}/forwarding"
         done
 
         ip -6 addr add dev "${LXD_BRIDGE}" "${LXD_IPV6_ADDR}/${LXD_IPV6_MASK}"
@@ -162,7 +162,7 @@ start() {
     fi
 
     if [ "${LXD_IPV6_PROXY}" = "true" ]; then
-        PATH=${PATH}:$(dirname ${0}) lxd-bridge-proxy --addr="[fe80::1%${LXD_BRIDGE}]:3128" &
+        PATH="${PATH}:$(dirname "${0}")" lxd-bridge-proxy --addr="[fe80::1%${LXD_BRIDGE}]:3128" &
         PID=$!
         echo "${PID}" > "${varrun}/proxy.pid"
     fi


More information about the lxc-devel mailing list