[lxc-devel] [lxc/lxc] 0728eb: autodev: don't always create /dev/console

GitHub noreply at github.com
Thu Mar 17 20:02:48 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0728ebf499ef31214370563bcc685cadcebbaa11
      https://github.com/lxc/lxc/commit/0728ebf499ef31214370563bcc685cadcebbaa11
  Author: Tycho Andersen <tycho.andersen at canonical.com>
  Date:   2016-03-17 (Thu, 17 Mar 2016)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  autodev: don't always create /dev/console

In particular, only create /dev/console when it is set to "none".
Otherwise, we will bind mount a pts device later, so let's just leave it.

Also, when bind mounting the pts device, let's create /dev/console if it
doesn't exist, since it may not already exist due to the above :)

v2: s/ot/to
v3: add O_EXCL so we actually get EEXIST, use the right condition for
    mount_console (we want to compare against console.path, not
    console.name, and console.path can be null)

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>


  Commit: c9013d0379f6a1faca6e3187ca0258f8b1c9bce2
      https://github.com/lxc/lxc/commit/c9013d0379f6a1faca6e3187ca0258f8b1c9bce2
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-03-17 (Thu, 17 Mar 2016)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Merge pull request #900 from tych0/dont-always-create-console

autodev: don't always create /dev/console


Compare: https://github.com/lxc/lxc/compare/16ec15b27b2f...c9013d0379f6


More information about the lxc-devel mailing list