[lxc-devel] [lxc/lxc] 6a9e0f: cgfs: switch to userns when removing cgroup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6a9e0f26fe57c00a852d78751a8a35db3c1396fc
      https://github.com/lxc/lxc/commit/6a9e0f26fe57c00a852d78751a8a35db3c1396fc
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-03-02 (Wed, 02 Mar 2016)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h

  Log Message:
  -----------
  cgfs: switch to userns when removing cgroup

Otherwise unprivileged users may not have the privilege needed to
remove their cgroups.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 4fee80f9d7d5105b4729d3691437536110f3c20b
      https://github.com/lxc/lxc/commit/4fee80f9d7d5105b4729d3691437536110f3c20b
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-03-02 (Wed, 02 Mar 2016)

  Changed paths:
    M src/lxc/cgfs.c

  Log Message:
  -----------
  cgfs: be less verbose

don't always warn about unused cgroups, it's noisy and not helpful

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 77afbedf09ed41592817ecd6491ed8ada3babba9
      https://github.com/lxc/lxc/commit/77afbedf09ed41592817ecd6491ed8ada3babba9
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-03-02 (Wed, 02 Mar 2016)

  Changed paths:
    M src/lxc/cgfs.c

  Log Message:
  -----------
  cgfs: don't try to remove cgroups we haven't created

info_ptr->created_paths_count can be 0, so don't blindly dereference
info_ptr->created_paths[ created_paths_count - 1].  Apparently we never
used to have 0 at the cleanup_name_on_this_level before, but now that
we can fail with -eperm and not just -eexist, we do.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: a17d94a593b0ca096690d70a25cf3d434fbbc813
      https://github.com/lxc/lxc/commit/a17d94a593b0ca096690d70a25cf3d434fbbc813
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-03-02 (Wed, 02 Mar 2016)

  Changed paths:
    M src/tests/lxc-test-unpriv

  Log Message:
  -----------
  lxc-test-unpriv: try to start the container a second time

We have nothing else testing this, and it was a real regression in lp
bug 1552355.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: dfc7616801e3c6825062017a1a2f92d3f26ccd8a
      https://github.com/lxc/lxc/commit/dfc7616801e3c6825062017a1a2f92d3f26ccd8a
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-03-02 (Wed, 02 Mar 2016)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h
    M src/tests/lxc-test-unpriv

  Log Message:
  -----------
  Merge pull request #865 from hallyn/2016-03-02/cgfs.rmperms

2016 03 02/cgfs.rmperms


Compare: https://github.com/lxc/lxc/compare/de232a51d793...dfc7616801e3