[lxc-devel] [lxd/master] Check for zero byte send in ReaderToChannel
sean-jc on Github
lxc-bot at linuxcontainers.org
Thu Jun 2 15:39:33 UTC 2016
A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 447 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160602/9226a997/attachment.bin>
-------------- next part --------------
<!DOCTYPE html>
<html lang="en" class="">
<head prefix="og: http://ogp.me/ns# fb: http://ogp.me/ns/fb# object: http://ogp.me/ns/object# article: http://ogp.me/ns/article# profile: http://ogp.me/ns/profile#">
<meta charset='utf-8'>
<link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/frameworks-89838813501af0ab77e1b954a224433f83e8f31af4b3a4570c8343b6a972ba1c.css" media="all" rel="stylesheet" />
<link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/github-308233841d8e7af078ce5873e18f8a07f391a38ce8d12120a384edf406f51c38.css" media="all" rel="stylesheet" />
<link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/site-c2aeff568e26c813514b4d8e4befc924e3863ac2c0ad2aa52a2c4070f1793079.css" media="all" rel="stylesheet" />
<link as="script" href="https://assets-cdn.github.com/assets/frameworks-b801b4f0918b70f4a3a4105efbf8e5c567b4b12e41a263b4805397c93aebf317.js" rel="preload" />
<link as="script" href="https://assets-cdn.github.com/assets/github-9e11266e9840a1629501dc03630329cc0bd58efc0dcfcc89a16868ba1d5c1465.js" rel="preload" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta http-equiv="Content-Language" content="en">
<meta name="viewport" content="width=device-width">
<title>Check for zero byte send in ReaderToChannel by sean-jc · Pull Request #2073 · lxc/lxd · GitHub</title>
<link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub">
<link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub">
<link rel="apple-touch-icon" href="/apple-touch-icon.png">
<link rel="apple-touch-icon" sizes="57x57" href="/apple-touch-icon-57x57.png">
<link rel="apple-touch-icon" sizes="60x60" href="/apple-touch-icon-60x60.png">
<link rel="apple-touch-icon" sizes="72x72" href="/apple-touch-icon-72x72.png">
<link rel="apple-touch-icon" sizes="76x76" href="/apple-touch-icon-76x76.png">
<link rel="apple-touch-icon" sizes="114x114" href="/apple-touch-icon-114x114.png">
<link rel="apple-touch-icon" sizes="120x120" href="/apple-touch-icon-120x120.png">
<link rel="apple-touch-icon" sizes="144x144" href="/apple-touch-icon-144x144.png">
<link rel="apple-touch-icon" sizes="152x152" href="/apple-touch-icon-152x152.png">
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon-180x180.png">
<meta property="fb:app_id" content="1401488693436528">
<meta content="https://avatars2.githubusercontent.com/u/18535971?v=3&s=400" name="twitter:image:src" /><meta content="@github" name="twitter:site" /><meta content="summary" name="twitter:card" /><meta content="Check for zero byte send in ReaderToChannel by sean-jc · Pull Request #2073 · lxc/lxd" name="twitter:title" /><meta content="Run gofmt on shared/util_test.go to resolve a test failure.
Fixes #2072
Signed-off-by: Sean Christopherson sean.j.christopherson at intel.com" name="twitter:description" />
<meta content="https://avatars2.githubusercontent.com/u/18535971?v=3&s=400" property="og:image" /><meta content="GitHub" property="og:site_name" /><meta content="object" property="og:type" /><meta content="Check for zero byte send in ReaderToChannel by sean-jc · Pull Request #2073 · lxc/lxd" property="og:title" /><meta content="https://github.com/lxc/lxd/pull/2073" property="og:url" /><meta content="Run gofmt on shared/util_test.go to resolve a test failure.
Fixes #2072
Signed-off-by: Sean Christopherson sean.j.christopherson at intel.com" property="og:description" />
<meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats">
<meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors">
<link rel="assets" href="https://assets-cdn.github.com/">
<meta name="pjax-timeout" content="1000">
<meta name="msapplication-TileImage" content="/windows-tile.png">
<meta name="msapplication-TileColor" content="#ffffff">
<meta name="selected-link" value="repo_pulls" data-pjax-transient>
<meta name="google-site-verification" content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU">
<meta name="google-site-verification" content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA">
<meta name="google-analytics" content="UA-3769691-2">
<meta content="collector.githubapp.com" name="octolytics-host" /><meta content="github" name="octolytics-app-id" /><meta content="95389400:3A85:2D8A8E84:57505334" name="octolytics-dimension-request_id" />
<meta content="/<user-name>/<repo-name>/pull_requests/show" data-pjax-transient="true" name="analytics-location" />
<meta class="js-ga-set" name="dimension1" content="Logged Out">
<meta name="hostname" content="github.com">
<meta name="user-login" content="">
<meta name="expected-hostname" content="github.com">
<meta name="js-proxy-site-detection-payload" content="OWZjNzQyOGQxMjk5MTYyYjFkYzVlZWUyNGM2NDZjNmZlZTNjY2IyNzcwMTNhOGIxZmVmM2FmYWU1MjI3OTA1YXx7InJlbW90ZV9hZGRyZXNzIjoiMTQ5LjU2LjE0OC4wIiwicmVxdWVzdF9pZCI6Ijk1Mzg5NDAwOjNBODU6MkQ4QThFODQ6NTc1MDUzMzQiLCJ0aW1lc3RhbXAiOjE0NjQ4ODE5NzJ9">
<link rel="mask-icon" href="https://assets-cdn.github.com/pinned-octocat.svg" color="#4078c0">
<link rel="icon" type="image/x-icon" href="https://assets-cdn.github.com/favicon.ico">
<meta name="html-safe-nonce" content="b5fcccc80046ba2d80f29ca17b5a2c0562237ff5">
<meta content="bbe701096943c9bf02be315926072b31ff9cf386" name="form-nonce" />
<meta http-equiv="x-pjax-version" content="f0691b9f15824111b7853857b85a7fd5">
<style type="text/css" media="screen">
span.labelstyle-84b6eb, .linked-labelstyle-84b6eb { background-color: #84b6eb !important; color: #1c2733 !important;}.labelstyle-84b6eb.selected { background-color: #84b6eb !important; color: #1c2733 !important;}.label-select-menu .labelstyle-84b6eb.selected { background:rgba(132, 182, 235, 0.12) !important; color: #557699 !important;}
span.labelstyle-0052cc, .linked-labelstyle-0052cc { background-color: #0052cc !important; color: #fff !important;}.labelstyle-0052cc.selected { background-color: #0052cc !important; color: #fff !important;}.label-select-menu .labelstyle-0052cc.selected { background:rgba(0, 82, 204, 0.12) !important; color: #003d99 !important;}
span.labelstyle-5319e7, .linked-labelstyle-5319e7 { background-color: #5319e7 !important; color: #fff !important;}.labelstyle-5319e7.selected { background-color: #5319e7 !important; color: #fff !important;}.label-select-menu .labelstyle-5319e7.selected { background:rgba(83, 25, 231, 0.12) !important; color: #361099 !important;}
span.labelstyle-006b75, .linked-labelstyle-006b75 { background-color: #006b75 !important; color: #fff !important;}.labelstyle-006b75.selected { background-color: #006b75 !important; color: #fff !important;}.label-select-menu .labelstyle-006b75.selected { background:rgba(0, 107, 117, 0.12) !important; color: #008b99 !important;}
span.labelstyle-009800, .linked-labelstyle-009800 { background-color: #009800 !important; color: #fff !important;}.labelstyle-009800.selected { background-color: #009800 !important; color: #fff !important;}.label-select-menu .labelstyle-009800.selected { background:rgba(0, 152, 0, 0.12) !important; color: #009900 !important;}
span.labelstyle-fbca04, .linked-labelstyle-fbca04 { background-color: #fbca04 !important; color: #332900 !important;}.labelstyle-fbca04.selected { background-color: #fbca04 !important; color: #332900 !important;}.label-select-menu .labelstyle-fbca04.selected { background:rgba(251, 202, 4, 0.12) !important; color: #997b02 !important;}
span.labelstyle-eb6420, .linked-labelstyle-eb6420 { background-color: #eb6420 !important; color: #fff !important;}.labelstyle-eb6420.selected { background-color: #eb6420 !important; color: #fff !important;}.label-select-menu .labelstyle-eb6420.selected { background:rgba(235, 100, 32, 0.12) !important; color: #994114 !important;}
span.labelstyle-e11d21, .linked-labelstyle-e11d21 { background-color: #e11d21 !important; color: #fff !important;}.labelstyle-e11d21.selected { background-color: #e11d21 !important; color: #fff !important;}.label-select-menu .labelstyle-e11d21.selected { background:rgba(225, 29, 33, 0.12) !important; color: #991316 !important;}
</style>
<meta name="description" content="lxd - Daemon based on liblxc offering a REST API to manage containers">
<meta name="go-import" content="github.com/lxc/lxd git https://github.com/lxc/lxd.git">
<meta content="2301756" name="octolytics-dimension-user_id" /><meta content="lxc" name="octolytics-dimension-user_login" /><meta content="26192117" name="octolytics-dimension-repository_id" /><meta content="lxc/lxd" name="octolytics-dimension-repository_nwo" /><meta content="true" name="octolytics-dimension-repository_public" /><meta content="false" name="octolytics-dimension-repository_is_fork" /><meta content="26192117" name="octolytics-dimension-repository_network_root_id" /><meta content="lxc/lxd" name="octolytics-dimension-repository_network_root_nwo" />
<link href="https://github.com/lxc/lxd/commits/2072_zero_byte_send.atom" rel="alternate" title="Recent Commits to lxd:2072_zero_byte_send" type="application/atom+xml">
</head>
<body class="logged-out env-production vis-public">
<div id="js-pjax-loader-bar" class="pjax-loader-bar"></div>
<a href="#start-of-content" tabindex="1" class="accessibility-aid js-skip-to-content">Skip to content</a>
<header class="site-header js-details-container" role="banner">
<div class="container-responsive">
<a class="header-logo-invertocat" href="https://github.com/" aria-label="Homepage" data-ga-click="(Logged out) Header, go to homepage, icon:logo-wordmark">
<svg aria-hidden="true" class="octicon octicon-mark-github" height="32" version="1.1" viewBox="0 0 16 16" width="32"><path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59 0.4 0.07 0.55-0.17 0.55-0.38 0-0.19-0.01-0.82-0.01-1.49-2.01 0.37-2.53-0.49-2.69-0.94-0.09-0.23-0.48-0.94-0.82-1.13-0.28-0.15-0.68-0.52-0.01-0.53 0.63-0.01 1.08 0.58 1.23 0.82 0.72 1.21 1.87 0.87 2.33 0.66 0.07-0.52 0.28-0.87 0.51-1.07-1.78-0.2-3.64-0.89-3.64-3.95 0-0.87 0.31-1.59 0.82-2.15-0.08-0.2-0.36-1.02 0.08-2.12 0 0 0.67-0.21 2.2 0.82 0.64-0.18 1.32-0.27 2-0.27 0.68 0 1.36 0.09 2 0.27 1.53-1.04 2.2-0.82 2.2-0.82 0.44 1.1 0.16 1.92 0.08 2.12 0.51 0.56 0.82 1.27 0.82 2.15 0 3.07-1.87 3.75-3.65 3.95 0.29 0.25 0.54 0.73 0.54 1.48 0 1.07-0.01 1.93-0.01 2.2 0 0.21 0.15 0.46 0.55 0.38C13.71 14.53 16 11.53 16 8 16 3.58 12.42 0 8 0z"></path></svg>
</a>
<button class="btn-link right site-header-toggle js-details-target" type="button" aria-label="Toggle navigation">
<svg aria-hidden="true" class="octicon octicon-three-bars" height="24" version="1.1" viewBox="0 0 12 16" width="18"><path d="M11.41 9H0.59c-0.59 0-0.59-0.41-0.59-1s0-1 0.59-1h10.81c0.59 0 0.59 0.41 0.59 1s0 1-0.59 1z m0-4H0.59c-0.59 0-0.59-0.41-0.59-1s0-1 0.59-1h10.81c0.59 0 0.59 0.41 0.59 1s0 1-0.59 1zM0.59 11h10.81c0.59 0 0.59 0.41 0.59 1s0 1-0.59 1H0.59c-0.59 0-0.59-0.41-0.59-1s0-1 0.59-1z"></path></svg>
</button>
<div class="site-header-menu">
<nav class="site-header-nav site-header-nav-main">
<a href="/personal" class="js-selected-navigation-item nav-item nav-item-personal" data-ga-click="Header, click, Nav menu - item:personal" data-selected-links="/personal /personal">
Personal
</a> <a href="/open-source" class="js-selected-navigation-item nav-item nav-item-opensource" data-ga-click="Header, click, Nav menu - item:opensource" data-selected-links="/open-source /open-source">
Open source
</a> <a href="/business" class="js-selected-navigation-item nav-item nav-item-business" data-ga-click="Header, click, Nav menu - item:business" data-selected-links="/business /business/features /business/customers /business">
Business
</a> <a href="/explore" class="js-selected-navigation-item nav-item nav-item-explore" data-ga-click="Header, click, Nav menu - item:explore" data-selected-links="/explore /trending /trending/developers /integrations /integrations/feature/code /integrations/feature/collaborate /integrations/feature/ship /explore">
Explore
</a> </nav>
<div class="site-header-actions">
<a class="btn btn-primary site-header-actions-btn" href="/join?source=header-repo" data-ga-click="(Logged out) Header, clicked Sign up, text:sign-up">Sign up</a>
<a class="btn site-header-actions-btn mr-2" href="/login?return_to=%2Flxc%2Flxd%2Fpull%2F2073" data-ga-click="(Logged out) Header, clicked Sign in, text:sign-in">Sign in</a>
</div>
<nav class="site-header-nav site-header-nav-secondary">
<a class="nav-item" href="/pricing">Pricing</a>
<a class="nav-item" href="/blog">Blog</a>
<a class="nav-item" href="https://help.github.com">Support</a>
<a class="nav-item header-search-link" href="https://github.com/search">Search GitHub</a>
<div class="header-search scoped-search site-scoped-search js-site-search" role="search">
<!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxd/search" class="js-site-search-form" data-scoped-search-url="/lxc/lxd/search" data-unscoped-search-url="/search" method="get"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /></div>
<label class="form-control header-search-wrapper js-chromeless-input-container">
<div class="header-search-scope">This repository</div>
<input type="text"
class="form-control header-search-input js-site-search-focus js-site-search-field is-clearable"
data-hotkey="s"
name="q"
placeholder="Search"
aria-label="Search this repository"
data-unscoped-placeholder="Search GitHub"
data-scoped-placeholder="Search"
tabindex="1"
autocapitalize="off">
</label>
</form></div>
</nav>
</div>
</div>
</header>
<div id="start-of-content" class="accessibility-aid"></div>
<div id="js-flash-container">
</div>
<div role="main" class="main-content">
<div itemscope itemtype="http://schema.org/SoftwareSourceCode">
<div id="js-repo-pjax-container" data-pjax-container>
<div class="pagehead repohead instapaper_ignore readability-menu experiment-repo-nav">
<div class="container repohead-details-container">
<ul class="pagehead-actions">
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to watch a repository" rel="nofollow">
<svg aria-hidden="true" class="octicon octicon-eye" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M8.06 2C3 2 0 8 0 8s3 6 8.06 6c4.94 0 7.94-6 7.94-6S13 2 8.06 2z m-0.06 10c-2.2 0-4-1.78-4-4 0-2.2 1.8-4 4-4 2.22 0 4 1.8 4 4 0 2.22-1.78 4-4 4z m2-4c0 1.11-0.89 2-2 2s-2-0.89-2-2 0.89-2 2-2 2 0.89 2 2z"></path></svg>
Watch
</a>
<a class="social-count" href="/lxc/lxd/watchers">
132
</a>
</li>
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to star a repository" rel="nofollow">
<svg aria-hidden="true" class="octicon octicon-star" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M14 6l-4.9-0.64L7 1 4.9 5.36 0 6l3.6 3.26L2.67 14l4.33-2.33 4.33 2.33L10.4 9.26 14 6z"></path></svg>
Star
</a>
<a class="social-count js-social-count" href="/lxc/lxd/stargazers">
991
</a>
</li>
<li>
<a href="/login?return_to=%2Flxc%2Flxd"
class="btn btn-sm btn-with-count tooltipped tooltipped-n"
aria-label="You must be signed in to fork a repository" rel="nofollow">
<svg aria-hidden="true" class="octicon octicon-repo-forked" height="16" version="1.1" viewBox="0 0 10 16" width="10"><path d="M8 1c-1.11 0-2 0.89-2 2 0 0.73 0.41 1.38 1 1.72v1.28L5 8 3 6v-1.28c0.59-0.34 1-0.98 1-1.72 0-1.11-0.89-2-2-2S0 1.89 0 3c0 0.73 0.41 1.38 1 1.72v1.78l3 3v1.78c-0.59 0.34-1 0.98-1 1.72 0 1.11 0.89 2 2 2s2-0.89 2-2c0-0.73-0.41-1.38-1-1.72V9.5l3-3V4.72c0.59-0.34 1-0.98 1-1.72 0-1.11-0.89-2-2-2zM2 4.2c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2z m3 10c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2z m3-10c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2z"></path></svg>
Fork
</a>
<a href="/lxc/lxd/network" class="social-count">
184
</a>
</li>
</ul>
<h1 class="entry-title public ">
<svg aria-hidden="true" class="octicon octicon-repo" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M4 9h-1v-1h1v1z m0-3h-1v1h1v-1z m0-2h-1v1h1v-1z m0-2h-1v1h1v-1z m8-1v12c0 0.55-0.45 1-1 1H6v2l-1.5-1.5-1.5 1.5V14H1c-0.55 0-1-0.45-1-1V1C0 0.45 0.45 0 1 0h10c0.55 0 1 0.45 1 1z m-1 10H1v2h2v-1h3v1h5V11z m0-10H2v9h9V1z"></path></svg>
<span class="author" itemprop="author"><a href="/lxc" class="url fn" rel="author">lxc</a></span><!--
--><span class="path-divider">/</span><!--
--><strong itemprop="name"><a href="/lxc/lxd" data-pjax="#js-repo-pjax-container">lxd</a></strong>
</h1>
</div>
<div class="container">
<nav class="reponav js-repo-nav js-sidenav-container-pjax"
itemscope
itemtype="http://schema.org/BreadcrumbList"
role="navigation"
data-pjax="#js-repo-pjax-container">
<span itemscope itemtype="http://schema.org/ListItem" itemprop="itemListElement">
<a href="/lxc/lxd" class="js-selected-navigation-item reponav-item" data-hotkey="g c" data-selected-links="repo_source repo_downloads repo_commits repo_releases repo_tags repo_branches /lxc/lxd" itemprop="url">
<svg aria-hidden="true" class="octicon octicon-code" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M9.5 3l-1.5 1.5 3.5 3.5L8 11.5l1.5 1.5 4.5-5L9.5 3zM4.5 3L0 8l4.5 5 1.5-1.5L2.5 8l3.5-3.5L4.5 3z"></path></svg>
<span itemprop="name">Code</span>
<meta itemprop="position" content="1">
</a> </span>
<span itemscope itemtype="http://schema.org/ListItem" itemprop="itemListElement">
<a href="/lxc/lxd/issues" class="js-selected-navigation-item reponav-item" data-hotkey="g i" data-selected-links="repo_issues repo_labels repo_milestones /lxc/lxd/issues" itemprop="url">
<svg aria-hidden="true" class="octicon octicon-issue-opened" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M7 2.3c3.14 0 5.7 2.56 5.7 5.7S10.14 13.7 7 13.7 1.3 11.14 1.3 8s2.56-5.7 5.7-5.7m0-1.3C3.14 1 0 4.14 0 8s3.14 7 7 7 7-3.14 7-7S10.86 1 7 1z m1 3H6v5h2V4z m0 6H6v2h2V10z"></path></svg>
<span itemprop="name">Issues</span>
<span class="counter">69</span>
<meta itemprop="position" content="2">
</a> </span>
<span itemscope itemtype="http://schema.org/ListItem" itemprop="itemListElement">
<a href="/lxc/lxd/pulls" aria-selected="true" class="js-selected-navigation-item selected reponav-item" data-hotkey="g p" data-selected-links="repo_pulls /lxc/lxd/pulls" itemprop="url">
<svg aria-hidden="true" class="octicon octicon-git-pull-request" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M11 11.28c0-1.73 0-6.28 0-6.28-0.03-0.78-0.34-1.47-0.94-2.06s-1.28-0.91-2.06-0.94c0 0-1.02 0-1 0V0L4 3l3 3V4h1c0.27 0.02 0.48 0.11 0.69 0.31s0.3 0.42 0.31 0.69v6.28c-0.59 0.34-1 0.98-1 1.72 0 1.11 0.89 2 2 2s2-0.89 2-2c0-0.73-0.41-1.38-1-1.72z m-1 2.92c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2zM4 3c0-1.11-0.89-2-2-2S0 1.89 0 3c0 0.73 0.41 1.38 1 1.72 0 1.55 0 5.56 0 6.56-0.59 0.34-1 0.98-1 1.72 0 1.11 0.89 2 2 2s2-0.89 2-2c0-0.73-0.41-1.38-1-1.72V4.72c0.59-0.34 1-0.98 1-1.72z m-0.8 10c0 0.66-0.55 1.2-1.2 1.2s-1.2-0.55-1.2-1.2 0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2z m-1.2-8.8c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2z"></path></svg>
<span itemprop="name">Pull requests</span>
<span class="counter">5</span>
<meta itemprop="position" content="3">
</a> </span>
<a href="/lxc/lxd/pulse" class="js-selected-navigation-item reponav-item" data-selected-links="pulse /lxc/lxd/pulse">
<svg aria-hidden="true" class="octicon octicon-pulse" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M11.5 8L8.8 5.4 6.6 8.5 5.5 1.6 2.38 8H0V10h3.6L4.5 8.2l0.9 5.4L9 8.5l1.6 1.5H14V8H11.5z"></path></svg>
Pulse
</a>
<a href="/lxc/lxd/graphs" class="js-selected-navigation-item reponav-item" data-selected-links="repo_graphs repo_contributors /lxc/lxd/graphs">
<svg aria-hidden="true" class="octicon octicon-graph" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M16 14v1H0V0h1v14h15z m-11-1H3V8h2v5z m4 0H7V3h2v10z m4 0H11V6h2v7z"></path></svg>
Graphs
</a>
</nav>
</div>
</div>
<div class="container new-discussion-timeline experiment-repo-nav">
<div class="repository-content">
<!-- base sha1: "5381dd105d173d46887954e3f630f59043e20877" -->
<!-- head sha1: "cab09bede7fbb7472e008661277d27aaf25b0bc7" -->
<div class="issues-listing" data-pjax>
<div class="clearfix js-issues-results">
<div
id="partial-discussion-header"
class="gh-header js-details-container js-socket-channel js-updatable-content pull request"
data-channel="tenant:1:pull_request:72368920"
data-url="/lxc/lxd/pull/2073/show_partial?partial=pull_requests%2Ftitle">
<div class="gh-header-show ">
<div class="gh-header-actions">
</div>
<h1 class="gh-header-title">
<span class="js-issue-title">Check for zero byte send in ReaderToChannel</span>
<span class="gh-header-number">#2073</span>
</h1>
</div>
<div class="flex-table gh-header-meta">
<div class="flex-table-item">
<div class="state state-open">
<svg aria-hidden="true" class="octicon octicon-git-pull-request" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M11 11.28c0-1.73 0-6.28 0-6.28-0.03-0.78-0.34-1.47-0.94-2.06s-1.28-0.91-2.06-0.94c0 0-1.02 0-1 0V0L4 3l3 3V4h1c0.27 0.02 0.48 0.11 0.69 0.31s0.3 0.42 0.31 0.69v6.28c-0.59 0.34-1 0.98-1 1.72 0 1.11 0.89 2 2 2s2-0.89 2-2c0-0.73-0.41-1.38-1-1.72z m-1 2.92c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2zM4 3c0-1.11-0.89-2-2-2S0 1.89 0 3c0 0.73 0.41 1.38 1 1.72 0 1.55 0 5.56 0 6.56-0.59 0.34-1 0.98-1 1.72 0 1.11 0.89 2 2 2s2-0.89 2-2c0-0.73-0.41-1.38-1-1.72V4.72c0.59-0.34 1-0.98 1-1.72z m-0.8 10c0 0.66-0.55 1.2-1.2 1.2s-1.2-0.55-1.2-1.2 0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2z m-1.2-8.8c-0.66 0-1.2-0.55-1.2-1.2s0.55-1.2 1.2-1.2 1.2 0.55 1.2 1.2-0.55 1.2-1.2 1.2z"></path></svg>
Open
</div>
</div>
<div class="flex-table-item flex-table-item-primary">
<a href="/sean-jc" class="author pull-header-username css-truncate css-truncate-target expandable">
sean-jc
</a>
wants to merge 1 commit into
<span class="commit-ref current-branch css-truncate user-select-contain expandable" title="lxc/lxd:master"><span class="css-truncate-target user">lxc</span>:<span class="css-truncate-target">master</span></span>
from
<span class="commit-ref current-branch css-truncate user-select-contain expandable" title="sean-jc/lxd:2072_zero_byte_send"><span class="css-truncate-target user">sean-jc</span>:<span class="css-truncate-target">2072_zero_byte_send</span></span>
</div>
</div>
</div>
<div class="tabnav tabnav-pr">
<div class="tabnav-extra right">
<span class="diffstat" id="diffstat">
<span class="text-diff-added">
+2
</span>
<span class="text-diff-deleted">
−2
</span>
<span class="tooltipped tooltipped-s" aria-label="4 lines changed">
<span class="block-diff-added"></span><span class="block-diff-added"></span><span class="block-diff-deleted"></span><span class="block-diff-deleted"></span><span class="block-diff-neutral"></span>
</span>
</span>
</div>
<nav class="tabnav-tabs">
<a href="/lxc/lxd/pull/2073" class="tabnav-tab selected js-pjax-history-navigate">
<svg aria-hidden="true" class="octicon octicon-comment-discussion" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M15 2H6c-0.55 0-1 0.45-1 1v2H1c-0.55 0-1 0.45-1 1v6c0 0.55 0.45 1 1 1h1v3l3-3h4c0.55 0 1-0.45 1-1V10h1l3 3V10h1c0.55 0 1-0.45 1-1V3c0-0.55-0.45-1-1-1zM9 12H4.5l-1.5 1.5v-1.5H1V6h4v3c0 0.55 0.45 1 1 1h3v2z m6-3H13v1.5l-1.5-1.5H6V3h9v6z"></path></svg>
Conversation
<span id="conversation_tab_counter" class="counter">
0
</span>
</a>
<a href="/lxc/lxd/pull/2073/commits" class="tabnav-tab js-pjax-history-navigate">
<svg aria-hidden="true" class="octicon octicon-git-commit" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M10.86 7c-0.45-1.72-2-3-3.86-3s-3.41 1.28-3.86 3H0v2h3.14c0.45 1.72 2 3 3.86 3s3.41-1.28 3.86-3h3.14V7H10.86zM7 10.2c-1.22 0-2.2-0.98-2.2-2.2s0.98-2.2 2.2-2.2 2.2 0.98 2.2 2.2-0.98 2.2-2.2 2.2z"></path></svg>
Commits
<span id="commits_tab_counter" class="counter">
1
</span>
</a>
<link rel="pjax-prefetch" href="/lxc/lxd/pull/2073/files">
<a href="/lxc/lxd/pull/2073/files" class="tabnav-tab js-pjax-history-navigate">
<svg aria-hidden="true" class="octicon octicon-diff" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M6 7h2v1H6v2h-1V8H3v-1h2V5h1v2zM3 13h5v-1H3v1z m4.5-11l3.5 3.5v9.5c0 0.55-0.45 1-1 1H1c-0.55 0-1-0.45-1-1V3c0-0.55 0.45-1 1-1h6.5z m2.5 4L7 3H1v12h9V6zM8.5 0S3 0 3 0v1h5l4 4v8h1V4.5L8.5 0z"></path></svg>
Files changed
<span id="files_tab_counter" class="counter">
2
</span>
</a>
</nav>
</div>
<div id="discussion_bucket" class="clearfix pull-request-tab-content is-visible">
<div class="discussion-sidebar js-sticky">
<div id="partial-discussion-sidebar"
class="js-socket-channel js-updatable-content"
data-channel="tenant:1:pull_request:72368920"
data-url="/lxc/lxd/issues/2073/show_partial?partial=issues%2Fsidebar">
<div class="discussion-sidebar-item sidebar-labels js-discussion-sidebar-item">
<!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxd/issues/2073?partial=issues%2Fsidebar%2Fshow%2Flabels" class="js-issue-sidebar-form" data-form-nonce="bbe701096943c9bf02be315926072b31ff9cf386" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="Hae/VBVETeGpIBJUgSZ2wfAVbOTqun9EvFwhojTYznde1GXohwENobNSesCeKB674pOrGusGUlhffcAOUq4XRQ==" /></div>
<h3 class="discussion-sidebar-heading">
Labels
</h3>
<div class="labels css-truncate">
None yet
</div>
</form></div>
<div class="discussion-sidebar-item sidebar-milestone js-discussion-sidebar-item">
<!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxd/issues/2073/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone" class="js-issue-sidebar-form" data-form-nonce="bbe701096943c9bf02be315926072b31ff9cf386" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="BWSSC+j/4IaE9B4SkdgOgTdSPikvfLVNTug4hxzRa/jWtesc7/FKOAGx9pWSxeFiSze4MOA3GcRw5UafW3uPvw==" /></div>
<h3 class="discussion-sidebar-heading">
Milestone
</h3>
No milestone
</form></div>
<div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item">
<!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxd/issues/2073?partial=issues%2Fsidebar%2Fshow%2Fassignees" class="js-issue-sidebar-form" data-form-nonce="bbe701096943c9bf02be315926072b31ff9cf386" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="DIN1XMuZsdWrXRjMI+bAcKKEYQElmUPhClb3C2QZ6MSdDMGBTJJ9wRugiYEjkpl4mxPLqnRDPWWbOmnPExCu3g==" /></div>
<h3 class="discussion-sidebar-heading">
Assignees
</h3>
<span class="css-truncate">
No one assigned
</span>
</form></div>
<div id="partial-users-participants" class="discussion-sidebar-item">
<div class="participation">
<h3 class="discussion-sidebar-heading">
1 participant
</h3>
<div class="participation-avatars">
<a class="participant-avatar tooltipped tooltipped-n" aria-label="sean-jc" href="/sean-jc"><img alt="@sean-jc" class="avatar" height="26" src="https://avatars0.githubusercontent.com/u/18535971?v=3&s=52" width="26" /> </a>
</div>
</div>
</div>
</div>
</div>
<div class="discussion-timeline pull-discussion-timeline js-pull-discussion-timeline js-quote-selection-container ">
<div class="js-discussion js-socket-channel" data-channel="tenant:1:marked-as-read:pull-request:72368920">
<div class="timeline-comment-wrapper js-comment-container">
<a href="/sean-jc"><img alt="@sean-jc" class="timeline-comment-avatar" height="48" src="https://avatars1.githubusercontent.com/u/18535971?v=3&s=96" width="48" /></a>
<div id="issue-158172806"
class="comment previewable-edit timeline-comment js-comment js-task-list-container "
data-body-version="87e45ff7ce8e8ec0305ca654a89f92cb">
<div class="timeline-comment-header ">
<div class="timeline-comment-actions">
</div>
<div class="timeline-comment-header-text">
<strong>
<a href="/sean-jc" class="author">sean-jc</a>
</strong>
commented
<a href="#issue-158172806" class="timestamp"><relative-time datetime="2016-06-02T15:39:30Z">Jun 2, 2016</relative-time></a>
</div>
</div>
<div class="comment-content">
<div class="edit-comment-hide">
<div class="comment-body markdown-body markdown-format js-comment-body">
<p>Run gofmt on shared/util_test.go to resolve a test failure.</p>
<p>Fixes <a href="https://github.com/lxc/lxd/issues/2072" class="issue-link js-issue-link" data-url="https://github.com/lxc/lxd/issues/2072" data-id="158161013" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#2072</a></p>
<p>Signed-off-by: Sean Christopherson <a href="mailto:sean.j.christopherson at intel.com">sean.j.christopherson at intel.com</a></p>
</div>
</div>
</div>
<div class="js-socket-channel js-updatable-content comment-reactions js-reactions-container"
data-channel="tenant:1:reaction:issue:158172806"
data-url="/lxc/lxd/reactions/issue/158172806">
</div>
</div>
</div>
<div class="discussion-item discussion-commits" id="commits-pushed-cab09be">
<div class="discussion-item-body">
<table class="timeline-commits">
<tr class="commit js-details-container js-socket-channel js-updatable-content" data-channel="tenant:1:repo:26192117:commit:cab09bede7fbb7472e008661277d27aaf25b0bc7" data-url="/lxc/lxd/pull/2073/commit/cab09bede7fbb7472e008661277d27aaf25b0bc7/show_partial?partial=commit%2Fpull_condensed">
<td class="commit-icon">
<svg aria-hidden="true" class="octicon octicon-git-commit" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M10.86 7c-0.45-1.72-2-3-3.86-3s-3.41 1.28-3.86 3H0v2h3.14c0.45 1.72 2 3 3.86 3s3.41-1.28 3.86-3h3.14V7H10.86zM7 10.2c-1.22 0-2.2-0.98-2.2-2.2s0.98-2.2 2.2-2.2 2.2 0.98 2.2 2.2-0.98 2.2-2.2 2.2z"></path></svg>
</td>
<td class="commit-gravatar">
<a href="/sean-jc">
<img alt="@sean-jc" class="avatar avatar-small" height="16" src="https://avatars2.githubusercontent.com/u/18535971?v=3&s=32" width="16" />
</a>
</td>
<td class="commit-author">
<strong><a href="/sean-jc" class="author" rel="contributor">sean-jc</a></strong>
</td>
<td class="commit-message">
<code><a href="/lxc/lxd/pull/2073/commits/cab09bede7fbb7472e008661277d27aaf25b0bc7" class="message">Check for zero byte send in ReaderToChannel</a></code>
<span class="hidden-text-expander inline">
<button type="button" class="ellipsis-expander js-details-target">…</button>
</span>
<div class="commit-desc"><pre class="text-small">Run gofmt on shared/util_test.go to resolve a test failure.
Fixes <a href="https://github.com/lxc/lxd/issues/2072" class="issue-link js-issue-link" data-url="https://github.com/lxc/lxd/issues/2072" data-id="158161013" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#2072</a>
Signed-off-by: Sean Christopherson <sean.j.christopherson at intel.com></pre></div>
</td>
<td class="commit-sig-status">
</td>
<td class="commit-ci-status">
</td>
<td class="commit-meta">
<code><a href="/lxc/lxd/pull/2073/commits/cab09bede7fbb7472e008661277d27aaf25b0bc7" class="commit-id">cab09be</a></code>
</td>
</tr>
</table>
</div>
</div>
<!-- Rendered timeline since 2016-06-02 08:35:17 -->
<div id="partial-timeline-marker"
class="js-timeline-marker js-socket-channel js-updatable-content"
data-channel="tenant:1:pull_request:72368920"
data-url="/lxc/lxd/pull/2073/show_partial?partial=pull_requests%2Ftimeline_marker&since=1464881717"
data-last-modified="Thu, 02 Jun 2016 15:35:17 GMT">
<!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxd/notifications/mark?ids=145933315" class="hidden js-timeline-marker-form" data-form-nonce="bbe701096943c9bf02be315926072b31ff9cf386" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="authenticity_token" type="hidden" value="lkCa27V6GsQBI1En3UponRCJ5/c9yLTSDE9o+wt1l2YXbCgYZrZBpR3Pwr9x0Ne+lXg5sJbcNqTZ62J/2otbSw==" /></div>
</form></div>
</div>
<div class="discussion-timeline-actions">
<div class="signed-out-comment">
<a href="/join?source=comment-repo" class="btn btn-primary" rel="nofollow">Sign up for free</a>
<strong>to join this conversation on GitHub</strong>.
Already have an account?
<a href="/login?return_to=https%3A%2F%2Fgithub.com%2Flxc%2Flxd%2Fpull%2F2073" rel="nofollow">Sign in to comment</a>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="modal-backdrop"></div>
</div>
</div>
</div>
</div>
<div class="container site-footer-container">
<div class="site-footer" role="contentinfo">
<ul class="site-footer-links right">
<li><a href="https://status.github.com/" data-ga-click="Footer, go to status, text:status">Status</a></li>
<li><a href="https://developer.github.com" data-ga-click="Footer, go to api, text:api">API</a></li>
<li><a href="https://training.github.com" data-ga-click="Footer, go to training, text:training">Training</a></li>
<li><a href="https://shop.github.com" data-ga-click="Footer, go to shop, text:shop">Shop</a></li>
<li><a href="https://github.com/blog" data-ga-click="Footer, go to blog, text:blog">Blog</a></li>
<li><a href="https://github.com/about" data-ga-click="Footer, go to about, text:about">About</a></li>
</ul>
<a href="https://github.com" aria-label="Homepage" class="site-footer-mark" title="GitHub">
<svg aria-hidden="true" class="octicon octicon-mark-github" height="24" version="1.1" viewBox="0 0 16 16" width="24"><path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59 0.4 0.07 0.55-0.17 0.55-0.38 0-0.19-0.01-0.82-0.01-1.49-2.01 0.37-2.53-0.49-2.69-0.94-0.09-0.23-0.48-0.94-0.82-1.13-0.28-0.15-0.68-0.52-0.01-0.53 0.63-0.01 1.08 0.58 1.23 0.82 0.72 1.21 1.87 0.87 2.33 0.66 0.07-0.52 0.28-0.87 0.51-1.07-1.78-0.2-3.64-0.89-3.64-3.95 0-0.87 0.31-1.59 0.82-2.15-0.08-0.2-0.36-1.02 0.08-2.12 0 0 0.67-0.21 2.2 0.82 0.64-0.18 1.32-0.27 2-0.27 0.68 0 1.36 0.09 2 0.27 1.53-1.04 2.2-0.82 2.2-0.82 0.44 1.1 0.16 1.92 0.08 2.12 0.51 0.56 0.82 1.27 0.82 2.15 0 3.07-1.87 3.75-3.65 3.95 0.29 0.25 0.54 0.73 0.54 1.48 0 1.07-0.01 1.93-0.01 2.2 0 0.21 0.15 0.46 0.55 0.38C13.71 14.53 16 11.53 16 8 16 3.58 12.42 0 8 0z"></path></svg>
</a>
<ul class="site-footer-links">
<li>© 2016 <span title="0.18273s from github-fe152-cp1-prd.iad.github.net">GitHub</span>, Inc.</li>
<li><a href="https://github.com/site/terms" data-ga-click="Footer, go to terms, text:terms">Terms</a></li>
<li><a href="https://github.com/site/privacy" data-ga-click="Footer, go to privacy, text:privacy">Privacy</a></li>
<li><a href="https://github.com/security" data-ga-click="Footer, go to security, text:security">Security</a></li>
<li><a href="https://github.com/contact" data-ga-click="Footer, go to contact, text:contact">Contact</a></li>
<li><a href="https://help.github.com" data-ga-click="Footer, go to help, text:help">Help</a></li>
</ul>
</div>
</div>
<div id="ajax-error-message" class="ajax-error-message flash flash-error">
<svg aria-hidden="true" class="octicon octicon-alert" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M15.72 12.5l-6.85-11.98C8.69 0.21 8.36 0.02 8 0.02s-0.69 0.19-0.87 0.5l-6.85 11.98c-0.18 0.31-0.18 0.69 0 1C0.47 13.81 0.8 14 1.15 14h13.7c0.36 0 0.69-0.19 0.86-0.5S15.89 12.81 15.72 12.5zM9 12H7V10h2V12zM9 9H7V5h2V9z"></path></svg>
<button type="button" class="flash-close js-flash-close js-ajax-error-dismiss" aria-label="Dismiss error">
<svg aria-hidden="true" class="octicon octicon-x" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M7.48 8l3.75 3.75-1.48 1.48-3.75-3.75-3.75 3.75-1.48-1.48 3.75-3.75L0.77 4.25l1.48-1.48 3.75 3.75 3.75-3.75 1.48 1.48-3.75 3.75z"></path></svg>
</button>
Something went wrong with that request. Please try again.
</div>
<script crossorigin="anonymous" src="https://assets-cdn.github.com/assets/compat-7db58f8b7b91111107fac755dd8b178fe7db0f209ced51fc339c446ad3f8da2b.js"></script>
<script crossorigin="anonymous" src="https://assets-cdn.github.com/assets/frameworks-b801b4f0918b70f4a3a4105efbf8e5c567b4b12e41a263b4805397c93aebf317.js"></script>
<script async="async" crossorigin="anonymous" src="https://assets-cdn.github.com/assets/github-9e11266e9840a1629501dc03630329cc0bd58efc0dcfcc89a16868ba1d5c1465.js"></script>
<div class="js-stale-session-flash stale-session-flash flash flash-warn flash-banner hidden">
<svg aria-hidden="true" class="octicon octicon-alert" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M15.72 12.5l-6.85-11.98C8.69 0.21 8.36 0.02 8 0.02s-0.69 0.19-0.87 0.5l-6.85 11.98c-0.18 0.31-0.18 0.69 0 1C0.47 13.81 0.8 14 1.15 14h13.7c0.36 0 0.69-0.19 0.86-0.5S15.89 12.81 15.72 12.5zM9 12H7V10h2V12zM9 9H7V5h2V9z"></path></svg>
<span class="signed-in-tab-flash">You signed in with another tab or window. <a href="">Reload</a> to refresh your session.</span>
<span class="signed-out-tab-flash">You signed out in another tab or window. <a href="">Reload</a> to refresh your session.</span>
</div>
<div class="facebox" id="facebox" style="display:none;">
<div class="facebox-popup">
<div class="facebox-content" role="dialog" aria-labelledby="facebox-header" aria-describedby="facebox-description">
</div>
<button type="button" class="facebox-close js-facebox-close" aria-label="Close modal">
<svg aria-hidden="true" class="octicon octicon-x" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M7.48 8l3.75 3.75-1.48 1.48-3.75-3.75-3.75 3.75-1.48-1.48 3.75-3.75L0.77 4.25l1.48-1.48 3.75 3.75 3.75-3.75 1.48 1.48-3.75 3.75z"></path></svg>
</button>
</div>
</div>
</body>
</html>
More information about the lxc-devel
mailing list