[lxc-devel] [PATCH for stable-1.0 3/3] Improve the help of lxc-create

[Stéphane Graber]

On Wed, Jan 13, 2016 at 07:17:09PM +0900, KATOH Yasufumi wrote:
> * remove unavailable options (-w, -r)
> * remove overlapped option (-P)
> * classify options according to bdev type
> 
> Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  src/lxc/lxc_create.c | 44 +++++++++++++++++++++++++-------------------
>  1 file changed, 25 insertions(+), 19 deletions(-)
> 
> diff --git a/src/lxc/lxc_create.c b/src/lxc/lxc_create.c
> index f1094fb..6107261 100644
> --- a/src/lxc/lxc_create.c
> +++ b/src/lxc/lxc_create.c
> @@ -126,29 +126,35 @@ static struct lxc_arguments my_args = {
>  	.progname = "lxc-create",
>  	.helpfn   = create_helpfn,
>  	.help     = "\
> ---name=NAME -t template [-w] [-r] [-P lxcpath]\n\
> +--name=NAME --template=TEMPLATE [OPTION...]\n\
>  \n\
>  lxc-create creates a container\n\
>  \n\
>  Options :\n\
> -  -n, --name=NAME    NAME of the container\n\
> -  -f, --config=file  Initial configuration file\n\
> -  -t, --template=t   Template to use to setup container\n\
> -  -B, --bdev=BDEV    Backing store type to use\n\
> -  -P, --lxcpath=PATH Place container under PATH\n\
> -  --lvname=LVNAME    Use LVM lv name LVNAME\n\
> -                     (Default: container name)\n\
> -  --vgname=VG        Use LVM vg called VG\n\
> -                     (Default: lxc)\n\
> -  --thinpool=TP      Use LVM thin pool called TP\n\
> -                     (Default: lxc)\n\
> -  --fstype=TYPE      Create fstype TYPE\n\
> -                     (Default: ext3)\n\
> -  --fssize=SIZE[U]   Create filesystem of size SIZE * unit U (bBkKmMgGtT)\n\
> -                     (Default: 1G, default unit: M)\n\
> -  --dir=DIR          Place rootfs directory under DIR\n\
> -  --zfsroot=PATH     Create zfs under given zfsroot\n\
> -                     (Default: tank/lxc)\n",
> +  -n, --name=NAME               NAME of the container\n\
> +  -f, --config=CONFIG           Initial configuration file\n\
> +  -t, --template=TEMPLATE       Template to use to setup container\n\
> +  -B, --bdev=BDEV               Backing store type to use\n\
> +      --dir=DIR                 Place rootfs directory under DIR\n\
> +\n\
> +  BDEV options for LVM (with -B/--bdev lvm):\n\
> +      --lvname=LVNAME    Use LVM lv name LVNAME\n\
> +                         (Default: container name)\n\
> +      --vgname=VG        Use LVM vg called VG\n\
> +                         (Default: lxc)\n\
> +      --thinpool=TP      Use LVM thin pool called TP\n\
> +                         (Default: lxc)\n\
> +\n\
> +  BDEV option for ZFS (with -B/--bdev zfs) :\n\
> +      --zfsroot=PATH            Create zfs under given zfsroot\n\
> +                                (Default: tank/lxc)\n\
> +\n\
> +  BDEV options for LVM or Loop (with -B/--bdev lvm/loop) :\n\
> +      --fstype=TYPE             Create fstype TYPE\n\
> +                                (Default: ext3)\n\
> +      --fssize=SIZE[U]          Create filesystem of\n\
> +                                size SIZE * unit U (bBkKmMgGtT)\n\
> +                                (Default: 1G, default unit: M)\n",
>  	.options  = my_longopts,
>  	.parser   = my_parser,
>  	.checker  = NULL,
> -- 
> 2.6.3
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160128/56d68a48/attachment.sig>