[lxc-devel] [PATCH] cgmanager: don't make tasks + cgroup.procs +x

Serge Hallyn serge.hallyn at ubuntu.com
Wed Jan 13 21:45:50 UTC 2016


Quoting Tycho Andersen (tycho.andersen at canonical.com):
> No reason for these to be +x, and it looks weird.
> 
> Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>

But it makes them a pretty green color in my terminal.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/cgmanager.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c
> index 5596285..357182a 100644
> --- a/src/lxc/cgmanager.c
> +++ b/src/lxc/cgmanager.c
> @@ -509,9 +509,9 @@ static bool chown_cgroup(const char *cgroup_path, struct lxc_conf *conf)
>  	for (i = 0; slist[i]; i++) {
>  		if (!lxc_cgmanager_chmod(slist[i], cgroup_path, "", 0775))
>  			return false;
> -		if (!lxc_cgmanager_chmod(slist[i], cgroup_path, "tasks", 0775))
> +		if (!lxc_cgmanager_chmod(slist[i], cgroup_path, "tasks", 0664))
>  			return false;
> -		if (!lxc_cgmanager_chmod(slist[i], cgroup_path, "cgroup.procs", 0775))
> +		if (!lxc_cgmanager_chmod(slist[i], cgroup_path, "cgroup.procs", 0664))
>  			return false;
>  	}
>  
> -- 
> 2.6.4
> 
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel


More information about the lxc-devel mailing list