[lxc-devel] [PATCH] open_without_symlink: Account when prefix is empty string

Bogdan Purcareata bogdan.purcareata at nxp.com
Fri Jan 8 15:38:35 UTC 2016


In the current implementation, the open_without_symlink function
will default to opening the root mount only if the passed rootfs
prefix is null. It doesn't account for the case where this prefix
is passed as an empty string.

Properly handle this second case as well.

Signed-off-by: Bogdan Purcareata <bogdan.purcareata at nxp.com>
---
 src/lxc/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index ad9b0a2..8fa7e6b 100644
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1570,7 +1570,7 @@ static int open_without_symlink(const char *target, const char *prefix_skip)
 	fulllen = strlen(target);
 
 	/* make sure prefix-skip makes sense */
-	if (prefix_skip) {
+	if (prefix_skip && strlen(prefix_skip) > 0) {
 		curlen = strlen(prefix_skip);
 		if (!is_subdir(target, prefix_skip, curlen)) {
 			ERROR("WHOA there - target '%s' didn't start with prefix '%s'",
-- 
2.1.4



More information about the lxc-devel mailing list