[lxc-devel] [lxc/master] cgfs: don't try to chown/chmod non-existing paths

brauner on Github lxc-bot at linuxcontainers.org
Sat Feb 27 16:07:17 UTC 2016


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 457 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160227/aa2d908d/attachment.bin>
-------------- next part --------------
From 45b33434eddcaa9cdea931fb2a88158d8d0a5317 Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at mailbox.org>
Date: Sat, 27 Feb 2016 17:00:45 +0100
Subject: [PATCH] cgfs: don't try to chown/chmod non-existing paths

Dirty fix for the current noisiness when lxc_cgroupfs_create() could not create
cgroups.

Signed-off-by: Christian Brauner <christian.brauner at mailbox.org>
---
 src/lxc/cgfs.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/lxc/cgfs.c b/src/lxc/cgfs.c
index 16c80eb..22e508d 100644
--- a/src/lxc/cgfs.c
+++ b/src/lxc/cgfs.c
@@ -162,6 +162,9 @@ static int cgroup_rmdir(char *dirname)
 	int ret, failed=0;
 	char pathname[MAXPATHLEN];
 
+	if (!dir_exists(dirname))
+		return 0;
+
 	dir = opendir(dirname);
 	if (!dir) {
 		ERROR("%s: failed to open %s", __func__, dirname);
@@ -2518,7 +2521,6 @@ static int chown_cgroup_wrapper(void *data)
 	uid_t destuid;
 	char *fpath;
 
-
 	if (setresgid(0,0,0) < 0)
 		SYSERROR("Failed to setgid to 0");
 	if (setresuid(0,0,0) < 0)
@@ -2536,6 +2538,7 @@ static int chown_cgroup_wrapper(void *data)
 	if (chown(fpath, destuid, 0) < 0)
 		SYSERROR("Error chowning %s\n", fpath);
 	free(fpath);
+
 	fpath = lxc_append_paths(arg->cgroup_path, "cgroup.procs");
 	if (!fpath)
 		return -1;
@@ -2551,6 +2554,9 @@ static bool do_cgfs_chown(char *cgroup_path, struct lxc_conf *conf)
 	struct chown_data data;
 	char *fpath;
 
+	if (!dir_exists(cgroup_path))
+		return true;
+
 	if (lxc_list_empty(&conf->id_map))
 		/* If there's no mapping then we don't need to chown */
 		return true;


More information about the lxc-devel mailing list