[lxc-devel] [lxc/lxc] ea439a: fix cgfs failure for unpriv users

GitHub noreply at github.com
Fri Feb 26 20:55:29 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ea439aaca19806baab514e67da20ac527de2f96c
      https://github.com/lxc/lxc/commit/ea439aaca19806baab514e67da20ac527de2f96c
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-02-26 (Fri, 26 Feb 2016)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h

  Log Message:
  -----------
  fix cgfs failure for unpriv users

Cgmanager was taught awhile ago that only some cgroup controllers are
crucial.  Teach cgfs the same thing.

This patch needs improvement, but will fix failure of lxc without cgmanager
for unprivileged users for now.  In particular, needed improvements include:

1. the check for crucial subsystems needs to include lxc.use
2. we should keep a list of the actually used subsystems so we don't keep
trying to chmod and enter after create has found we couldn't use a particular
subsystem

This fixes unprivileged lxc use.  It does not appear to suffice to fix
nested unprivilegd lxd usage.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 5d55659daae5aa70cd579be4bee942a07173440c
      https://github.com/lxc/lxc/commit/5d55659daae5aa70cd579be4bee942a07173440c
  Author: Christian Brauner <christian.brauner at mailbox.org>
  Date:   2016-02-26 (Fri, 26 Feb 2016)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/cgroup.c
    M src/lxc/cgroup.h

  Log Message:
  -----------
  Merge pull request #855 from hallyn/2016-02-26/cgfs.crucial

fix cgfs failure for unpriv users


Compare: https://github.com/lxc/lxc/compare/127ef998ed3d...5d55659daae5


More information about the lxc-devel mailing list