[lxc-devel] [lxc/lxc] 3f53c6: log.c:__lxc_log_set_file: fname cannot be null

GitHub noreply at github.com
Mon Feb 15 20:38:01 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 3f53c691d248434fdb817e615495d9c419af07d1
      https://github.com/lxc/lxc/commit/3f53c691d248434fdb817e615495d9c419af07d1
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-02-15 (Mon, 15 Feb 2016)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log.c:__lxc_log_set_file: fname cannot be null

fname cannot be passed in as NULL by any of its current callers.  If it
could, then build_dir() would crash as it doesn't check for it.  So make
sure we are warned if in the future we pass in NULL.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: d9c9b1808af250ec37379c7f0242941a450aa3af
      https://github.com/lxc/lxc/commit/d9c9b1808af250ec37379c7f0242941a450aa3af
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2016-02-15 (Mon, 15 Feb 2016)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log.c:__lxc_log_set_file: completely close log file when overriding

Otherwise after a shortcut on error we could end up trying to write
to the closed log fd.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: ae07a9bfda05d59d0e52219965cc8fe1cb84bfbb
      https://github.com/lxc/lxc/commit/ae07a9bfda05d59d0e52219965cc8fe1cb84bfbb
  Author: Christian Brauner <christian.brauner at mailbox.org>
  Date:   2016-02-15 (Mon, 15 Feb 2016)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  Merge pull request #821 from hallyn/2016-02-15/lognull

2016 02 15/lognull


Compare: https://github.com/lxc/lxc/compare/bad548de3ba4...ae07a9bfda05


More information about the lxc-devel mailing list