[lxc-devel] [lxc/lxc] b44c42: tools: use fclose() after fdopen() + add newline

GitHub noreply at github.com
Sun Aug 14 21:03:26 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b44c42e8f09eb78f85afb567b7ec847538156ae7
      https://github.com/lxc/lxc/commit/b44c42e8f09eb78f85afb567b7ec847538156ae7
  Author: Christian Brauner <cbrauner at suse.de>
  Date:   2016-08-14 (Sun, 14 Aug 2016)

  Changed paths:
    M src/lxc/tools/lxc_copy.c

  Log Message:
  -----------
  tools: use fclose() after fdopen() + add newline

So far we accidently used close() on the original file descriptor. (After
fdopen() the original fd is considered private and should not be used anymore.
The close operations should be performed on the new file handle. We did the
correct thing on error but not on success.) Using close() on the original fd
caused "Text file busy" errors and prevented the cloned tmpfs container from
starting.

Signed-off-by: Christian Brauner <cbrauner at suse.de>


  Commit: b9977146fc8597aadda6b67ce2d76bf93088225a
      https://github.com/lxc/lxc/commit/b9977146fc8597aadda6b67ce2d76bf93088225a
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-08-14 (Sun, 14 Aug 2016)

  Changed paths:
    M src/lxc/tools/lxc_copy.c

  Log Message:
  -----------
  Merge pull request #1128 from brauner/2016-08-14/fix_text_file_busy

tools: use fclose() after fdopen() + add newline


Compare: https://github.com/lxc/lxc/compare/4b281e126493...b9977146fc85


More information about the lxc-devel mailing list