[lxc-devel] [lxc/lxc] da4156: simplify pty allocation and implement pty logging

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: da41561c72067a5e109e8c5482dbeb4131641dc2
      https://github.com/lxc/lxc/commit/da41561c72067a5e109e8c5482dbeb4131641dc2
  Author: Christian Brauner <christian.brauner at mailbox.org>
  Date:   2016-04-08 (Fri, 08 Apr 2016)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/console.h
    M src/lxc/lxc_attach.c
    M src/lxc/start.c

  Log Message:
  -----------
  simplify pty allocation and implement pty logging

lxc-attach allocated a pty in a manner that relied on ts->stdinfd and
ts->stdoutfd to be set. We had to resort to a trick to get it working when
output is redirected. The new implementation gets rid of the black magic and
also simplifies the code.

This commit also implements pty logging for lxc-attach. Users will now be able
to log commands and corresponding output to a file given that lxc-attach
allocates a pty.

Signed-off-by: Christian Brauner <christian.brauner at mailbox.org>


  Commit: 6a874d31a76396da64204ca8e90f891b24081f4e
      https://github.com/lxc/lxc/commit/6a874d31a76396da64204ca8e90f891b24081f4e
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2016-04-08 (Fri, 08 Apr 2016)

  Changed paths:
    M src/lxc/console.c
    M src/lxc/console.h
    M src/lxc/lxc_attach.c
    M src/lxc/start.c

  Log Message:
  -----------
  Merge pull request #953 from brauner/2016-04-08/lxc_attach_simplify_and_log

simplify pty allocation and implement pty logging


Compare: https://github.com/lxc/lxc/compare/aa3ea4d3ccfc...6a874d31a763