[lxc-devel] [PATCH v2 0/7] stop hook with namespace access

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Sep 30 10:18:50 UTC 2015


* Added sign-off lines
* Added acked-by serge to the ones he acked in the RFC email series
* Patch 5: moved the counter increment to after the error handling
* Added stop hook documentation (Patch 6)
* Added hooks/unmount-namespace.c (Patch 7)

Summary from the [RFC] series replies:
Serge Hallyn mentioned some multiarch concerns regarding the last patch
(the unmount stop hook code), so I'm expecting some comments on that one from
Stéphane I suppose.

Patch 5 hasn't been acked yet, due to the counting error (should be fixed here
now). The format in which the files are passed hasn't been discussed, which is
fine if it's fine, of course ;-).

The unmount-namespace.c should be mostly the same as the one I posted as a
follow-up email except for changes in style, indentation and comments.
I also added a copyright header. There are several different ones of those in
the source, so please tell me if you want it to look different.

Wolfgang Bumiller (7):
  start.c:preserve_ns: added pid parameter
  preserve container namespace
  added stop-hook entries
  run stop hook between STOPPING and STOPPED states
  pass namespace handles to the stop hook
  document the stop hook
  added the unmount-namespace hook

 doc/lxc.container.conf.sgml.in |  27 ++++++-
 hooks/Makefile.am              |   6 ++
 hooks/unmount-namespace.c      | 180 +++++++++++++++++++++++++++++++++++++++++
 src/lxc/conf.c                 |   4 +-
 src/lxc/conf.h                 |   2 +-
 src/lxc/confile.c              |   3 +
 src/lxc/start.c                |  47 ++++++++++-
 src/lxc/start.h                |   1 +
 8 files changed, 262 insertions(+), 8 deletions(-)
 create mode 100644 hooks/unmount-namespace.c

-- 
2.1.4




More information about the lxc-devel mailing list