[lxc-devel] [PATCH 1/3] lxc-checkconfig: add some more config options

[Tycho Andersen]

On Mon, Sep 14, 2015 at 02:17:03PM +0000, Serge Hallyn wrote:
> Quoting Tycho Andersen (tycho.andersen at canonical.com):
> > Here's some more config options that we do actually require to be able to
> > boot containers.
> > 
> > Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> 
> I wonder if it's worth augmenting the script to know about
> missing, required, and a new optional flag.  Things like c/r
> and probably even ipv6 could be marked optional.

Yeah, I thought about doing this but then I got lazy. I suppose we
could just put (optional) after things that are, I can send a patch on
top of this one to do that.

Tycho

> Probably not worth our time, though, as this script is mainly an
> informative thing...
> 
> > ---
> >  src/lxc/lxc-checkconfig.in | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/src/lxc/lxc-checkconfig.in b/src/lxc/lxc-checkconfig.in
> > index a4c3ecb..247b70f 100644
> > --- a/src/lxc/lxc-checkconfig.in
> > +++ b/src/lxc/lxc-checkconfig.in
> > @@ -111,6 +111,25 @@ echo "--- Misc ---"
> >  echo -n "Veth pair device: " && is_enabled CONFIG_VETH
> >  echo -n "Macvlan: " && is_enabled CONFIG_MACVLAN
> >  echo -n "Vlan: " && is_enabled CONFIG_VLAN_8021Q
> > +echo -n "Bridges: " && is_enabled CONFIG_BRIDGE
> > +echo -n "Advanced netfilter: " && is_enabled CONFIG_NETFILTER_ADVANCED
> > +echo -n "CONFIG_NF_NAT_IPV4: " && is_enabled CONFIG_NF_NAT_IPV4
> > +echo -n "CONFIG_NF_NAT_IPV6: " && is_enabled CONFIG_NF_NAT_IPV6
> > +echo -n "CONFIG_IP_NF_TARGET_MASQUERADE: " && is_enabled CONFIG_IP_NF_TARGET_MASQUERADE
> > +echo -n "CONFIG_IP6_NF_TARGET_MASQUERADE: " && is_enabled CONFIG_IP6_NF_TARGET_MASQUERADE
> > +echo -n "CONFIG_NETFILTER_XT_TARGET_CHECKSUM: " && is_enabled CONFIG_NETFILTER_XT_TARGET_CHECKSUM
> > +
> > +echo
> > +echo "--- Checkpoint/Restore ---"
> > +echo -n "checkpoint restore: " && is_enabled CONFIG_CHECKPOINT_RESTORE
> > +echo -n "CONFIG_FHANDLE: " && is_enabled CONFIG_FHANDLE
> > +echo -n "CONFIG_EVENTFD: " && is_enabled CONFIG_EVENTFD
> > +echo -n "CONFIG_EPOLL: " && is_enabled CONFIG_EPOLL
> > +echo -n "CONFIG_UNIX_DIAG: " && is_enabled CONFIG_UNIX_DIAG
> > +echo -n "CONFIG_INET_DIAG: " && is_enabled CONFIG_INET_DIAG
> > +echo -n "CONFIG_PACKET_DIAG: " && is_enabled CONFIG_PACKET_DIAG
> > +echo -n "CONFIG_NETLINK_DIAG: " && is_enabled CONFIG_NETLINK_DIAG
> > +
> >  echo -n "File capabilities: " && \
> >      ( [ "${KVER_MAJOR}" = 2 ] && [ ${KVER_MINOR} -lt 33 ] && \
> >         is_enabled CONFIG_SECURITY_FILE_CAPABILITIES ) || \
> > -- 
> > 2.1.4
> > 
> > _______________________________________________
> > lxc-devel mailing list
> > lxc-devel at lists.linuxcontainers.org
> > http://lists.linuxcontainers.org/listinfo/lxc-devel
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel