[lxc-devel] [lxc/lxc] 62d05d: Better handle preserve_ns behavior

GitHub noreply at github.com
Wed Nov 18 05:18:27 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 62d05d9b4b862eef14639096c3e6e34871bf8610
      https://github.com/lxc/lxc/commit/62d05d9b4b862eef14639096c3e6e34871bf8610
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2015-11-17 (Tue, 17 Nov 2015)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  Better handle preserve_ns behavior

Commit b6b2b194a8 preserves the container's namespaces for
possible later use in stop hook.  But some kernels don't have
/proc/pid/ns/ns for all the namespaces we may be interested in.
So warn but continue if this is the case.

Implement stgraber's suggested semantics.

 - User requests some namespaces be preserved:
    - If /proc/self/ns is missing => fail (saying kernel misses setns)
    - If /proc/self/ns/<namespace> entry is missing => fail (saying kernel misses setns for <namespace>)
 - User doesn't request some namespaces be preserved:
    - If /proc/self/ns is missing => log an INFO message (kernel misses setns) and continue
    - If /proc/self/ns/<namespace> entry is missing => log an INFO message (kernel misses setns for <namespace>) and continue

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: e8f6a15cfa766676863645c448835dd9da9af9a0
      https://github.com/lxc/lxc/commit/e8f6a15cfa766676863645c448835dd9da9af9a0
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  Merge pull request #700 from hallyn/2015-11-17/preserve_ns.2

Better handle preserve_ns behavior


Compare: https://github.com/lxc/lxc/compare/9dbcd6683346...e8f6a15cfa76


More information about the lxc-devel mailing list