[lxc-devel] [PATCH 1/1] sleep 0.5s on reboot

[Serge Hallyn]

Quoting Stéphane Graber (stgraber at ubuntu.com):
> On Thu, Nov 12, 2015 at 05:02:23PM +0000, Serge Hallyn wrote:
> > Quoting Stéphane Graber (stgraber at ubuntu.com):
> > > On Thu, Nov 12, 2015 at 04:29:46PM +0000, Serge Hallyn wrote:
> > > > Quoting Stéphane Graber (stgraber at ubuntu.com):
> > > > > On Thu, Nov 12, 2015 at 07:52:16AM +0000, Serge Hallyn wrote:
> > > > > > to give lxcfs' cgroup view time out.
> > > > > 
> > > > > Where does that 500ms come from? is it guaranteed that the kernel or
> > > > > fuse will flush the cache by then?
> > > > 
> > > > I've set it in lxcfs: https://github.com/lxc/lxcfs/commit/f466a31e0a6e271a0458a1eddc8e4452e6a59f41
> > > > 
> > > > The default is 1s.
> > > > 
> > > > > Also, can't this be implemented as a hook? if so, we could just add this
> > > > > to the lxcfs config snippet, making this more self-contained.
> > > > 
> > > > Urgh.  I suppose it could.  If it were something other than reboot I would
> > > > have probably done so, but reboot seemed an ok place to wait half a sec.
> > > 
> > > If it can be implemented with one of our existing hooks (is post-stop
> > > called?), then we should do that, if it can't be done with our existing
> > > hooks, then I'm fine with the sleep.
> > 
> > Yeah that should work, though it would also run on shutdown.
> 
> That was my hope actually.
> 
> LXD never calls restart, instead it does a very quick stop+start, so we
> do need a sleep on shutdown too.

https://github.com/lxc/lxcfs/pull/53