[lxc-devel] [lxc/lxc] e0bc10: Use POSIX-compliant function names in bash complet...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e0bc1067693e30644f60071f0fc861a84fb3fbb6
      https://github.com/lxc/lxc/commit/e0bc1067693e30644f60071f0fc861a84fb3fbb6
  Author: Lucas Werkmeister <mail at lucaswerkmeister.de>
  Date:   2015-05-14 (Thu, 14 May 2015)

  Changed paths:
    M config/bash/lxc.in

  Log Message:
  -----------
  Use POSIX-compliant function names in bash completion

When running in posix mode (for example, because it was invoked as `sh`,
or with the --posix option), bash rejects the function names previously
used because they contain hyphens, which are not legal POSIX names, and
exits immediately.

This is a particularly serious problem on a system in which the
following three conditions hold:

1. The `sh` executable is provided by bash, e. g. via a symlink
2. Gnome Display Manager is used to launch X sessions
3. Bash completion is loaded in the (system or user) profile file
   instead of in the bashrc file

In that case, GDM's Xsession script (run with `sh`, i. e., bash in posix
mode) sources the profile files, thus causing the shell to load the bash
completion files. Upon encountering the non-POSIX-compliant function
names, bash would then exit, immediately ending the X session.

Fixes #521.

Signed-off-by: Lucas Werkmeister <mail at lucaswerkmeister.de>


  Commit: 8ec0243d0a2cd769e0d508e7c86df119e68af85f
      https://github.com/lxc/lxc/commit/8ec0243d0a2cd769e0d508e7c86df119e68af85f
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2015-05-14 (Thu, 14 May 2015)

  Changed paths:
    M config/bash/lxc.in

  Log Message:
  -----------
  Merge pull request #523 from lucaswerkmeister/fix521

Use POSIX-compliant function names in bash completion


Compare: https://github.com/lxc/lxc/compare/19fcf68ffb17...8ec0243d0a2c