[lxc-devel] [lxc/lxc] aaf268: Sort the cgroup memory settings before applying.

GitHub noreply at github.com
Mon May 11 17:52:51 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: aaf26830526092805f9c6d87548edacff77727da
      https://github.com/lxc/lxc/commit/aaf26830526092805f9c6d87548edacff77727da
  Author: Kien Truong <duckientruong at gmail.com>
  Date:   2015-05-05 (Tue, 05 May 2015)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/conf.c
    M src/lxc/conf.h

  Log Message:
  -----------
  Sort the cgroup memory settings before applying.

Add a function to sort the cgroup settings before applying.
Currently, the function will put memory.memsw.limit_in_bytes after
memory.limit_in_bytes setting so the container will start
regardless of the order specified in the input. Fix #453

Signed-off-by: Kien Truong <duckientruong at gmail.com>


  Commit: fac7c663865a706b521dcdb3182c92e93bf0c721
      https://github.com/lxc/lxc/commit/fac7c663865a706b521dcdb3182c92e93bf0c721
  Author: Kien Truong <duckientruong at gmail.com>
  Date:   2015-05-05 (Tue, 05 May 2015)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/conf.c

  Log Message:
  -----------
  Check malloc failure when sorting cgroup settings.

Signed-off-by: Kien Truong <duckientruong at gmail.com>


  Commit: 365d180a391f75002b091b2ff8de7b21bc3aa5e4
      https://github.com/lxc/lxc/commit/365d180a391f75002b091b2ff8de7b21bc3aa5e4
  Author: Kien Truong <duckientruong at gmail.com>
  Date:   2015-05-05 (Tue, 05 May 2015)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c

  Log Message:
  -----------
  Properly free memory of sorted cgroup settings

We need to use lxc_list_for_each_safe, otherwise de-allocation
will fail with a list size bigger than 2. The pointer to the head
of the list also need freeing after we've freed all other elements
of the list.

Signed-off-by: Kien Truong <duckientruong at gmail.com>


  Commit: e7831129a2519dab45d69a486e9e64dd104d6406
      https://github.com/lxc/lxc/commit/e7831129a2519dab45d69a486e9e64dd104d6406
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2015-05-11 (Mon, 11 May 2015)

  Changed paths:
    M src/lxc/cgfs.c
    M src/lxc/cgmanager.c
    M src/lxc/conf.c
    M src/lxc/conf.h

  Log Message:
  -----------
  Merge pull request #486 from dikei/master

Sort the cgroup memory settings before applying.


Compare: https://github.com/lxc/lxc/compare/54c23a6a623e...e7831129a251


More information about the lxc-devel mailing list