[lxc-devel] [PATCH] lxc-checkpoint: add pre-checkpoint

[Tycho Andersen]

Hey Ruslan,

On Fri, Jun 26, 2015 at 11:24:32AM +0300, Ruslan Kuprieiev wrote:
> Drop this one, please.

I'm assuming you're probably going to send another version at some
point, a question below.

> >diff --git a/src/lxc/lxccontainer.h b/src/lxc/lxccontainer.h
> >index d60e19a..1faded2 100644
> >--- a/src/lxc/lxccontainer.h
> >+++ b/src/lxc/lxccontainer.h
> >@@ -773,7 +773,7 @@ struct lxc_container {
> >  	 * \return \c true on success, else \c false.
> >  	 * present at compile time).
> >  	 */
> >-	bool (*checkpoint)(struct lxc_container *c, char *directory, bool stop, bool verbose);
> >+	bool (*checkpoint)(struct lxc_container *c, char *directory, char *prev_dir, bool stop, bool verbose);

Here we're making an ABI change, and I'm not sure what the protocol in
LXC for this (Stéphane or Serge can tell us I'm sure :). Whatever the
case, we'll have to do some tap dancing here. It may (?) be worth
turning this into an argument struct with version information to avoid
this in the future, depending on how we solve this.

Anyway, I just thought I'd get the discussion started.

Tycho