[lxc-devel] [PATCH] pass on reboot flag and delete old veth on reboot

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Jul 24 16:47:35 UTC 2015


> For ease of future git history reviewers, please point out specifically
> that this means setting lxc.network.veth.pair.

will do

> Tested that this does fix the issue, so once you handle the error
> cases in __lxc_start (easily done with a new label), I'll happily
> ack - thanks much.

I can do that, but wanted to run another idea by you first:
Since conf->reboot is currently an int instead of a bool, it might be even
easier to make it a three-state value, that way no current or future error
caseswould have to deal with it specially.
Essentially doing:

if (conf->reboot == 1) { // note the ==1
    conf->reboot = 2; // avoid infinite looping
    goto reboot;
}

It would retain its boolean truth value and deal with the error cases.
The reset to 0 after spawning would still be there to allow multiple
reboots in a row (obviously).



More information about the lxc-devel mailing list